In situations where anon account creation is disabled or when
combined login link would be used, the usermenu array contains
single element (for 'login' or 'login/create') instead of two
elements ('login' and 'create account' items separately)
If $wgWikimediaMessagesAnonDonateLink is enabled through the
WikimediaMessages extension, the third element 'sitesupport'
exists, making the number of anon items either 1 or 2 or 3.
This patch fixes $isDefaultAnonUserLinks variable to account
for all the cases
Additionally, if even login is disabled, the element count can be
zero and in such case we need to hide the dropdown in all cases
(not only on large viewports) because it would always be empty.
This patch passes the userlinks count to ::getDropdown() and adds
CSS class when appropriate to hide the drowpdown completely.
Bug: T332743
Change-Id: I1ce5e1ea30917a6e80ef00f3c1703cbd0ecb6968
Move CdxTypeaheadSearch out of render blocking module - it is not
needed - only CdxSearchInput is rendered by default.
Bug: T378636
Change-Id: Id4feb26f73413826cf04ec200d0d501c6b057bfc
To make sure this is code-ified I have added the rule selector-max-specificity
to check specificity and error if we ever attempt to change this and to also
prevent us from writing overly complicated selectors (for now the default is
based on the status quo)
Additional change is required to skinStyle file to accomodate the new rule.
Bug: T373989
Change-Id: I3921d1fb3a098faae8f5a8bdc895783f1b298daa
Add `cursor: inherit;` to the class `mw-selflink` to get back
the expected behaviour of these 'links'.
Bug: T375876
Change-Id: I52d54dc1265fd1a64bc461892e69475a3b3d50b2
Going forward these styles will be provided where needed by
the mediawiki.legacy.messageBox module.
Bug: T360668
Change-Id: I58d9e41f0c98adbd816240b161b5145a667436cd
Due to T343838, we need to adjust the Echo icon after clicking
so it renders consistently with Codex. This is a longstanding bug
and a slight adjustment to how we approach the icon now that Codex
and Vector 2022 use mask-image for their icons.
Bug: T373936
Change-Id: Icdb9cc49c157cb5cbf13fe1f7d5e91b7e986e92e
This was introduced in I16411a7ea47, which only documented the
changes to the colors used. An unintended side effect was inheriting
the standard border-radius, but that should be applied in a
more targetted manner to avoid conflicting with existing
UI components (e.g. OOUI toolbars).
Bug: T373989
Change-Id: I0615ce1594d66cb5207cd119597ae4d0765e94af
Visual changes are subtle, but impact 43 scenarios. The color
and positioning is slightly modified to match Codex.
Bug: T363920
Change-Id: Ie5c88e0aa243f73f2dc9f310d18fd59b831edc64
Follow-up to badd229bab. Moving
`position: sticky` to the same element as `contain: paint` defeated
the workaround. Move it to the parent elements again to make it work.
Bug: T373066
Change-Id: Ic942bfd599661a29cf7b2dbb6c6cc2ec521b8c82
This reverts commit b3ca12e628.
Reason for revert: Icons are appearing black on black in dark mode
in origin/wmf/1.43.0-wmf.18.
Change-Id: Ifdf3970c77b66e5a7835ca44eb45deec2b44eb43
This changes nothing about the existing classes, it just improves
how they are documented.
The FIXME comment was making things confusing.
Make sure every feature class is accounted for and audited and
throw a RuntimeException if we forget to document it.
Change-Id: I9d8f6553fe6b8c2ae80d8b2490c8895a8334a537
Add hook that renders when search displays for first time to allow
experimentation.
Code can call
```
mw.hook( 'search.display' ).add((node)=> { node.innerHTML = 'hello world' } );
Bug: T371294
Change-Id: Ib3ec73b8ed66877c11e0d8d290a6b564a013702b
Prevents dark-mode styles from affecting print media
by adding `@media screen` to dark-mode related styles.
Bug: T371331
Change-Id: I2ed7fbfc078c6d738c13a71c677783f7ccea2582
