Commit graph

20 commits

Author SHA1 Message Date
Volker E f2695a5bf3 hygiene: Make LESS imports non-ambigious
Some LESS parsers will get confused with the lack of file extension.
It's better to be explicit and in alignment with recent change in core
I379334d7729e587a2a00.
It was already weirdly mixed in this repo with some imports featuring
extension and some not.

Change-Id: If5065cf9e30289de9b4fd33315bd65b75959ecb7
2019-10-25 20:54:49 +00:00
Timo Tijhof 481c90798e Make extra <span> in Vector tabs optional
Applying calculation measurments to have full pixel equivalent to
`em` based properties that are necessary for user font scaling
preference ability.

Also:
* Changing watchlist icon to `em` based sizing and remodulate positioning
  by putting it on `:before` elements.
* Changing calculation of `.vectorMenu h3` to acommodate down arrow indicator.

TODO:
* Remove the extra <span> (in separate commit, to make it easier
  to rest cache compat during code review).

Bug: T236410
Change-Id: I8237976e05870378be3430e3e14c3e6993de3dc1
2019-10-24 22:42:32 -07:00
Volker E 7446c28f79 Re-order background* properties to unify across files
Orienting on https://www.mediawiki.org/wiki/Topic:Tv3wddg7n9nz8ft8

Change-Id: I4504600fcc0c54f684eddde9c66cbc6b4d419846
2019-10-01 17:14:30 -07:00
Volker E 7227e50b0a Simplify watch link selectors
Change-Id: I51b1f66900dbc4982156b5356783a69a7025ebe7
2019-09-30 14:05:31 -07:00
Volker E 1d7c3fac99 Remove unneeded selector
Has been added in 8db5779682, but there's no `span` as direct child
of the watchstar `a` (any more).

Change-Id: I989cfd0c1fe30a0b4821f79e1d9377b8d888c24b
2019-09-30 00:07:17 -07:00
Timo Tijhof 9cf7901ec9 Remove @embed page load delays (and misc optimisations)
* page-fade:
  Remove redundant 'background-image' PNG fallback for
  IE6-8 in '#mw-page-base' because the vertical-gradient() already
  creates a solid fallback color which seems good enough for IE6-8.

  Remove the 'background-color' rule which was only there to fill
  the gap above the the IE6-8 PNG image fallback, which in turn
  overrode the background-color rule from vertical-gradient.
  The background-repeat rule is also redundant with background-image
  gone.

* watch-icon-loading:
  This is only used when the JS code is active and the user
  clicks the watch star. It does not need a PNG fallback, as it
  is only needed in Grade A browsers where the JS executes,
  which are expected to support SVG.
  Also removed the embedding as the rendering of article text
  on page load should not be delayed by an icon that might
  be used if and when the user clicks on the watchstar (and
  irrelevant to logged-out users).

Bug: T121730
Change-Id: Ief4b80432fbe2ce7ebddf429f02c161048ed61d1
2019-09-27 18:03:25 +01:00
Volker E 0e089a0d4c build: Update 'stylelint-config-wikimedia' and make pass
Change-Id: I147ea18307c58c5091c5ad79585b5acec9d46235
2018-12-02 14:40:28 -08:00
Bartosz Dziewoński f010a2d8b8 Use exactly calculated value to work around a Chrome bug
Height of 3.1em calculates to 40.3px here, which is larger than the
parent element's height of 40px, apparently causing the background-image
to disappear after the rotation animation is removed.

Bug: T196610
Change-Id: I1458be6408699723977ccb589ed8d760f4ac7941
2018-06-26 21:18:34 +02:00
Volker E 0f7a56e95c Remove IE 6 specific code
Removing further CSS for Internet Explorer 6.
Follow-up to I0f98c61cf9108c0a91769e9b7044023b01f974ed.

Change-Id: I85a7570c97f9b618a7946dc20367b54e72d31b3e
2018-05-24 02:17:30 +02:00
Volker E 29c515ae3f Align VectorMenu items and unify padding with tabs
Aligning VectorMenu items horizontally with menu handle and
set `padding` consistently to `8px` – taking into account
different `font-size`.
Also removing unnecessary duplication of `margin-top` as `margin`
is set in same rule.

Bug: T179782
Change-Id: I30e9b4e50589ef09a0e5dcb0e6c4486e7779a39d
2017-11-07 20:46:33 +00:00
Bartosz Dziewoński 8db5779682 Do not use icon for "Watch" link when it is inside the "More" dropdown
Bug: T177106
Change-Id: Ia50817afe6395d8a52567599d23a232d6f07c0ce
2017-10-01 20:12:11 +02:00
Mukunda Modell e70a1d38b9 Consolidate duplicate CSS properties
I really should not have merged I30e0642d3cb93c4d9a8b2bdfb7f04912d8ca8649
without getting this fixed first.

Bug: T56919
Change-Id: I870591e63b89f05d7e3714081340c76dcf9f55ac
2017-09-22 21:06:28 +00:00
Rammanoj f74002b727 Tabs (Read / View Source / Search) collapsed under more in resolution < 700px
tabs such as read/view source are collapsed into more in screens
whose resolution is less than 700 px so that they don't wrap to
the next line and cover the content of the page

Bug: T56919
Change-Id: I30e0642d3cb93c4d9a8b2bdfb7f04912d8ca8649
2017-09-21 20:03:39 +00:00
James D. Forrester 298af67c06 build: Bump stylelint and make pass
grunt-stylelint              0.6.0  →   0.7.0
 stylelint-config-wikimedia   0.3.0  →   0.4.1

Change-Id: Id87b8df04d415e1f1058a4042a31408236402037
2017-02-17 16:34:04 -08:00
Ed Sanders f7d8d036ac build: stylelint more files
Change-Id: If62fa6ff9810de253b65feb1f7e312d22e33bfa8
2017-01-23 15:04:05 +00:00
Ori Livneh 2807232513 Use underscore hack to set IE6-only style, rather than !ie
An alternate LESS compiler library that I am evaluating
(https://github.com/oyejorge/less.php) barfs on the '!ie' syntax, but tolerates
the underscore hack.

Change-Id: Iaf5c7e0faa0323258967b2ff76e68e9080116559
2015-09-10 14:17:12 -07:00
Ori Livneh 441922e922 Add missing semicolon to import stmt
Change-Id: I8f3cc67d087fd14a8891cd2a17817b7882d72328
2015-09-10 13:58:53 -07:00
Legoktm 6cbbb23cde Revert "Replace desktop watchstar icon with mobile skin one"
Based on the discussion on T56307, this change is controversial
and not necessarily wanted. In summary:

* Green star looks out of place with blue Vector (Edokter, Esanders, Trevor)
* Clashes with WikiLove heart icon (Edokter)
* Flat design doesn't fit with Vector's gradient style (Rillke)
* Green means constructive in MediaWiki UI, however clicking the
  green star removes a page from your watchlist (Krinkle)

This reverts commit 56825d209e.

Change-Id: I46f75a0eb83f9643fc0b51befe02aad4a84efc4e
2014-12-16 18:22:27 +00:00
m4tx 56825d209e Replace desktop watchstar icon with mobile skin one
Also, replaces the old animation with the same as in the mobile skin.

Bug: T56307
Change-Id: Ida98e080dd26b0354884eee2af3269c6228e3a75
2014-12-08 23:04:22 +00:00
Bartosz Dziewoński d28f09df31 Move Vector skin from core
This is the final step of the process described at
<https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki>.

Corresponding core change: Idfc38503.

Change-Id: I84fcf7ce6385b8323544cafe6912a00f1886d20d
2014-08-07 13:38:34 +02:00