Commit graph

1287 commits

Author SHA1 Message Date
Timo Tijhof 56e566f351 Improve and simplify typehint and type docs in VectorTemplate
* renderPortals() - Takes array only, enforce this with a type hint.
* renderPortal() - Actually takes either array or string as $content,
  fix the type doc to match the code.
* renderNavigation() - Simplify by removing support for non-array
  $elements, fixing one caller.

This and other minor changes are tracked under T140664, which intends
to reduce code complexity in Vector to (potentially) make it portable
to an HTML template.

Change-Id: Idc95d023a55c83450b041109745cfbcbcd04f580
2018-01-30 15:59:35 -08:00
Timo Tijhof 57913d80b8 Clarify class commment for SkinVector and VectorTemplate
The naming the parent classes of these is quite confusing.

Specifically how "SkinTemplate" is not a skin template, rather it is a Skin
subclass that *uses* a template.

The "skin template" itself, is VectorTemplate << BaseTemplate << QuickTemplate.

Change-Id: Ie8997c5390d24cd38cdb12f97a87f8868a0b00d2
2018-01-30 15:56:42 -08:00
Translation updater bot 3a38f00d19 Localisation updates from https://translatewiki.net.
Change-Id: I7364c173fd85b7028fadeb0ed49b43a1fccc7dd8
2018-01-29 21:55:56 +01:00
Timo Tijhof c5d49d71fb Remove 'SkinVectorStyleModules' hook
Bug: T185782
Bug: T140664
Change-Id: I67950b4bed34b56d17bbea82f311bfe31683ad1e
2018-01-26 10:33:47 -08:00
Timo Tijhof a14ba2a1e7 Deprecate 'SkinVectorStyleModules' hook
Bug: T185782
Change-Id: Ie40309964797cbb5af7682d7f566fc674bc4ef12
2018-01-26 10:33:46 -08:00
Alangi Derick 1d56823f8b Update Minus-X from 0.2.1 to 0.3.0 in Vector skin
Change-Id: I7358a947ece48e1e5043dd59cef06a748f64acc8
2018-01-26 16:48:44 +01:00
Translation updater bot 5cd832fa0f Localisation updates from https://translatewiki.net.
Change-Id: I3b799158ffd1a829175159029d004145d0188e18
2018-01-25 21:57:37 +01:00
Translation updater bot a81e997a9a Localisation updates from https://translatewiki.net.
Change-Id: Ibf684931ccdd21048fb8398c3c5ece4073c9dcc0
2018-01-24 21:56:47 +01:00
Translation updater bot f5dee4ebd6 Localisation updates from https://translatewiki.net.
Change-Id: I9ac5810365b3fb5704e158b8a7387ef6ef07c453
2018-01-20 14:08:45 +01:00
Translation updater bot fcb530889d Localisation updates from https://translatewiki.net.
Change-Id: I8c5cb60b00e305fa37085f4265b4ebb39eca1fa0
2018-01-17 22:24:51 +01:00
jenkins-bot 3f9b8411d0 Merge "OOUI: Remove confusing 'position' override" 2018-01-16 21:44:33 +00:00
Bartosz Dziewoński ce97818dd2 OOUI: Remove confusing 'position' override
Vector is the only skin that does this, setting 'position: relative'
for .oo-ui-windowManager-modal (normally 'position: static') and for
.ve-ui-overlay-global (normally 'position: absolute').

The override for .oo-ui-windowManager-modal caused it to create a new
stacking context, which is the only reason the 'z-index' override
worked. Use the right selector to override 'z-index' instead.

The override for .ve-ui-overlay-global was completely pointless and
it's surprising that it never broke anything.

Change-Id: Icd1dec43e2da9ef2090b18145099838de3a7890a
2018-01-16 19:25:38 +00:00
Stephen Niedzielski 4a969cadf6 Hygiene: improve Math formula print styling comment
Add an example from the Math extension showing how the print styling
rule for font family is relevant.

Bug: T181138
Change-Id: Ib5a35b7a555c898d354c16077f44acf1e50f5ebb
2018-01-16 10:05:53 -06:00
Stephen Niedzielski 08e68d600a Fix: style printed math formulas with serif font
When printed, math formulas appear best rendered in the same font as the
body, serif. Override dl and other sans-serif styling rules for all
printed images. e.g.: https://en.wikipedia.org/wiki/Frame-dragging.

Bug: T181138
Change-Id: I9755a23cbec8388964c27d938a7aea8e25fe2f7f
2018-01-11 16:32:42 -06:00
Translation updater bot 4885722aaf Localisation updates from https://translatewiki.net.
Change-Id: I58b630b0ccceacf009f72f1498d550a7575757a3
2018-01-10 22:07:58 +01:00
Translation updater bot 11c690d94a Localisation updates from https://translatewiki.net.
Change-Id: I870d6c21c41e47fe10f9fbb925dddf5f7f524910
2018-01-09 22:03:40 +01:00
Translation updater bot c6ce92bf50 Localisation updates from https://translatewiki.net.
Change-Id: I1c4270b2c35ecabafa2c7b199260675efe5d038d
2018-01-08 22:11:02 +01:00
Bartosz Dziewoński d82e4db35e Make dropdown menus keyboard-accessible without JavaScript
Instead of implementing keyboard (and mouse click) handling in
JavaScript, put an invisible <input type="checkbox"> into the
dropdown handle. It can be focused and toggled using keyboard
actions like a normal checkbox. This checkbox also takes over
the duties of handling mouse hovering and clicking.

Old JavaScript and CSS are left in place for compatibility with
cached page HTML, to be removed later in a follow-up.

Bug: T168080
Change-Id: I27532140b06c97921f1cfb64e44bff814d99a358
2018-01-03 21:58:51 +00:00
jenkins-bot b906b83f32 Merge "OOjs UI: Fix z-index and font size for default overlay" 2018-01-02 21:58:16 +00:00
Translation updater bot facd049fba Localisation updates from https://translatewiki.net.
Change-Id: I4aa651e1acef5288f10c946ac3de99b400b28d01
2018-01-01 08:47:10 +01:00
libraryupgrader 8ae2c0c2d6 build: Updating mediawiki/mediawiki-codesniffer to 15.0.0
The following sniffs are failing and were disabled:
* Squiz.Scope.MethodScope.Missing

Change-Id: I95d20a660bc1f4f101f72ce17b49e9b640bb6f45
2017-12-30 04:04:36 +00:00
jenkins-bot 322fed3a88 Merge "Do not fail when we can't get the config" 2017-12-29 23:02:36 +00:00
jenkins-bot dc26277df4 Merge "Revert "Revert "Print styles in Vector are no longer feature flagged""" 2017-12-29 23:02:29 +00:00
Bartosz Dziewoński ead80732b9 Do not fail when we can't get the config
Config is not available when running in the context of the MediaWiki
installer.

Bug: T183640
Change-Id: Iaf3fa508fb71e93570120134f7c44001f5833f1c
2017-12-29 22:55:33 +00:00
Translation updater bot 7dda75ee09 Localisation updates from https://translatewiki.net.
Change-Id: I4d5439788fff22a1d6b441a7e37a9eaa460a1229
2017-12-28 09:08:42 +01:00
Bartosz Dziewoński 7abf395766 Revert "Revert "Print styles in Vector are no longer feature flagged""
The revert looks like it has been performed incorrectly,
and I found a much better solution to the task anyway.

This reverts commit 7d2fc6df27.

Bug: T178028
Bug: T183640
Change-Id: Ib46c69b061b522fc6365459297ad3f3d4f4d0d0d
2017-12-27 11:26:29 +00:00
Bartosz Dziewoński c573554c23 OOjs UI: Fix z-index and font size for default overlay
Override default font size for .oo-ui-defaultOverlay (0.8em) to the
same as content in Vector (0.875em).

Make it appear on top of the personal menu too.

Bug: T183069
Depends-On: I53888581f9e1da3b036166613c46cbc1085aa55e
Change-Id: I459aad271c0c15248e54e312b8bdc44ed244733b
2017-12-27 06:32:51 +01:00
Paladox 7d2fc6df27 Revert "Print styles in Vector are no longer feature flagged"
This reverts commit c863b94302.

This breaks the MediaWiki Installer ui.

Bug: T183640
Change-Id: I9f249db503c4df6ab9d87b97d9f2d1dca80744ba
2017-12-23 19:17:49 +00:00
Moriel Schottlender bf698128f2 Move the 'rcfilters overlay' rule to the RCFilters stylesheet
Depends-On: I8357ef2ff0fe4f46b9ee665ef068624de0afd2e5
Change-Id: Ie36eeddc46c8ea3d154a006fed2fe578be1cd05c
2017-12-22 10:04:15 -08:00
petarpetkovic b0f65a08df Fix detached RCFilters menu
In attempts to fix RCFilters menu overlap with other UI elements when
opening upwards, I1fe6b8b2c9 adds `z-index` rule to overlay element.
But as part of the same rule, `position: relative` is added which
cascades the absolute positioned overlay, causing it to appear in
natural flow of document, which causes menu positioning parameters
to render the menu detached from RCFilters.

Bug: T183442
Change-Id: I3f7db005730d045b2278753cfd655169a96c60a9
2017-12-22 14:07:22 +01:00
jenkins-bot 7c1caddf8f Merge "Inline lists in new print styles should not have a smaller font size than surrounding content" 2017-12-21 02:20:47 +00:00
Rafid Aslam 43b1ed9e18 Add minus-x to "composer test"
Add minus-x to "composer test" and "composer fix"

Bug: T175794
Change-Id: I0a8b67e15f691aa1dad78d28e220cf9d5bcd8b0f
2017-12-20 21:46:11 +07:00
Yifei He 5847c798dd Inline lists in new print styles should not have a smaller font size than surrounding content
Bug: T178667
Change-Id: I2a9bc621db5a09cb5a5653488e0f9dd6c236a773
2017-12-20 02:43:18 +00:00
Translation updater bot e13d71bef3 Localisation updates from https://translatewiki.net.
Change-Id: I205d931db4acc253df813112d7cd0c4367f93e0b
2017-12-18 22:23:18 +01:00
Bartosz Dziewoński d4eabd9d10 Fix z-index for RCFilters' overlay
Currently the personal bar displays on top of it. This wasn't
visible until some popups started opening upwards rather than
downwards. We should fix this better some time...

Bug: T182711
Change-Id: I1fe6b8b2c9c1e4d12a9a4d2d1edd1ead269780cf
2017-12-12 23:53:09 +01:00
Translation updater bot bfdd168413 Localisation updates from https://translatewiki.net.
Change-Id: I1a5cd5feb9421a0f87ee9794c06e226a51f3a60b
2017-12-12 22:25:25 +01:00
jenkins-bot 5268f8edb9 Merge "Fix incorrect indentation of TOC on print preview" 2017-12-12 13:41:23 +00:00
Albert221 4ee212adc4 Fix incorrect indentation of TOC on print preview
Also add the white space that was taken by hiding
.tocnubmer to .toctext

Bug: T179363
Change-Id: I06c502f3d4bee687ed7f300246687aff978ed1d6
2017-12-11 22:26:24 +01:00
Translation updater bot a9bcea2971 Localisation updates from https://translatewiki.net.
Change-Id: I51bb0f8f98c6e4099e08fd009e3e06c8c91bd813
2017-12-10 22:07:12 +01:00
Umherirrender 1c0725da94 Rename file Hooks.php to match class
Change-Id: I59058d580d6b4ced5b7744c46baf074042467df7
2017-12-09 21:32:56 +01:00
Translation updater bot c08bd1fb7a Localisation updates from https://translatewiki.net.
Change-Id: I6226d2ded99db569aa9a9e27ee310966460c54c1
2017-12-05 08:51:48 +01:00
Translation updater bot 6d5f9c0cb1 Localisation updates from https://translatewiki.net.
Change-Id: I94d5d8c0ac604c94afd266961163d344188e908f
2017-11-30 22:47:06 +01:00
Thiemo Mättig d46cb97aeb Fix dysfunctional collapseCondition when right-most tab is the star
The issue I'm fixing here is described at
https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Hard_to_read_titles

The code I'm touching here is from 2014. I believe the issue is not new, but
pops up extremely rarely. Multiple conditions must met:
1. The user must use an extreme zoom (or an extreme font size), or a
   super-narrow browser window. This is also how you should reproduce
   this: make your browser window very narrow, and then start zooming in
   extremely.
2. The issue only appears in namespaces where you can not move pages! This
   is the case for the vast majority of pages on Wikidata and the reason why
   it appears to be a Wikidata-only issue (which it is not). If you can move
   a page, the right-most button is "Move", which is wide enough to be worth
   collapsing, or is already collapsed.

If the right-most (":last") button is the watch star, the code believes it is
not worth collapsing it because the "More" button would consume more space.
This is true, but does not consider the other buttons that can also be
collapsed.

My code considers all collapsible buttons.

Change-Id: I6e94750b3b80940005f4d655e5e9b426d44b2ffb
2017-11-30 18:53:02 +00:00
Translation updater bot 2c29439b30 Localisation updates from https://translatewiki.net.
Change-Id: Ib0720214c9f0104be4ecc5ddb3d107b6b5432424
2017-11-29 22:10:47 +01:00
Ed Sanders e3effd4201 mw.notify: Remove rules duplicated from core
Change-Id: Ibaebea290b2a912fdc9914cfc12d7916a0fe1d18
Depends-On: I157e41631c4a09842b869215b0d6dbb99c1a4d36
2017-11-29 16:01:50 +00:00
Translation updater bot 0db35388d0 Localisation updates from https://translatewiki.net.
Change-Id: I8f737c6a9b2481abb580ed30cbee9480d125c4a0
2017-11-28 22:01:44 +01:00
Translation updater bot e0b37470bb Localisation updates from https://translatewiki.net.
Change-Id: I46cc4784e66cc32bb5bd6b806633433741626e2c
2017-11-27 22:11:40 +01:00
Translation updater bot 4ff9644a70 Localisation updates from https://translatewiki.net.
Change-Id: Ia50ea41772522fcd9111119816a11e177a2b2d79
2017-11-25 22:08:16 +01:00
Translation updater bot af5d639ec1 Localisation updates from https://translatewiki.net.
Change-Id: Ia854c733234d211858dd6e59e364cd8578b1a4ea
2017-11-24 22:30:07 +01:00
Translation updater bot 3283181def Localisation updates from https://translatewiki.net.
Change-Id: I7db354fdc6a2e65b7ba0ac0443867c6927f5c64c
2017-11-23 22:36:11 +01:00