Commit graph

5095 commits

Author SHA1 Message Date
bwang 2f29620a31 Disable headless puppeteer for a11y testing
Change-Id: I50c2d9f978e33b0757b9d520bebce606ae7127ca
2023-01-24 16:55:35 -06:00
Jon Robson 93c833030b Make sticky header edit the default
In production this is always true, so remove feature flag.
Retain A/B testing code in case it is still needed.

Bug: T324799
Change-Id: Ia2057eb69d0a8d3e6e51acb5729a4399fb17a18b
2023-01-24 19:48:48 +00:00
bwang 05c6f9ecd4 Define grid template row for .mw-body grid container to ensure the grid cell containing the content will expand in height when needed
Bug: T327714
Change-Id: I8f2f9e8a0f6009be5ffa7f9319172169df253180
2023-01-24 11:22:22 -06:00
jenkins-bot 2843a7ebd9 Merge "Add temporary extra grid-area for content translation extension" 2023-01-24 15:55:59 +00:00
Jan Drewniak f93dbd3c79 Add temporary extra grid-area for content translation extension
Adds an extra grid area for content translation
so that it doesn't interfere with the page header
on user contribution pages.

Bug: T327715
Change-Id: I68d2c9dbe50dcdfe1924f29a96b48ab07bcc5f10
2023-01-24 07:38:45 -08:00
jenkins-bot 07faf76311 Merge "Fix grid blowout with limited width turned off" 2023-01-24 14:16:18 +00:00
Translation updater bot be92006bdc Localisation updates from https://translatewiki.net.
Change-Id: I3148ad02cae7060385a54eac2320d291ddb00ff2
2023-01-24 08:51:58 +01:00
jenkins-bot a8eaee8d1d Merge "Work around sticky-positioned layers disabling subpixel rendering" 2023-01-23 21:37:33 +00:00
Bartosz Dziewoński 1d45abb015 Work around sticky-positioned layers disabling subpixel rendering
Adding 'contain: paint' to the TOC container works around the issue.
This property is intended to prevent element's rendering from
affecting other elements, so it makes sense that this works.
https://developer.mozilla.org/en-US/docs/Web/CSS/contain

Because this property also clips the rendering of the element to its
bounding box (similar to 'overflow: hidden'), we need to move some
negative margins to this element from its children, otherwise the TOC
expand/collapse arrows would be cut off.

Bug: T327460
Change-Id: I34f414a99608450882e83c0ff22e64c05dff8807
2023-01-23 21:51:40 +01:00
jenkins-bot 1ebe553429 Merge "Change limited-width toggle to appear at 1400px" 2023-01-23 18:29:01 +00:00
jenkins-bot f25eccaac7 Merge "DI: Make pinnable elements work on Safari 13 and earlier" 2023-01-23 18:12:42 +00:00
Jan Drewniak 40d1a89b42 Change limited-width toggle to appear at 1400px
Bug: T326887
Change-Id: I256866f615c8c0f10b29e6135faca6add16ff195
2023-01-23 17:59:13 +00:00
jenkins-bot 9650eae741 Merge "Remove code to disable new search on Wikidata" 2023-01-23 14:25:22 +00:00
jenkins-bot 1946a88e63 Merge "Fix font-size adjustments for narrow width" 2023-01-23 09:45:37 +00:00
Sam Wilson 2f761f3a19 Fix font-size adjustments for narrow width
Also change alignment of preview box to the left, to match
reading mode.

Bug: T322385
Bug: T322738
Bug: T323751
Change-Id: Iaee930d9ddc0c4539aad417a80a7c95d590e8099
2023-01-23 09:21:19 +00:00
Derk-Jan Hartman ff830f201e DI: Make pinnable elements work on Safari 13 and earlier
The pinnable element would cause exceptions on older versions of
Safari during the setup and the ToC menu would show instead of being
pinned and hidden.

Bug: T327602
Change-Id: I99b656d0070d3e9af5641274134736b742c28f58
2023-01-23 09:17:16 +00:00
Translation updater bot 84f8bb15a5 Localisation updates from https://translatewiki.net.
Change-Id: I8a6799457b7d4f03451bdaad97910ebaab1f4950
2023-01-23 08:26:46 +01:00
Translation updater bot 2a65dc2bba Localisation updates from https://translatewiki.net.
Change-Id: Icc0c6e4251dfc492112a0e6b844bc7f525347a96
2023-01-20 08:45:29 +01:00
bwang e703774b6d Update puppeteer actions for page tools
Change-Id: I11a6b779ed9c72c5aa4aaa226c0e7e855dcba437
2023-01-19 22:52:40 +00:00
jenkins-bot 1d1c4e8e2b Merge "Update displaying DiscussionTools TOC additions after parser changes" 2023-01-19 21:37:07 +00:00
jenkins-bot 01529272cc Merge "Personal tools accessibility label should not be "Foo"" 2023-01-19 17:15:06 +00:00
bwang 68c52a1efa Fix grid blowout with limited width turned off
Bug: T327423
Change-Id: I64f33c88e8fb9f8db87befa393a48c4eaf0a8136
2023-01-19 17:10:45 +00:00
Jon Robson 7b306db912 Personal tools accessibility label should not be "Foo"
Change-Id: I49eaae240c7df5f93570d4270bcd1c25403d8eb3
2023-01-19 08:37:41 -08:00
Translation updater bot 3aa1056709 Localisation updates from https://translatewiki.net.
Change-Id: I9ee02f4b68aa85e83554fd43d3ad2625b767cbbd
2023-01-19 11:34:59 +01:00
Jon Robson 155bb9a4da Legacy Vector is not a responsive skin
For some reason we are setting this to true when it's not
supposed to be. The recent refactor to complete the splitting of
two skins removed the override inside SkinVectorLegacy

Follow up to eea537394

Bug: T327256
Change-Id: Ie75a506866f4bd099efb26e8043fdcd37803a2da
2023-01-18 17:48:45 +00:00
jenkins-bot ed404895c1 Merge "Use tabs consistently in .mustache files" 2023-01-18 15:03:17 +00:00
Translation updater bot 51157399c8 Localisation updates from https://translatewiki.net.
Change-Id: I11b68ace39cbc17c8091264dbcb5568305a29570
2023-01-18 08:32:33 +01:00
Ed Sanders 7323d6af4e Use tabs consistently in .mustache files
Change-Id: I3874b8a03f8a512a4d31f4c85a030de63cbc3c69
2023-01-17 11:48:34 +00:00
Translation updater bot 26d4db3bf1 Localisation updates from https://translatewiki.net.
Change-Id: Ia652d24e54332c49bd31cd30a06cf732a1bfcf3a
2023-01-17 08:09:34 +01:00
bwang 128a01bd35 [Clean up] Remove CSS and HTML from cached TOC html
Follow-up: I5b9228380f5c4674ef424d33127a5cb4010822da
Change-Id: I2a1167278c5ece9c0540cff9b5c06fcf185bc64d
2023-01-16 17:21:12 -06:00
bwang 0032b7b970 Remove VectorComponentTableOfContentsContainer in favor of directly using VectorComponentPinnableContainer,
- Remove all TOC components from markup when TOC isnt available
- Ensure TOC components have a consistent naming convention

Follow-up: Icd871e1bdf4ab0c7aa5b906b913416f4b1747750
Change-Id: I63519b5e5392b9eb546876e7eea060b9a6c147dc
2023-01-16 17:20:03 -06:00
Bartosz Dziewoński d2e34ce079 Update displaying DiscussionTools TOC additions after parser changes
Depends-On: Id59b946f4a3618a75dfaaef8a0043423b768b21c
Bug: T326677
Change-Id: I0f49c9c92d30fbfeefb547ba13312f740d7f5b2d
2023-01-16 19:07:17 +00:00
Moh'd Khier Abualruz 96ff431213 Table of contents Collapse/Expand not working
Bug: T327064
Change-Id: Ica3b43d51169d33b01d7203c3672c301e775ec04
2023-01-16 18:06:30 +01:00
Moh'd Khier Abualruz 29a2254b9a Update tableOfContents.js to rerender only the TOC contents rather than the entire pinnable element
Extra:
- Reactivated active list element, This still does not work if the current active gets edited.
- Removed pinning event reattach as we do not replace teh full element anymore.

Known Issues:
 - Collapse/Expand not working

Bug: T326839
Change-Id: I2ce251f5312659b827ac2941d789248473bb0ef5
2023-01-16 12:39:05 +01:00
Translation updater bot 17953d9012 Localisation updates from https://translatewiki.net.
Change-Id: I6999fbc93dbc5bf697018dcdde823fb1ff80b114
2023-01-16 08:31:40 +01:00
jenkins-bot eb78a83856 Merge "Scale server-rendered search box with browser font size" 2023-01-13 23:04:25 +00:00
Jan Drewniak 0daa4da3c4 Followup to 4d1c0b89 Override PinnableElement behaviour at low resolutions.
The media query for the CSS portion of this feature
should not include the `screen` portion because
that's included in the top-level import in skin.less.

Bug: T326364
Change-Id: I1ab0e321dde908982834c92ee428b512218bbe3d
2023-01-13 17:18:20 -05:00
jenkins-bot 13cc033ab0 Merge "Remove extra border that show in a page tools dropdown when a menu is hidden" 2023-01-13 21:52:48 +00:00
Nicholas Ray 2b397d05d2 Scale server-rendered search box with browser font size
The server-rendered input's height was using pixels instead of relative units so
it did not scale with the browser's font size. This adjusts the styles of the
server-rendered input to match the styles used by Codex. In addition, the
magnifying glass dimensions were set to pixels to match the Codex icon.

Bug: T326863
Change-Id: I6aa5b60841087dfa5b32e873e3ed21a22c37353e
2023-01-13 14:36:02 -07:00
jenkins-bot 70ddd1f3f7 Merge "[Clean up] Remove unnecessary container and CSS in sticky header" 2023-01-13 20:57:24 +00:00
bwang 4bf1a7b6f6 Remove extra border that show in a page tools dropdown when a menu is hidden
Fixes this https://phabricator.wikimedia.org/F36201839, which you can see for anon users, who have an empty "Actions" menu inside the page tools dropdown

Follow-up: Ia2cba7eb60739f0af8153c6c4246aa80d2a189c0
Change-Id: I617b37fbdb7b300a4266fd9f927d81e6a63d74bc
2023-01-13 20:41:34 +00:00
jenkins-bot ac87bd6c1b Merge "Convert @width-column-start-desktop and @width-column-start-desktop-wide to relative units" 2023-01-13 20:29:09 +00:00
bwang 787b065f99 [Clean up] Remove unnecessary container and CSS in sticky header
Change-Id: I7a1f75e8997ea6c87955f72c971f6d1d08e6ab22
2023-01-13 20:11:21 +00:00
jenkins-bot 5f53d90e59 Merge "Override PinnableElement behaviour at low resolutions." 2023-01-13 19:52:28 +00:00
Nicholas Ray 112cd9a085 Convert @width-column-start-desktop and @width-column-start-desktop-wide to relative units
The search box was overlapping the logo when increasing the browser's default
font size as a result of the logo's width using relative units and the column
using pixels [1]. This converts the column to use relative units so that it can
scale with the logo's width and not overlap.

[1] https://phabricator.wikimedia.org/F36201423

Bug: T326863
Change-Id: I08b54908f0f2b81ac4b8f506d4bfaea14350f399
2023-01-13 12:20:49 -07:00
jenkins-bot 21996f5bc5 Merge "Table of contents elements should not be rendered where none available" 2023-01-13 18:15:31 +00:00
Jan Drewniak 4d1c0b8940 Override PinnableElement behaviour at low resolutions.
At resolutions below 1000px, we want pinned elements
such as the Page Tools menu and Main Menu to collapse.
This behaviour is temporary and when the browser is resized,
the pinned elements should revert to their previous pinned state.

We also want to remove the ability to pin these menus at
low resolutions, so the "hide/move" button is hidden.

A new matchMedia event handler is added to PinnableElement.js
to handle this behaviour.

CSS is also added to hide the pinned menus at low resolution.
This is to account for the situation where the page is loaded
at narrow widths, with pinned elements,
and the JS hasn't loaded yet.

features.js is refactors so that class toggling can happen
independently of saving the state to user preferences
(since we want to toggle the classes but not save the state
at lower resolutions).

Bug: T326364
Change-Id: I3113ab83deb15843e04ed63ec767a85c522517b5
2023-01-13 18:09:11 +00:00
jenkins-bot 5dba63205c Merge "LanguageDropdown: Check if the page is in talk namespaces instead" 2023-01-13 12:12:50 +00:00
Translation updater bot 9333bfb5e0 Localisation updates from https://translatewiki.net.
Change-Id: Ie2ee0301145e5cc621e678537977ee29cdbb7da3
2023-01-13 08:58:34 +01:00
Func a874eb1096 LanguageDropdown: Check if the page is in talk namespaces instead
$wgContentNamespaces is default to only contain the main namespace,
we should check whether the page is a talk page instead.

Also use the term "subject page" to align with existing functions
of Title and NamespaceInfo.

Bug: T316559
Bug: T326788
Change-Id: I873283195d5c503818b2056c87c25ecc77d2915a
2023-01-13 14:44:49 +08:00