Commit graph

3432 commits

Author SHA1 Message Date
Jon Robson 393928a280 Fix table of contents when sidebar is open
Bug: T309807
Change-Id: If370246d13984981f4c3477fda2b2dce45337d91
2022-06-27 15:01:18 -07:00
jenkins-bot a47f46009e Merge "Attach VE to #content while title-above-tabs feature is disabled." 2022-06-27 20:15:35 +00:00
Jan Drewniak 05a1c330fe Attach VE to #content while title-above-tabs feature is disabled.
Limits the usage of the `data-mw-ve-target-container` attribute,
which changes the position of VE, to be enabled only when the
title-above-tabs feature is enabled.

Bug: T310197
Change-Id: I846135a88acf713bed608ad4f147f7602ce7cc2b
2022-06-27 15:44:19 -04:00
Jon Robson 6efcf775c0 Technical: Use unambigious menu template
Follow up to 49c8b5f514
Our PHP parser resolves >Menu to the parent directory which
differs from the frontend Mustache library.

Best to have different names for these files to avoid this problem.

Bug: T311319
Change-Id: Iea708718a0b928c4902dc7bac0c5ee304b89f961
2022-06-27 12:29:03 -07:00
jenkins-bot a34b564192 Merge "Layout: Don't hide footer < 1000px when sidebar closed" 2022-06-27 15:26:21 +00:00
Translation updater bot ed0fd37d03 Localisation updates from https://translatewiki.net.
Change-Id: Ie5b4b4c82db8f8537f285b4694ea55bf8a4f94c4
2022-06-27 08:20:27 +02:00
Jon Robson 5beadc4bc2 Layout: Don't hide footer < 1000px when sidebar closed
The 'mw-workspace-container' class is present on both
the footer and the sidebar. The CSS rule should only hide
the latter.

When there is no table of contents on the page, and the sidebar
is closed, the content
should always span the grid columns and the sidebar container
closed.

Bug: T293443
Change-Id: I852b9024fbd21339b7c78dbb4deba811ab17c7e7
2022-06-25 00:03:41 +00:00
bwang 61e723c541 TOC: Ensure TOC spacing is correct when grid is enabled
Fix usage of CSS calc

Change-Id: I6dcf3751a4b478a14d8052a70720e138238203d3
2022-06-24 23:09:50 +00:00
jenkins-bot 0a00ad5b40 Merge "Revise margin collapsing rules with new layout" 2022-06-24 16:25:54 +00:00
Jon Robson ec6b6ebd9a Revise margin collapsing rules with new layout
Follow up to 97783e5

Bug: T311283
Change-Id: Ia0581713fd182b9236e398a2453efd06ce8b9f1f
2022-06-24 15:55:08 +00:00
Translation updater bot 09142a87c1 Localisation updates from https://translatewiki.net.
Change-Id: I9e478b74074ef6c03a868fc1ab507d9066f7545f
2022-06-24 09:34:31 +02:00
Jan Drewniak 6e96a8e936 Rename data-ve-target-container attribute to data-mw-ve-target-container
Updates the data attribute for placing VE on the pages.

Bug: T310197
Depends-On: Ia6f87535f11ccc7aadb26b7dd9e1ac8a867c377c
Change-Id: I081d5e23a15902e1429e68ac4ae191e498e6aba6
2022-06-23 10:53:44 -04:00
Translation updater bot 770da51809 Localisation updates from https://translatewiki.net.
Change-Id: I579271f25d92dafdce7bf179a78247c05ccd17f9
2022-06-23 09:15:36 +02:00
Jan Drewniak 97783e5bd8 Use the data-ve-target-container attribute to position VE
Uses the data attribute `data-ve-target-container` to determine where
on the page to insert VisualEditor. Also moves the #siteSub back into
the #bodyContent container. This makes the SiteSub match the font-size
it had in legacy Vector & positions the VE toolbar between the tabs
and the tagline.

Bug: T310197
Bug: T310839
Depends-On: Idae6755c90eacaab1a9daa88c6e28850d427810c
Change-Id: Idb2a743c93316786d6d36e1989cf6620a6092281
2022-06-23 00:39:19 +00:00
Jon Robson 49c8b5f514 [Fix] Adjustment to legacy menu templates
Follow up to c5cfd4d

1) Partial paths are incorrect
These are not a problem with our current Mustache template
parser but could break with any changes in our PHP implementation

2) Add dedicated class to legacy menus

On the longer term this will allow us to further separate the
old and new CSS.

Change-Id: I056b033855c28f919a4af99784620503f10b9dcb
2022-06-22 22:42:39 +00:00
jenkins-bot bf117d1fc8 Merge "Restore sticky header class and update TOC styles" 2022-06-22 20:34:07 +00:00
Clare Ming 75cc9bdcd9 Restore sticky header class and update TOC styles
Bug: T311170
Change-Id: Ib12b6f79a20b2a25b49110e5a7de59d199917dc9
2022-06-22 14:46:07 -05:00
Jon Robson 25c3fc1863 Table of contents: Cached HTML is no longer a problem
Bug: T307900
Change-Id: Ic03bc15b8a15d6d095130c8346c399a2ac93d955
2022-06-22 18:17:52 +00:00
Jon Robson e1942cec4e Fix sticky header edit icons during A/B test init
- Add test case for T310750

Bug: T310750
Change-Id: Ie52a7227f337dd6cdb0ab441986aa2be6139f949
2022-06-22 09:38:19 -06:00
Translation updater bot ed5de2cd99 Localisation updates from https://translatewiki.net.
Change-Id: I71deecf87866093852bf0042bfd4c204a39f2ede
2022-06-22 08:15:30 +02:00
bwang f473129485 Add support for floating TOC lower down the page
This patch only handles the first case listed in the task description

Bug: T308689
Change-Id: I4e7dbded7a8206633a98653aaf4ced3fd2b6f69d
2022-06-21 16:02:11 +00:00
Translation updater bot 8a9eebad06 Localisation updates from https://translatewiki.net.
Change-Id: I4b69874e18663515ecfd07d571c86b139cbefbbe
2022-06-21 08:34:18 +02:00
Translation updater bot 5db783c04c Localisation updates from https://translatewiki.net.
Change-Id: I17b6c78abc6642dc7e45104a547ff878414a1837
2022-06-20 08:20:10 +02:00
jenkins-bot 42127622dc Merge "Show scrollbars in sticky TOC" 2022-06-17 15:57:37 +00:00
bwang f8c910ed09 Update a11y config to hide central notice
Change-Id: Iabc635d909724c0a59c1dba73ed59c33df1b44ec
2022-06-17 10:33:47 -05:00
jenkins-bot 86f81f968b Merge "Cached CSS is no longer a problem" 2022-06-16 18:21:46 +00:00
jenkins-bot 0fff66b638 Merge "Add a URL parameter to edit links in the sticky header" 2022-06-16 18:00:37 +00:00
Jon Robson 64ee3686b8 Cached CSS is no longer a problem
The !important is retained for cached HTML and will be retained
for another release cycle

Cached HTML will continue to be a problem until next deploy. The CSS
cleanup will thus be fixed in a follow up
(I47b7a0bc9c5dad5451f1dbb5e32e513643a1534b)

Bug: T307900
Change-Id: I47b7a0bc9c5dad5451f1dbb5e32e513643a1534b
2022-06-16 17:48:29 +00:00
Clare Ming b6e76eb797 Show scrollbars in sticky TOC
Bug: T310540
Change-Id: I36af416901f9fde268f59a3e3fd690b743748514
2022-06-16 10:19:04 -06:00
Translation updater bot 27e81c5e4d Localisation updates from https://translatewiki.net.
Change-Id: I52e774c46460550df4fe031d8ddbd229bc148e39
2022-06-16 09:27:11 +02:00
David Lynch 734902811a Add a URL parameter to edit links in the sticky header
Briefly add it onto the originals when the click is being proxied so
that VE can pick up on it.

Bug: T309364
Change-Id: I871494b6e783018b1433f294e09b0d53dded6c3d
2022-06-15 18:20:59 -05:00
Clare Ming 536e53af7a Minor adjustments to collapsible TOC
Bug: T307900
Change-Id: Iec0c5c6e3dbede85e549fc9558b9d5c7be4fa10d
2022-06-15 09:56:27 -05:00
Translation updater bot 0b2c4b7faa Localisation updates from https://translatewiki.net.
Change-Id: I1e1af93ec72a2726917acf1bea507b9f1ade9a79
2022-06-15 08:43:54 +02:00
jenkins-bot def2a366bc Merge "[Regression] Revert border color of page title." 2022-06-14 22:20:23 +00:00
jenkins-bot 27a23465da Merge "Fix sticky header searchbox width and misc searchbox CSS cleanup" 2022-06-14 22:01:52 +00:00
bwang b6e7b5e880 Fix sticky header searchbox width and misc searchbox CSS cleanup
Bug: T310366
Change-Id: Id403f818b19747e3279df3112d93301f31323f9d
2022-06-14 15:58:53 -05:00
jenkins-bot 0f0dfd532e Merge "Match default config of TOC to pilot wikis" 2022-06-14 17:23:54 +00:00
jenkins-bot 8d41918b6d Merge "Update checkbox.js comments" 2022-06-14 16:49:56 +00:00
Translation updater bot a9e1920cb3 Localisation updates from https://translatewiki.net.
Change-Id: Ifb00c90d693d0d604480add66f30c18df1315d41
2022-06-14 08:51:38 +02:00
Jan Drewniak 011a7b273b [Regression] Revert border color of page title.
Reverts the border color of the page title introduced in
I5d807f09bfbbceaded756daa78dbb023efcc91dc

Bug: T310533
Change-Id: I877f91bcd4c0915cc495b5237a53bda6ad971497
2022-06-13 14:38:09 -04:00
Clare Ming 6a0907a70b Match default config of TOC to pilot wikis
Bug: T309683
Change-Id: I7f1e727fbf06655daf2b6a359580fc6bf10ca1b9
2022-06-13 10:44:22 -06:00
bwang 61c571ffb5 Update checkbox.js comments
Change-Id: I44d2087fefb28adf20c7ff938cff411cb0678a7e
2022-06-13 11:32:34 -05:00
jenkins-bot d529efeaf8 Merge "Follow-up: Update menu label elements" 2022-06-13 14:37:25 +00:00
Translation updater bot f607dad3bc Localisation updates from https://translatewiki.net.
Change-Id: Ib529f9bef80e6bea9f421e16a20173a17a7c91f8
2022-06-13 08:31:19 +02:00
Jon Robson 5fdd66fa3b Disable table of contents toggle on VE activation
While the table of contents is not updated by VisualEditor
we should hide it.

Bug: T307900
Change-Id: I246fbe0069329ef78735147b8d3f280433155158
2022-06-10 15:39:21 -07:00
bwang 93e8cfcd90 Collapse ToC into page title at narrow view ports with CSS/template changes only
Bug: T307900
Change-Id: I72607ec9d8b46401468de5815cf47dac9f4612a5
2022-06-10 15:49:06 -06:00
jenkins-bot 98cffb3f19 Merge "[Refactor] Generalize checkbox hack code" 2022-06-10 21:39:05 +00:00
jenkins-bot 677684d839 Merge "[Refactor] Separate sidebar persistence code from checkbox hack code" 2022-06-10 21:37:49 +00:00
Jon Robson 10810ec1da [Refactor] Generalize checkbox hack code
Allow it to apply to any appropriately marked up checkbox hack
element.

Change-Id: Ic3770877ee8e92574900715413a51acc964741be
2022-06-10 13:56:56 -07:00
Jon Robson de0729e604 [Refactor] Separate sidebar persistence code from checkbox hack code
Change-Id: I5d7d8897f656419a71b1327c37e88c9dd7f0767c
2022-06-10 13:55:22 -07:00