Commit graph

4173 commits

Author SHA1 Message Date
Jon Robson 8ec5a51625 [Technical] Move isSidebarVisible and template boolean to SkinVector22
Additional change: Prefix with "is-" per template coding standards

Bug: T319349
Change-Id: Iadf149439d043d00a79094c4f34dfbea92abffe1
2022-10-27 18:45:47 +00:00
Jon Robson 9c9c49d90f Remove duplicate styles
Follow up to
I51f8e31be6771a3fb32fb07dc22d0c2872b5706d

Bug: T321504
Change-Id: Ia3fe858f29836039fd7d621588715badf3298643
2022-10-27 10:34:15 -07:00
jenkins-bot 5112811e47 Merge "Use standard utility classes for flushing icons left and right" 2022-10-27 15:03:34 +00:00
Translation updater bot fa97772903 Localisation updates from https://translatewiki.net.
Change-Id: Ifc27bd6eef6dd8cdfb291299186050100c0ee193
2022-10-27 08:58:22 +02:00
jenkins-bot 702e585154 Merge "Limit user dropdown link to 48px" 2022-10-26 21:23:59 +00:00
Jon Robson a1199a0917 Use standard utility classes for flushing icons left and right
Restricted to the feature flag (?vectorvisualenhancementnext=1)
 for now to allow us to not worry about caching.

mw-ui-icon-flush-left and mw-ui-icon-flush-right have been in core
for some time and using them means we don't have to manage hardcoded
values for these.

We'll need to think of .mixin-vector-flush-left-left
and .mixin-vector-flush-right-margin-left separately - I wonder
if these could be revised to use these 2 standard classes.

Additional changes:
- Drop unused mixin-vector-flush-right-margin-left mixin

Bug: T321504
Bug: T317583
Change-Id: I51f8e31be6771a3fb32fb07dc22d0c2872b5706d
2022-10-26 10:01:12 -07:00
James D. Forrester 41a106cded build: Upgrade Codex from 0.1.0-alpha.10 to 0.2.2
Change-Id: I213c04ffc5f7c8ebe0f3973703f285380a17c98a
2022-10-26 10:47:51 -04:00
Translation updater bot 12d8d3d5f6 Localisation updates from https://translatewiki.net.
Change-Id: I213c04ffc5f7c8ebe0f3973703f285380a17c989
2022-10-26 08:22:17 +02:00
jenkins-bot 598424b2e2 Merge "Replace incorrectly mw- prefixed classes Rename template and CSS files to match updated naming conventions, replaces instances of "sidebar" with "main menu"" 2022-10-25 22:32:06 +00:00
bwang 2102ac5131 Rename Article Tools feature flag to Page Tools
Change-Id: Iec8e790d0a49d7bb8bbdaa3caee7aae72eed0868
2022-10-25 16:53:43 -05:00
Nicholas Ray 6d62d71ee5 Remove login link quick fix styles
This removes the previously merged 835281 stopgap. Because of caching, this
should only be merged when the `emptyPortlet` class is not found on the user
menu container on anon officewiki.

Bug: I883926c36f59d446076f960ead31f82e51967e70
Change-Id: Ia1e9ba2b43186462b05f372368d5965fa0857657
2022-10-25 16:17:24 +00:00
bwang 51457a78e7 Replace incorrectly mw- prefixed classes
Rename template and CSS files to match updated naming conventions, replaces instances of "sidebar" with "main menu"

Bug: T316570
Bug: T317437
Change-Id: Ib4050768f20b1734d356104f18aa539f657099d8
2022-10-25 10:28:31 -05:00
Lucas Werkmeister a01f839051 search: Make wprov value match non-Vue behavior
The legacy search wprov behavior, implemented in the WikimediaEvents
extension in searchSatisfaction.js, is to use acrw1_ as the prefix (i.e.
with an underscore before the index), and acrw1_-1 for user searches
that didn’t select a suggestion (not acrw1). Make the Vue search match
this in both cases.

Bug: T317682
Change-Id: I6c84533e1811233ff2727d501327471d73fc7b62
2022-10-25 10:38:44 +00:00
Translation updater bot 9ec1928539 Localisation updates from https://translatewiki.net.
Change-Id: I18ee480528661ae4ef2af3cd1255c6954b959f30
2022-10-25 08:26:33 +02:00
Jon Robson f94e386f85 Limit user dropdown link to 48px
Bug: T319070
Change-Id: I483e728870c059a1945d3dc4f395f04250b29cc7
2022-10-25 00:29:39 +00:00
Jon Robson 614da1dc5e Features: Make max width a feature
Making this a feature part of the feature management system is integral
to making this a toggle and will allow us to explore making this
persistent in future.

Bug: T319447
Bug: T319449
Change-Id: I80c7b892a6891094854b4154db90917b67986102
2022-10-24 13:12:06 -07:00
jenkins-bot 5da5190a9d Merge "search: Add wprov to result URLs" 2022-10-24 17:40:59 +00:00
Moh'd Khier Abualruz 6487f962f2 i18n: Remove unnecessary comma in preference description
Follow-Up-To: I3525f8bfe27445e3af83ce5cd34b4da643178fe2

Bug: T321038
Change-Id: Ide81563fdae96d5d8dcb76d18282764349a81352
2022-10-24 15:28:41 +00:00
Translation updater bot baafad28cc Localisation updates from https://translatewiki.net.
Change-Id: I824724175a497552790994190b5dcb3ae2cfe6e2
2022-10-24 08:26:00 +02:00
jenkins-bot 2164b6ef95 Merge "Use WebRequest directly in Hooks::shouldDisableMaxWidth" 2022-10-21 23:19:21 +00:00
Umherirrender 3ad2d58ac8 Use WebRequest directly in Hooks::shouldDisableMaxWidth
To avoid array query values to be used, see warning there:
"Array values are discarded for security reasons. Use {@see getArray} or
{@see getIntArray}."

This also fix that the falsy value "0" is checked against the regex

Bug: T321267
Change-Id: I29bc4a9a7fef5a6cadc0c6aa9fa1f4a03ccf9705
2022-10-21 20:21:40 +02:00
jenkins-bot a7abe4d201 Merge "Fix Vector 22 missing user menu on private wikis" 2022-10-21 17:54:56 +00:00
jenkins-bot 099e0278b9 Merge "Add vector-tab-noicon class to tabbed menus when menu items are added by gadgets" 2022-10-21 16:04:13 +00:00
Lucas Werkmeister d34fae74f1 search: Add wprov to result URLs
This ensures that the wprov parameter is included when users follow the
link as a link (click, middle-click, etc.), and also prepares us for a
future where pressing Enter after selecting a search result navigates to
that result’s URL instead of submitting the form. It also matches the
behavior of the legacy search form.

We put this in App.vue + instrumentation.js, not in urlGenerator.js,
because we also want wprov to be added when custom URL generators or
search clients are used. (The reason for instrumentation.js instead of
purely App.vue is just that it’s easier to test there.)

In the tests, we need to update @wikimedia/mw-node-qunit so that we have
a sufficiently functional mw.Uri() mock.

Bug: T317682
Change-Id: I765d3bbf89b2253add7b50305c362e4bbc9ecceb
2022-10-21 11:58:30 +02:00
Translation updater bot 78bccaf46e Localisation updates from https://translatewiki.net.
Change-Id: Ic142515b5638a139d7378292c14bba633877169c
2022-10-21 08:47:47 +02:00
Nicholas Ray 97147857b2 Add vector-tab-noicon class to tabbed menus when menu items are added by gadgets
* Removes server rendered vector-tab-noicon class from legacy Vector as it is
not currently used.

* Adds menuTabs.js responsible for adding the vector-tab-noicon class when menu
items are added to tabbed menus. This is only used in vector-22.

* Adds unit test

Bug: T320691
Change-Id: Iffad86125f8754305f592ddc19d894866bd6dedc
2022-10-20 18:21:58 -06:00
Nicholas Ray 990392cdeb Fix Vector 22 missing user menu on private wikis
When `$wgGroupPermissions['*']['edit'] = false;` is set, an `emptyPortlet` class
is added to the user menu which prevents the menu from showing even though it
contains a login link.

Changes:

* Vector-22 now determines what classes are applied to the user menu's container
instead of core deciding that on Vector's behalf (L761 of
SkinVector::getUserMenuPortletData). This eliminates the undesirable
`emptyPortlet` class. This can potentially be removed upon completion of
T319356.

* Conditionally renders the learn more link based on whether
$userMenuData['is-empty'] is `true` so that we don't show the learn more link
when the anontalk and anoncontribs menu items aren't present.

Bug: T317789
Change-Id: I883926c36f59d446076f960ead31f82e51967e70
2022-10-20 17:12:10 -06:00
jenkins-bot 7dcab752e4 Merge "Update package-lock.json to lockfileVersion 2" 2022-10-20 20:18:53 +00:00
Translation updater bot 0702d214ad Localisation updates from https://translatewiki.net.
Change-Id: Ib31004950c9b3bbd838f2fcb01ac3bbaf8da006a
2022-10-20 08:34:15 +02:00
jenkins-bot dc035e181a Merge "i18n: Rename some messages to follow common practice" 2022-10-19 16:45:06 +00:00
jenkins-bot fd259ed3c2 Merge "Set width of preview to match reading" 2022-10-19 14:28:37 +00:00
Lucas Werkmeister 9da506d455 Update package-lock.json to lockfileVersion 2
All the images available in Fresh [1] include an npm version that
produces new-format lockfiles by default, so it’s actually not easy for
contributors to make any package changes *without* bumping the version.
Let’s just do it in a separate commit.

[1]: https://github.com/wikimedia/fresh

Change-Id: I42b2d0189c2cc1c20e4d1a05a6593a5ea421d060
2022-10-19 14:44:51 +02:00
Func 9afe5a6e87 i18n: Rename some messages to follow common practice
We usually prefix the message keys with the skin/extension name,
and use label/help/tooltip as postfix when needed.
The naming of the tooltip above is limited by Linker::tooltip(),
so not able to rename it. Maybe some work is needed in the core.

Other languages' work will be follow-up by the translation bot.

Bug: T319447
Change-Id: I3c88871540b7668f1699fe3a86a8146f97ff5282
2022-10-19 20:22:02 +08:00
Translation updater bot 628b257447 Localisation updates from https://translatewiki.net.
Change-Id: I3f5e0bb6c52e52444ddf35cc5bfba2b4dee274a7
2022-10-19 08:22:52 +02:00
Jon Robson d7f7302cee i18n: Fix typo and simplify preference description
Additional follow-up to 76d1135

Change-Id: Iea478cbfa7ae36b6f1d45ffd74eb58f358ad54f1
2022-10-18 08:21:42 +00:00
Translation updater bot 989bfa7397 Localisation updates from https://translatewiki.net.
Change-Id: I1800b5cd4243168356c04da8a6edf128671e1a22
2022-10-18 08:25:09 +02:00
Sam Wilson c2e7595809 Set width of preview to match reading
Preview width is set at 60em, but the container as a different
font-size to .vector-body and so the preview was displaying at
the wrong width.

This change removes the font-size from the grantparent and
re-sets it on the contents of #wikiPreview, ensuring that the
final size matches the actual non-editing width of the body
content.

In addition, the 'submit' action is added to the list of those
excluded from constrained width, so that the editing textarea
remains at full width even when previewing.

Bug: T312963
Change-Id: I1a1df32b00d5faecb73f8c53256342d356a9352c
2022-10-18 13:26:31 +08:00
Func e23ec1d0fa Follow-up 76d1135: Use better practice in the code
* The new preference should be prefixed with 'vector'. This is only
  for use in vector skin

* Use registration instead of the hook to set the default user
  preference. For non-dynamic defaults, registration in skin.json
  is preferred.

* Remove the 'wp' prefix for 'hide-if' parameter of field descriptor.
  The core did try to strip the 'wp' prefix when mismatched, which is
  only for backward compatibility.
  Field name without prefix (which is the key of the field descriptor)
  should be used instead.

Bug: T319447
Change-Id: I25aa0cb23b78cf06f77fb20207dee7e1742d0ca7
2022-10-18 03:26:30 +00:00
jenkins-bot 93f11b3794 Merge "Create user preference to turn fixed width on and off" 2022-10-17 20:24:31 +00:00
Moh'd Khier Abualruz 76d1135810 Create user preference to turn fixed width on and off
Additional changes:
* Move static classes (skin-vector-legacy and vector-toc-not-collapsed)
to skin.json

Bug: T319447
Change-Id: I3525f8bfe27445e3af83ce5cd34b4da643178fe2
2022-10-17 20:02:39 +00:00
Translation updater bot 9699aab0f9 Localisation updates from https://translatewiki.net.
Change-Id: Ibbda1be4ae53cc7ca419477658d5e3ca78c24209
2022-10-17 08:25:08 +02:00
Translation updater bot 5cadd0b9b0 Localisation updates from https://translatewiki.net.
Change-Id: Ica521902b531db4d0af9c6025a09be85efb43080
2022-10-14 08:45:33 +02:00
jenkins-bot 3f00191c85 Merge "Split MenuPortal.less into legacy and modern Vector" 2022-10-13 17:53:53 +00:00
Translation updater bot f7d1e7b11a Localisation updates from https://translatewiki.net.
Change-Id: Iab56a38f9f5cedad7d67b440a737ac6a8c2236b8
2022-10-13 08:11:42 +02:00
Translation updater bot a1fe3a88b6 Localisation updates from https://translatewiki.net.
Change-Id: Ie95265417949ad636154d63e513b5b59304e6a79
2022-10-12 08:22:42 +02:00
Translation updater bot fabcf84b0c Localisation updates from https://translatewiki.net.
Change-Id: I6fb542362b3fbed73cfdea6d807225c97cd20aa7
2022-10-11 09:19:06 +02:00
Translation updater bot 5c19c19eb6 Localisation updates from https://translatewiki.net.
Change-Id: I656ca80609e386cd4006e39a8773aaff2ced12c9
2022-10-10 10:23:55 +02:00
jenkins-bot 74bdd375bb Merge "link.prepend is not a function in older browsers" 2022-10-09 09:33:52 +00:00
Jan Drewniak d2618e9428 Split MenuPortal.less into legacy and modern Vector
Removes the common MenuPortal.lesss code and splits it into
Vector 2022 and Vector legacy in anticipation of changes to
the sidebar in Vector 2022.

Bug: T317583
Bug: T319348
Change-Id: I57d3dc3458a7d6a4877170c26c88ca9222e00ff7
2022-10-07 17:40:49 +00:00
Jon Robson 8a54c0841b link.prepend is not a function in older browsers
Seen in logstash for Chrome 50.
Icons are not essentially, so gracefully degrade in these browsers
to items without icons.

Change-Id: I083c87c9bf5f256c8bcd2893e251571b97440ce1
2022-10-07 00:59:00 +00:00