Commit graph

5018 commits

Author SHA1 Message Date
Eric Gardner d60a644264 icons: restore "background-" CSS rules
Temporarily hard-codes some CSS background rules after Codex's
CSS-icon mixins stopped supplying them upstream (after changing
to use mask-image in icons).

Bug: T358160
Change-Id: I13be424c58b105472ef22f14e4381693f2985cd8
2024-02-21 21:42:46 -08:00
libraryupgrader eae793a8ca build: Updating npm dependencies
* @wikimedia/codex: 1.3.2 → 1.3.3
* @wikimedia/codex-icons: 1.3.2 → 1.3.3

Change-Id: If6552212b2455cfdb42659a3ffc52700a486941c
2024-02-21 02:36:54 +00:00
jenkins-bot fea70bcab1 Merge "Do not use vertical gradient mixin" 2024-02-21 00:47:56 +00:00
Jon Robson 9f1b94ce20 Correct how font sizes apply to headings
The margin and font rules are being overriden in DiscussionsTools
using equal specificity. The correction to the load order in
ResourceLoader skin module in
I83ac918ad8807c65aab2cd1dd8d7d2cd34b512af will break this.

Bug: T354975
Bug: T357929
Change-Id: I15eaf43c6750c76363ec804eda9b8ca6ec4709c2
2024-02-20 19:38:56 +00:00
Jon Robson fb9eccc071 Remove redundant site notice styles
These are currently being overriden by styles inside core
which also set margin to 0.

In I83ac918ad8807c65aab2cd1dd8d7d2cd34b512af these would override the
default leading to unintended UI changes.

Bug: T354975
Change-Id: I379ad6293bd1aa2a9304369969978cea684da98a
2024-02-20 09:28:24 -08:00
Translation updater bot 1c93781c78 Localisation updates from https://translatewiki.net.
Change-Id: I191a58f73a2f43747846955fcf0aa46e353971a1
2024-02-20 08:40:25 +01:00
Translation updater bot 928d62fe71 Localisation updates from https://translatewiki.net.
Change-Id: I7f6b9751a97d6b4bbf2c1d0663747bc45b59848d
2024-02-19 08:43:08 +01:00
Jon Robson b49ec394be Do not use vertical gradient mixin
The LESS mixin average is not compatible with CSS variables
so replace the call with the equivalent code.

Change-Id: I148eaca747352ffdc9d1423f20d34bd5a1d0e447
2024-02-16 02:14:30 +00:00
bwang 14a40c0be6 Override night mode pref with night mode query string
Bug: T357329
Change-Id: I30766bced218208ddfe5c2990d7dac290441a1d0
2024-02-15 13:59:12 -06:00
Translation updater bot 42781512ec Localisation updates from https://translatewiki.net.
Change-Id: I96089f49c8163e8b97f30fcb8c17d4dd8d1e47ed
2024-02-15 13:31:45 +01:00
Translation updater bot 198a07c02d Localisation updates from https://translatewiki.net.
Change-Id: I91e131d2f2c9d0af3ce241b4047c38e6c9185129
2024-02-14 08:21:03 +01:00
jenkins-bot f004beb8a1 Merge "Provide a visual hint that night mode is being triggered in Vector" 2024-02-14 05:27:47 +00:00
jenkins-bot f336efd555 Merge "Make vector-2022 mw-indicators flex-wrap" 2024-02-14 02:31:28 +00:00
Jon Robson 4a2e3f8917 Provide a visual hint that night mode is being triggered in Vector
Working on feature flag not having this is causing confusion. This
will speed up development by allowing me to more easily determine what
mode I am in at all times.

Change-Id: I5d4168bbf7df41f4754b36c6e6aa4955dbc609bb
2024-02-13 22:52:00 +00:00
Derk-Jan Hartman 73f53882d5 Make vector-2022 mw-indicators flex-wrap
Using an 8px gap by default. 8px is used a few times in vector-2022.
Wrapping is useful for userpages with a lot of indicators.

Bug: T340810
Change-Id: I75b59c633a6ff7a8bfdc624e6e5ba06f35fb6aee
2024-02-13 21:01:32 +00:00
bwang 809576b341 Move pinnable element spacing from the pinnable element to the container
Bug: T354431
Change-Id: I8acdb29fab7a0cd4bc8578a85509847d43abbab2
2024-02-13 14:48:48 -06:00
libraryupgrader 3d695f089c build: Updating dependencies
composer:
* mediawiki/mediawiki-phan-config: 0.13.0 → 0.14.0

npm:
* grunt-banana-checker: 0.11.0 → 0.11.1

Change-Id: Iefe491b9533b38585a6c739f0097c47aef5f857b
2024-02-13 20:08:29 +00:00
jenkins-bot e98def8329 Merge "build: Bump vue, codex versions" 2024-02-13 19:44:02 +00:00
Taavi Väänänen 6101edfbbc
build: Bump vue, codex versions
Change-Id: I3feda0348b8cbbe7be28d3a5e3bf1912d25c6130
2024-02-13 20:53:18 +02:00
jenkins-bot 2470c2b332 Merge "Add PHPUnit tests for VectorComponentMainMenuAction" 2024-02-12 22:14:14 +00:00
jenkins-bot 46048e56ab Merge "Callback should only be run after completion of API save request" 2024-02-12 19:35:24 +00:00
jenkins-bot 533b83a863 Merge "test: Add PHPUnit tests for LanguageService" 2024-02-12 17:06:07 +00:00
Jon Robson 2b4b256d4e Callback should only be run after completion of API save request
Bug: T357212
Change-Id: Icee40b8f9b642e516583998f98cf0072a9e37dee
2024-02-12 08:52:46 -08:00
Doğu Abaris 1b692aef4d test: Add PHPUnit tests for LanguageService
Adds tests for LanguageService in Vector skin.
Covered:
- `testConstruct`: Validates property initialization.
- `canWordsBeSplitSafely`: Tests that the language is splittable or not.

Change-Id: Icc1c269c56e0e53c624074516aee95ba242a55d7
2024-02-12 16:25:43 +00:00
jenkins-bot e3e458cb87 Merge "Add PHPUnit tests for VectorComponentMenu" 2024-02-12 16:07:33 +00:00
Translation updater bot 235f873530 Localisation updates from https://translatewiki.net.
Change-Id: I7aa739b484ecb830361a79897d725e15f5c388fa
2024-02-12 14:52:34 +01:00
Doğu Abaris 71f9552bb2 Add PHPUnit tests for VectorComponentMenu
Adds tests for VectorComponentMenu in Vector skin.
The test suite includes the following validations:
- Constructor initialization with expected parameters and behaviors.
- Validate counting logic for menu items.
- Validates `getTemplateData` method's output for correctness.

Change-Id: Ia52aa70e9213f6627d063d520fdbb2e353f0bfcb
2024-02-10 09:16:39 +00:00
Doğu Abaris fab1b342e0 Add PHPUnit tests for VectorComponentMainMenu
Adds tests for VectorComponentMainMenu in Vector skin.
The test suite includes the following validations:
- Constructor initialization with expected parameters and behaviors.
- Correct identification of 'is-pinned' state
- Inclusion of data for first portlet and rest portlets
- Handling of pin/unpin actions and language alert considerations
- Proper integration of menu elements based on user and feature flags

Change-Id: Ie408ff668893d1de2cf9dd1211a9c82c0b882f99
2024-02-10 01:38:59 +00:00
Doğu Abaris f1c6c828a9 Add PHPUnit tests for VectorComponentMainMenuAction
Adds tests for VectorComponentMainMenuAction in Vector skin.
The test suite includes the following validations:
- Constructor initialization with expected parameters and behaviors.
- Validates `getTemplateData` method's output for correctness.

Change-Id: I5deda64dc1bd3db85df69d0bb5a5a27f6fb8c1ff
2024-02-10 01:38:47 +00:00
jenkins-bot 64218333de Merge "Add PHPUnit tests for VectorComponentLanguageDropdown" 2024-02-10 00:58:44 +00:00
Doğu Abaris 6212b8feac Add PHPUnit tests for VectorComponentLanguageDropdown
Adds tests for VectorComponentLanguageDropdown in Vector skin.
The test suite includes the following validations:
- Proper handling based on page type (subject/talk).
- Correct labeling and icon selection.
- Accurate class and aria label configuration.

Change-Id: I145cb250c513f3f81e780195485907897788f5c4
2024-02-10 00:20:12 +00:00
jenkins-bot 76f8f7419b Merge "Add PHPUnit tests for VectorComponentDropdown" 2024-02-09 19:59:15 +00:00
jenkins-bot ec90e77f89 Merge "Add PHPUnit tests for VectorComponentClientPrefs" 2024-02-09 19:51:07 +00:00
jenkins-bot 72467ee757 Merge "Add PHPUnit tests for VectorComponentButton" 2024-02-09 19:23:15 +00:00
Translation updater bot dc6201ce6e Localisation updates from https://translatewiki.net.
Change-Id: I43ccc398fc0bc481e850d2a51d85c56d30cfb682
2024-02-09 08:45:57 +01:00
jenkins-bot 5fc7f5d360 Merge "Add PHPUnit tests for VectorComponentPinnableHeader" 2024-02-09 01:22:25 +00:00
jenkins-bot a96dcb1099 Merge "Truncate long usernames with an ellipsis" 2024-02-08 19:23:53 +00:00
jenkins-bot 5a24f61c3b Merge "Fix extra space from pinned sticky container" 2024-02-08 17:45:21 +00:00
bwang de4b9faeba Fix extra space from pinned sticky container
VISUAL CHANGE:
* The gap between the title and the text "From mediawiki"
decreases - this is an improvement.

Bug: T357022
Change-Id: I436171448ca69413a004024157b24d502aa63bea
2024-02-08 17:11:47 +00:00
bwang 5012f7fff0 Zebra selector clean up
Change-Id: I6a942913ae2fec066b97c1824a09bb07a8eeef45
2024-02-08 10:49:49 -06:00
Translation updater bot 24a4594047 Localisation updates from https://translatewiki.net.
Change-Id: I4f0294a4fbedad91d20b3ea95168ebfe8d033964
2024-02-08 09:18:25 +01:00
Jdlrobson 98817085b7 Changes to list spacing
Update <p> spacing to improve consistency of ul/ol spacing,
also update heading spacing to be more consistent,
relying on mw defaults more

This reverts commit 8d3bda7867.

Bug: T352875
Change-Id: I46bf5e3713b4648e9c3facf5e927e924ba51b23f
2024-02-07 20:21:17 +00:00
Doğu Abaris cd032f4c4c Add PHPUnit tests for VectorComponentDropdown
Adds tests for VectorComponentDropdown in Vector skin.
The test suite includes the following validations:
- Correct template data generation.
- Proper label, tooltip, and icon handling.
- Accurate CSS class construction for various states.

Change-Id: Iafd28cfe62eb4b8c6039f819b9d8f005b0b32d48
2024-02-07 10:40:26 +00:00
Doğu Abaris 4b1a4726a0 Add PHPUnit tests for VectorComponentClientPrefs
Adds tests for VectorComponentClientPrefs in Vector skin.
The test suite includes the following validations:
- Both pinned and unpinned states
- Correct structuring of 'data-pinnable-header'

Change-Id: I745559b2f738b4bed0f152fc8de3af1653b96ecd
2024-02-07 10:18:11 +00:00
Translation updater bot 6114ad8114 Localisation updates from https://translatewiki.net.
Change-Id: I1f89531d09cc6480f721384934d726be43743044
2024-02-07 08:29:34 +01:00
Doğu Abaris 880ae42fde Add PHPUnit tests for VectorComponentButton
Adds tests for VectorComponentButton in Vector skin.
The test suite includes the following validations:
- Various button configurations and expected CSS classes.
- Accurate template data for label, icon, href, and custom attributes.
- CSS classes according to weight, action, and iconOnly.

Change-Id: I228c197e5adee59a79ab6e2aad74ff0f18ef6b38
2024-02-07 00:21:14 +00:00
Doğu Abaris 4775215a5c Add PHPUnit tests for VectorComponentPinnableHeader
Adds tests for VectorComponentPinnableHeader in Vector skin.
The test suite includes the following validations:
- Correct template data generation based on constructor parameters.
- Accurate label generation from MessageLocalizer.
- Conditional logic for 'moveElement' affecting container ID attributes.

Change-Id: I2412c86e08dfca088ca57330b4dd078c212513f9
2024-02-07 00:11:15 +00:00
Doğu Abaris be11774875 Add PHPUnit tests for VectorComponentPinnableContainer
Adds tests for VectorComponentPinnableContainer in Vector skin, ensuring:
- Proper initialization with ID and pin status.
- Correct template data based on init params.
- Consistent template data for pinned/unpinned states.

Change-Id: Iec33c11b0afbe2bea5b6708b83b9ea618f7e809b
2024-02-06 23:41:35 +01:00
Doğu Abaris 8353c535c6 Add PHPUnit tests for VectorComponentPinnableElement
Adds tests for VectorComponentPinnableElement in Vector skin, ensuring:
- Proper instantiation with an ID parameter.
- Correct return of template data containing the ID.
- Reliability in handling element ID for use in templates and UI.

Change-Id: I3758f042ad43b90ee94a3b5aa14537fa1b0657d1
2024-02-06 23:41:35 +01:00
Doğu Abaris 2414a69730 Add PHPUnit tests for VectorComponentLink
Adds tests for VectorComponentLink in Vector skin, ensuring:
- Initialization with parameters.
- Generation of html-attributes string with title and aria-label.
- Consistency in link attributes for accessibility and UX.

Change-Id: I80b8a84d1d10bc7274ba5267910206d7f6e68534
2024-02-06 23:41:35 +01:00