Commit graph

7 commits

Author SHA1 Message Date
Reedy 621484ca7b Use explicit nullable type on parameter arguments
Bug: T376276
Change-Id: Ic96b569cb73534d00f2ccd43829235351c6889c3
2024-10-28 22:22:03 +00:00
thiemowmde d95baa48da Turn if…return true…else…return false into boolean expressions
Does the same as before.

Change-Id: I8e594f69e435ae48c459bf95dfd2e6d06e9f347d
2024-10-09 09:46:50 +02:00
Fomafix 94d1bee402 Simplify PHP code
* Use !== instead of !=
* Avoid else after return
* Use falsey check for object is null
* Use consistently spaces inside of brackets

Change-Id: I2928664acbab315ab3eae38c74f87b019d46cf29
2024-05-20 18:23:48 +00:00
Jon Robson 176a6397ce Correct behaviour of ConfigHelper, add tests
Bug: T365084
Change-Id: I220990554d0a07642dd03a0c7bd53f9bd7ff55ec
2024-05-16 08:04:45 +02:00
Steph Toyofuku 3387ef3ee4 Add tests for ConfigHelper
This class is being used in both vector and minerva, and we are
currently depending on it working for our night mode rollout, so let's
add some test coverage!  Also fixed a small spacing issue in production
code that was bothering me lol

Note: these are not totally exhaustive - next steps would be to ensure
that the exclusions/inclusions work with arrays and not only single
elements, but hopefully this helps build some confidence ☺️

Change-Id: Iebea43eae6b1517fd778763db4f5db3b0fd9c30f
2024-03-27 16:49:39 -07:00
Jon Robson 9c063383a3 Permit sharing of code between Vector and Minerva
Bug: T359607
Change-Id: Iab6ca28b8b460be864fb6591adb407ccb20f3718
2024-03-20 19:57:11 +00:00
Jon Robson f28f5850c5 Separate generic ConfigHelper class from LimitedWidthContentRequirement
In preparation for a decision around how we share code, the generic code in
LimitedWidthContentrequirement is moved to ConfigHelper class. A fix
recently applied to Minerva (Ied3ed927202dd9356ebeb7e404230f571a1d910d)
is also incorporated into the new class.

The expectation is this code will be either:
1) be replaced by a submodule
OR
2) Used directly by Vector
after a decision tomorrow.

Bug: T359607
in I3967803bd75cf78d27c1a7c08e62730e46678a68 or removed

Change-Id: I04066acc86594e721e071e9096e1b12e1255b54b
2024-03-20 00:23:51 +00:00