wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-12-02 19:26:51 +00:00
Code Issues Packages Projects Releases Wiki Activity
5408 commits 14 branches 21 tags 95 MiB
Commit graph

8 commits

Author SHA1 Message Date
Jon Robson a6e4370bbd Fixes: Echo icon not visible after click 
Due to T343838, we need to adjust the Echo icon after clicking
so it renders consistently with Codex. This is a longstanding bug
and a slight adjustment to how we approach the icon now that Codex
and Vector 2022 use mask-image for their icons.

Bug: T373936
Change-Id: Icdb9cc49c157cb5cbf13fe1f7d5e91b7e986e92e
 2024-09-04 18:16:13 +00:00
Ed Sanders 7e7486c4a5 build: Update eslint-config-wikimedia to 0.28.0 and autofix 
Change-Id: I350941a711d2304fc968b3ba1f1e0afa5878578e
 2024-06-06 16:22:05 +01:00
Jon Robson 68239ae344 Use Codex for button styles, start transitioning icons to use Codex icon mixins 
Changes:
- mw-ui-button to cdx-button
- mw-ui-quiet to cdx-button--weight-quiet
- mw-ui-icon-element to cdx-button--icon-only
- mw-ui-icon to vector-icon
- mw-ui-icon-flush-right/left to vector-button-flush-right/left
- Removes $isSmallIcon param in Hooks.php

85 Visual Changes
- ~36 changes from minor pixel changes from the new button classes in the main menu, language button
- 22 from standardizing the padding of the TOC in page title
- ~10 changes from addition of .cdx-button to the TOC toggle buttons

PERFORMANCE:
This will result in an overall increase of 2.7kb of render blocking
CSS, 1kb will be reclaimed when
I6c1ed1523df8cc9e2f2ca09506f12a595b8b013d is merged.

Co-author: Bernard Wang <bwang@wikimedia.org>
Bug: T336526
Change-Id: Ibd558238a41a0d3edb981e441638f9564f43d226
 2023-06-12 16:26:28 -07:00
Nicholas Ray 630d47792a Fix InvalidCharacterError: Failed to execute 'add' on 'DOMTokenList' 
Bug: T335149
Change-Id: I9dad78af21ca7ee272a3661f5869e6337909dc05
 2023-04-20 13:44:36 -06:00
Jon Robson 080b6958e8 Use modern ES6 methods 
* Prefer dispatchEvent to $.trigger
* Prefer Object.assign to $.extend
* Prefer URLSearchParams to $.params
* Prefer getAttribute / properties to $.attr
* Prefer document.querySelectorAll over $.find

Change-Id: I5f4464e5bfa11b401e663f0b8761fc6092380627
 2023-04-14 13:38:38 -07:00
Jon Robson 87dd101a69 Consolidate and fix eslint errors, dropping ts-ignores 
* Upgrade @wikimedia/types-wikimedia to allow us to drop several
@ts-ignores
* Merges eslint rules now that ES6 is default everywhere
* Runs autofix command
* Fixes various prefer-const errors

Change-Id: Iee5bcb93f10a76d80dbeec813f6387c13438263e
 2023-04-11 16:56:31 -07:00
Jon Robson 7c24aa46fb Drop the VisualEnhancementsNext feature flag 
Bug: T320101
Change-Id: I6d536af034dafd66c6478183de8029be9ed3e8b7
 2022-11-21 13:27:34 -08:00
Jon Robson 44ee12c717 [Visual enhancements next] Make the Echo buttons functional 
This completes the changes to Echo inside the
vectorvisualenhancementnext=1 feature flag

Bug: T257143
Change-Id: I8f3904815c90ef1a10a2342c5c70363c8b9e1e47
 2022-09-28 17:06:20 -05:00