Commit graph

1945 commits

Author SHA1 Message Date
Translation updater bot c5a6164cef Localisation updates from https://translatewiki.net.
Change-Id: I79d2b7ba3284c778b57c7a00fe1b753a51caf784
2020-12-11 08:39:13 +01:00
Jan Drewniak 8afa6f4440 Improve visual similarities between Vector and WVUI search forms.
Modifies and annotates the CSS required to make the server-rendered
version of the new search form look like the WVUI version of the
search form.

Bug: T264355
Change-Id: I989860cfbb755ecbb706b79bd807e9d0013bc4e5
2020-12-09 16:04:45 +01:00
Translation updater bot 3a782ce41b Localisation updates from https://translatewiki.net.
Change-Id: Ie798402f51360cc2bd4b8e1ca58fe833bfb1194e
2020-12-09 08:44:17 +01:00
jenkins-bot a9b47f57fb Merge "Development: Allow us to test search with different API hosts" 2020-12-09 00:14:43 +00:00
jenkins-bot 454611f60a Merge "[search] Add Vue search performance instrumentation" 2020-12-09 00:06:32 +00:00
jenkins-bot 707862df60 Merge "[search] Instrument Vue.js-based search widget" 2020-12-09 00:06:30 +00:00
Nicholas Ray 3aaedcfe3c [search] Add Vue search performance instrumentation
This is almost identical to the instrumentation currently used in
production for mediawiki.searchSuggest -- the only differences being in
the nomenclature of variables, etc.

As part of comparing Vue search with legacy search, we need to track how
long it takes a keypress to load and render search results for Vue
search. This will only be used only in synthetic testing at this time
(Real user monitoring (RUM) is not in scope for this ticket).

To test locally, first enter characters in input. Then to see the
metrics recorded:

```
// View all marks
performance.getEntriesByType('mark');

// View all measures
performance.getEntriesByType('measure');
```

This commit adds the following metrics which will only be used in our
synthetic tests. We are not collecting RUM metrics at this time.

Measures:

* mwVectorVueSearchLoadStartToFirstRender: Measures the time it takes
from the start of loading the search module to the first render of results.

* mwVectorVueSearchQueryToRender: Measures the time it takes from
the start of the fetch to the render of search results.

Bug: T251544
Change-Id: I39200648a3a0a4079a132134d142ad8997c8962a
2020-12-08 23:41:28 +00:00
Sam Smith aa10668e6d [search] Instrument Vue.js-based search widget
Add event listeners and associated helpers to emit SearchSatisfaction
events via the `mediawiki.searchSuggest` protocol.

Bug: T257698
Change-Id: Ica040cd18d6c4bf8a1b1f607bb4647c7e8eb7108
2020-12-08 23:41:19 +00:00
jdlrobson dce24c9784 Development: Allow us to test search with different API hosts
By default the API uses location.host as the host, however during
development it is useful to test against production wikis

For example to test against English Wikipedia:
$wgVectorSearchHost = 'en.wikipedia.org';

Note: Links when clicked will not take the user to the target page, and
instead will take the user to the search results page with a link to
create the page.

The following config can be used to workaround that page:
$wgDisableTextSearch = true;
$wgSearchForwardUrl = "/w/index.php?title=$1";

Change-Id: I5fbac7f54844d7a9d6976007bc0d0ff9938b9f2b
2020-12-08 15:22:45 -08:00
jenkins-bot f44fefb53b Merge "Cleanup: Drop unused body feature classes" 2020-12-08 22:25:20 +00:00
jenkins-bot b8e8655af3 Merge "Add Wvui Config to show/hide thumbnails and descriptions" 2020-12-08 22:25:18 +00:00
jenkins-bot 3c6c8ebbba Merge "Integrate WVUI search into Vector" 2020-12-08 22:18:38 +00:00
jdlrobson a52da8ddaa Cleanup: Drop unused body feature classes
These are no longer referenced in the code and artifacts of a time
when these were feature flagged.

Change-Id: Ia850ac9fb92033d82a333836ba7ff32312f042a7
2020-12-08 13:29:06 -08:00
Nicholas Ray e0c47dc462 Add Wvui Config to show/hide thumbnails and descriptions
Uses ResourceLoader's virtual config feature to get the config and pass
it down to Wvui's typeahead search component.

Disclaimer: I'm a typescript noob and am not sure if the
config.json.d.ts is correct although it seems to make tsc happy.

Bug: T260167
Change-Id: I2eced14c7df3b795b4de0e5149c2ca9fd598c7be
2020-12-08 13:28:42 -08:00
Jan Drewniak bd83398659 Integrate WVUI search into Vector
Creates a new skins.vector.search module that
replaces the searchSuggest module from MediaWiki core.

This module creates a new Vue app using the WVUI
search widget for the new search experience.

The legacy search input form is still retains on pageload,
and the new search kicks on search input focus.

In order to manage that transition, the legacy search
input is styled to resemble the new WVUI input, and the
new input is manually focused after the component mounts.

Vue is also added as a dev-dependency to help with
type-checking.

Other changes:
* the entry in skin.json is reordered alphabetically after
skins.vector.js

Bug: T264355
Change-Id: Ibb9561a77a14734297cb4d0ddcd415fc0750b45d
2020-12-08 13:27:12 -08:00
jenkins-bot 87fdf5d7c7 Merge "Amend standard 'search' icon size, position and CSS rules" 2020-12-07 12:47:14 +00:00
Volker E 795de73496 Amend standard 'search' icon size, position and CSS rules
Updating 'search' icon to latest WVUI/OOUI optimized, reduced path. Also
- amending size of search input and position of icon in input slightly to
  align it closer to standard text inputs
- simplify CSS by getting rid of selector which is targeting both, input and
  button and applying rules only where needed
- fixing code comments
- increasing icon size to `16px` equivalent `em` to enable user text zooming
  preference applied to search icon as well. `16px` is a compromise towards the
  old look and feel of the previous icon bringing it closer to standard icon size in
  legacy Vector.

This change affects both modern and legacy versions of Vector.

Bug: T266166
Change-Id: Ib4c0c74d3cac30e1893f4c76e56e1197652d41ba
2020-12-07 12:19:01 +00:00
Translation updater bot cff34a672a Localisation updates from https://translatewiki.net.
Change-Id: I1f6e3d4c9f80faa7f09e1fdc08a172737e8ecb74
2020-12-07 08:57:20 +01:00
Translation updater bot 2ff4d4d6ae Localisation updates from https://translatewiki.net.
Change-Id: I664835d6ac97c08d0bf06bb0a0e339425dc49efc
2020-12-04 08:36:03 +01:00
Translation updater bot 5bf22a7740 Localisation updates from https://translatewiki.net.
Change-Id: Iebb97cb0f2b3fe374c9366ec6c91366546e42bd4
2020-12-02 08:34:47 +01:00
Translation updater bot a6a3c5961f Localisation updates from https://translatewiki.net.
Change-Id: I21ae32c8e160374e8d77e91d4802d2ab8bdced96
2020-11-30 08:50:53 +01:00
Translation updater bot 2e77a06c10 Localisation updates from https://translatewiki.net.
Change-Id: Idc5de274ca9ee6af6d90dafca51128082eb7e468
2020-11-27 08:32:32 +01:00
Jan Drewniak 125fa03395 Update Vector search icon
Replaces vector search icon with an update version that is
copied from the OOUI icon set and used in WVUI search.

This update will help us unify the visual appearance of the
existing search input with the one in WVUI.

Bug: T264355
Change-Id: I34792ee80e711b10b441668cc4ae18cc0cc9daa6
2020-11-26 13:19:11 +01:00
libraryupgrader 659e8989ac build: Updating stylelint-config-wikimedia to 0.10.3
Additional changes:
* Removed globals `require`, `module`, included via `wikimedia/mediawiki` profile (T262222).
* Dropped the emtpy global definition in .eslintrc.json.

Change-Id: I18ea7925d42ae65c6afd49982186d9375ab9e6e3
2020-11-23 03:44:23 +00:00
Umherirrender f0e6b9dc89 build: Updating mediawiki/mediawiki-phan-config to 0.10.4
Change-Id: I6f0e5fe41eb71abf42273a3d9cc1390376605f7c
2020-11-22 20:32:34 +01:00
Translation updater bot ef7fa0010e Localisation updates from https://translatewiki.net.
Change-Id: I5608e335d2a5259c6e31cc598c3a11d414828b96
2020-11-20 09:19:15 +01:00
Translation updater bot 39508c0d59 Localisation updates from https://translatewiki.net.
Change-Id: I1c647dde769fcaeeecb0c2737b21e0e1ad5f53dd
2020-11-19 09:11:54 +01:00
Nicholas Ray 0492bc5fb8 Apply static positioning to mw-footer-container
There are popovers such as the discussion tools "Add a link" popover
that need to stack on top of the footer. This replaces the
mw-footer-container's `relative` positioning with `static` positioning
which is one possible solution to this problem.

Alternatively, the popover could be appended to the end of the body
after the footer and positioned absolutely.

Bug: T264679
Change-Id: I34168c181a1e05c33cd42f664fcccb25abd4519b
2020-11-18 18:10:20 +00:00
Translation updater bot 7d41a66016 Localisation updates from https://translatewiki.net.
Change-Id: I9d196b692462e2c2e4ba00f3572e5718aa28c6eb
2020-11-18 08:58:45 +01:00
jenkins-bot 601b0fbd81 Merge "build: Updating mediawiki/mediawiki-codesniffer to 33.0.0" 2020-11-17 23:03:58 +00:00
Umherirrender 6d992c65b0 build: Updating mediawiki/mediawiki-codesniffer to 33.0.0
Change-Id: I4ef344e62ce996b9d03d08b47c0f869ead417f7b
2020-11-17 23:33:50 +01:00
jenkins-bot b1bbcd298f Merge "Use the SkinMustache template variable for the main page link" 2020-11-17 19:14:01 +00:00
jenkins-bot 9ccd8e2c23 Merge "[modern][styles] Remove unnecessary margin-top" 2020-11-17 14:03:40 +00:00
jenkins-bot 5dd89219c6 Merge "Follow-up I43a6951: Remove unnecessary only-child selector" 2020-11-17 13:34:54 +00:00
Translation updater bot d6aec7ead8 Localisation updates from https://translatewiki.net.
Change-Id: Ibc5576cdd8dd4ac61370ebe85c893827c5f0d01a
2020-11-17 08:44:56 +01:00
Ed Sanders 1dccf67d0f Follow-up I43a6951: Remove unnecessary only-child selector
An only-child will match first- and last-child selectors
so this additional selector is not required.

Change-Id: I17d468ba2bda37edc4e54f42f42d50e4b8831b46
2020-11-16 22:39:17 +00:00
jdlrobson ffa19b2ae3 Use the SkinMustache template variable for the main page link
Bug: T248752
Depends-On:  I98fc4755e6a736efc2210f8b6ddf4a1cc4eea378
Change-Id: I077abba357e503c79901b64be2ccbb3f2efe1c18
2020-11-16 13:18:18 -08:00
jdlrobson bc9383c90a Bump the bundlesize of skins.vector.styles
Needed in preparation for landing the core change in
Ie28b7e732664eb332be795d7e33cd9a227c21370

Bug: T252774
Change-Id: Ia9ba9458c1bdb5b70cf03bad7d6e05e872755f1e
2020-11-16 12:34:40 -08:00
Translation updater bot 4cc3db64a3 Localisation updates from https://translatewiki.net.
Change-Id: I73fcd7f352a1da44af75f572c7060fb105bf44bb
2020-11-16 08:40:36 +01:00
Translation updater bot 4079b5c16a Localisation updates from https://translatewiki.net.
Change-Id: I1df7a545ce1d3557739f59cd688bc84a90583d78
2020-11-13 08:32:29 +01:00
Translation updater bot bff40163c8 Localisation updates from https://translatewiki.net.
Change-Id: I5be942dab5ffb364001666f9cf15297082adb617
2020-11-11 08:39:03 +01:00
Volker E b0e54eec45 [modern][styles] Remove unnecessary margin-top
Following-up Iecb0d6c4c80cee1d1684597a6dedf7323e2ec54d.
It isn't set anywhere inherited, hence we don't need to set it here.

Change-Id: Ife24aa95e6d1830b8d50001976277dbb2535c47f
2020-11-09 07:49:56 -08:00
Translation updater bot 6014b746a4 Localisation updates from https://translatewiki.net.
Change-Id: I39b966226a371777eb87052ce6b5e9b6ff5a4c9c
2020-11-09 08:38:23 +01:00
jdlrobson f99946236a Cleanup: Merge layout-max-width.less into default layout rules
* Drop some unused variables
* Drop global variables.less per max width FIXME

Bug: T258116
Change-Id: Iecb0d6c4c80cee1d1684597a6dedf7323e2ec54d
2020-11-06 20:21:56 +00:00
jenkins-bot 28aa6b84b3 Merge "Cleanup: Merge layout-search-header.less into default layout rules" 2020-11-06 18:29:21 +00:00
Translation updater bot 3b642b21aa Localisation updates from https://translatewiki.net.
Change-Id: Ic26e526d98befc69fb08169dba7296d3bf3991de
2020-11-06 08:36:36 +01:00
jenkins-bot 3ead4e0aa0 Merge "Separate opt out data from sidebar" 2020-11-05 23:32:50 +00:00
jdlrobson 227534102a Separate opt out data from sidebar
In preparation for using the data provided by SkinMustache class
we need to separate the opt out data from the rest of the sidebar.
The opt out data is specific to Vector.

Change-Id: I4461da92c1787d272bbf99e6644bdb9e6c388a68
2020-11-05 22:08:00 +00:00
Translation updater bot 15d1c31932 Localisation updates from https://translatewiki.net.
Change-Id: I2732264fa08b32e8306c44fed9ee37d7a86d47fd
2020-11-05 08:30:02 +01:00
jdlrobson 717506b9c0 Cleanup: Merge layout-search-header.less into default layout rules
Dropped all usages of the no longer applicable `skin-vector-search-header-legacy`
class.

Bug: T258116
Change-Id: I16a5cf8dda2ab84ff4b505d5a368587190c409cd
2020-11-04 14:30:13 -08:00