Commit graph

2132 commits

Author SHA1 Message Date
Sam Smith 9914d813d6 [search] Don't destroy #p-search element
The #p-search element is present in at least the Vector, Vector V2,
Timeless, and Monobook skins. This is because the HTML for the element
is generated in MediaWiki Core. At the very least, the
SearchSatisfaction instrument relies on the element always being
present.

Update the skins.vector.search module to simplify the App component
template so that it doesn't render a div#p-search element and mount that
component on the #searchform element instead.

Bug: T274869
Change-Id: Ifde679b62484fda7661fded2d978b78adac9f5da
2021-04-21 14:01:56 +01:00
Translation updater bot 90da534616 Localisation updates from https://translatewiki.net.
Change-Id: I93bb9656c6c06ea3d0f69246e5fa8a3abbea141b
2021-04-21 08:54:55 +02:00
jenkins-bot 83c92290ae Merge "build: Update 'svgo' to latest" 2021-04-19 13:50:39 +00:00
Translation updater bot 94b565a208 Localisation updates from https://translatewiki.net.
Change-Id: I440051ebab3844e22203bd9d0fcf79413b81324d
2021-04-19 08:54:44 +02:00
Volker E 2b5c18d7c9 build: Update 'svgo' to latest
Also change script name to 'minfiy-svg' to align with other npm 'svgo'
using products and to improve readability for non-native speakers.

Bug: T278656
Change-Id: Ib2a8a251a48ea99c8019d63b4f2586fea4079021
2021-04-18 14:51:48 -07:00
jenkins-bot e637cef2c2 Merge "Add config for language in header for logged in/out users" 2021-04-16 17:49:43 +00:00
Clare Ming 8cab50874c Add config for language in header for logged in/out users
Register updated requirement for language in header for logged in and logged out users in Vector's ServiceWiring file. Make VectorLanguageInHeader backwards compatible to handle boolean values when registering LanguageInHeader feature. Update VectorLanguageInHeader variable to array in config to handle different logged states.

Bug: T277588
Change-Id: I37a3a01e83f051cf0679769c8b9b5b41f00d6d72
2021-04-16 10:38:28 -06:00
Translation updater bot 48eecb2d18 Localisation updates from https://translatewiki.net.
Change-Id: I551e3fa999bc747f9048092402b51f38e4bbc265
2021-04-16 09:52:10 +02:00
jdlrobson afaa02ae42 Adjust floating override
Follow up to I3234e7712b8c111b070c35e38425c865ff7213f9
Do not disable the feature entirely as it has other purposes.

Bug: T280260
Change-Id: I47d16eb8186efa83e158713d852b443bce9aee1c
2021-04-15 17:18:29 +00:00
libraryupgrader e352b94055 build: Updating npm dependencies
* eslint-config-wikimedia: 0.19.0 → 0.20.0
* ssri: 6.0.1 → 6.0.2
  * https://npmjs.com/advisories/565

Change-Id: I4db94efccd2d6b58b994b080a99c5c066b829892
2021-04-15 13:54:37 +00:00
Jan Drewniak f52c2f8a4a Scope right-aligned dropdown menus to #right-navigation & .mw-portlet-lang
Removes the global rule for right-aligning the Vector dropdown menus
and instead scopes that alignment to dropdown menus that appear
inside #right-navigation and the language button in modern Vector.

Bug: T275158
Change-Id: I6c00ccc365f70682841d9eda9d31bbe25c757aa0
2021-04-14 23:31:59 +02:00
Translation updater bot 50dcf4f7a5 Localisation updates from https://translatewiki.net.
Change-Id: I7dd1498a6d8f2ae4f22345e241e84d62be5b8e66
2021-04-13 09:23:44 +02:00
jenkins-bot dd19a1924c Merge "Reorganize LESS files to match ResourceLoader conventions" 2021-04-12 20:45:43 +00:00
Translation updater bot bf80910a79 Localisation updates from https://translatewiki.net.
Change-Id: If236b8fbf6ec044ce821713cb8bc882d4c36c7e2
2021-04-12 08:41:53 +02:00
Translation updater bot 7687748dc0 Localisation updates from https://translatewiki.net.
Change-Id: I2c313e7e737d1bbd2d8f1af76d7384ab0c24cf9a
2021-04-09 09:01:25 +02:00
Jan Drewniak edd2f4ff85 Reorganize LESS files to match ResourceLoader conventions
Separating most LESS files into 2 ResourceLoader modules and a common
folder:

- skins.vector.styles
- skins.vector.styles.legacy
- common

This changes aims to clearly separate the old (“legacy”), the new
(“modern”) and the common styles which were previously all placed under
`skins.vector.styles/`.

Inside each directory are separate folders for `layouts` and
`components`.

The entry files, `skin.less` and `skin-legacy.less` are moved into the
specific folders and a third, `common.less` entry file is created that
contains the common imports for both old and new Vector.

Aliases have been added to the Storybook Webpack config to avoid adding
the story file changes to this patch. Images coming from CSS `url()`'s
have also been temporarily disabled in Storybook until Storybook can be
upgraded to use Webpack 5, and use array values for aliases, in a
follow-up patch.

This patch also slightly changes a footer layout specific rule so that
existing `padding` remains unchanged in rendering due to new common and
component structure.

Bug: T264309
Change-Id: I1cd2681a2b61edb7be56c38f9bb3994827d7e322
2021-04-08 15:47:56 +01:00
libraryupgrader 2e9917d587 build: Updating y18n to 4.0.3
* https://npmjs.com/advisories/1654 (CVE-2020-7774)

Change-Id: I69ab4c5db75906cb6b774aadf772a47cdbce9cdf
2021-04-08 09:10:48 +00:00
Translation updater bot 7bbe0e1df6 Localisation updates from https://translatewiki.net.
Change-Id: I0a1246d8046d1edf891cc6d51cd34bcac93a89c1
2021-04-08 08:42:48 +02:00
Translation updater bot ec6bca52ee Localisation updates from https://translatewiki.net.
Change-Id: Ieefae3f13c641ac58859e0d9df47086038e8ecab
2021-04-07 08:54:20 +02:00
jenkins-bot 2e8f193072 Merge "Remove redundant mw-indicator styles from layout-default.less and layout.less" 2021-04-06 21:25:04 +00:00
Translation updater bot fcdc1cd80b Localisation updates from https://translatewiki.net.
Change-Id: I7021fbaffd6142087793eeb6c162a5a717e8d820
2021-04-06 12:06:01 +02:00
jdlrobson bdd7eaacf1 [legacy] Restore old floating style inside Vector
This is a modified revert of Ia1eec412111e8f6af3b45affdc186d9eafd4262c.
This is not applied to modern Vector, for reasons given on ticket.

Bug: T279008
Change-Id: I3234e7712b8c111b070c35e38425c865ff7213f9
2021-04-05 15:07:07 -07:00
Bernard Wang 55fdf38714 Remove redundant mw-indicator styles from layout-default.less and layout.less
Bug: T278362
Change-Id: I76f39a9f4cf7404e7d50a272ebce08d53594ef5f
2021-04-05 16:58:41 +00:00
jenkins-bot 1b42cd8dd4 Merge "[styles] LanguageButton: Amend icon color by setting opacity" 2021-03-30 23:10:51 +00:00
Volker E 5a1a382c17 [styles] LanguageButton: Amend icon color by setting opacity
Amending icon color by setting `opacity` accordingly to Design Style
Guide requirements.
Also using `em` base sizing for accessibility reasons in order to
make icon resizable on user text zoom preferences. And adding some
comments and mediawiki mixin usage.

Bug: T277660
Change-Id: Ia226857a38d3b3d5b4583e95905ef55e406c5cb2
2021-03-30 22:13:50 +00:00
jenkins-bot d6b7ef0a8e Merge "Hide languages-in-header button when no additional languages" 2021-03-30 18:23:55 +00:00
Jan Drewniak 980c8453ce Hide languages-in-header button when no additional languages
Hides the languages-in-header feature if there is only one
available language.
Also factors the additional classes required for the language
button into a separate function.

Note: Hiding the language button is a temporary solution
until T275147 is resolved.

Bug: T276950
Change-Id: I241abc6061bba12a6a209074fa4c2d2c89cea930
2021-03-29 23:07:26 +00:00
jenkins-bot 15e343dede Merge "Clean up VectorHooksTest" 2021-03-29 20:20:03 +00:00
DannyS712 7dfec540ec Clean up VectorHooksTest
Fix order of parameters in assertions.
Remove unneeded "\".
Make constant a class constant.

Change-Id: If372dec96b54d466a066163420c6fd9da177c66c
2021-03-27 02:25:22 +00:00
Translation updater bot c1a6d14fe9 Localisation updates from https://translatewiki.net.
Change-Id: I053d9f262c5947827570aa5a94c9980a8838d336
2021-03-26 08:53:07 +01:00
jenkins-bot d29bdb86bd Merge "build: Update SVGO to latest v2.2.2 and re-crush SVGs" 2021-03-25 23:17:31 +00:00
Ammarpad b7bf9a88a3 Use content-parser-output RL SkinModule feature
Require MW 1.36

Bug: T277218
Depends-On: I52f752aa782b09a51e2165300cc75d0e47fa3351
Change-Id: Ia1eec412111e8f6af3b45affdc186d9eafd4262c
2021-03-25 17:34:28 +00:00
Volker E 5734191840 build: Update SVGO to latest v2.2.2 and re-crush SVGs
SVGO v2.x changed configuration to JS, amending configuration.
Also re-crushing SVGs.

Change-Id: Id6379e06e6aa1c25760f8489166d354fca25cd52
2021-03-25 09:19:42 -07:00
jenkins-bot 734ced999b Merge "[styles] Remove margin normalization already covered in 'normalize' module" 2021-03-24 21:55:36 +00:00
Volker E e5b652852e [styles] Remove deprecated .box-shadow() mixin calls and cleanup vars
Removing calls to deprecated `.box-shadow()` as basic browser support
is now given unprefixed. In the course we also replace deprecated
vars with already available ones since MW v1.35 following unified
name scheme on both, box shadow and border ones.

Change-Id: Iae353c934c0995c0b6b2635761352685eb91accb
2021-03-24 14:03:25 -07:00
Volker E c8cd609862 [styles] Remove margin normalization already covered in 'normalize' module
Has been introduced before 'normalize' module, now it's time to remove
duplicated style property.

Change-Id: Idff74430655c29b67dfccf97a22f53caaee34155
2021-03-24 13:33:19 -07:00
Jan Drewniak 88dcdab6db Removing temporary .body selectors.
Per the comment, it's been a week. These selectors should be removed.

Change-Id: Ifebb7939596827fc8ade7213f3acf6bf80eebb40
2021-03-24 13:53:48 +01:00
Translation updater bot 2b0141cdef Localisation updates from https://translatewiki.net.
Change-Id: I0535595c34734fac16d428f0a0014bdccd5eb81f
2021-03-24 08:32:09 +01:00
jenkins-bot bd6770014e Merge "Inform anonymous A/B test by tracking time from navigationStart" 2021-03-23 18:29:36 +00:00
jdlrobson b183ac3bf3 Inform anonymous A/B test by tracking time from navigationStart
This will inform us on the approach taken in
I315ea30b88e43f3df29b0a0b37907272ec77d0a7

Additional change:
Flesh out TypeScript with eventLogging interface

Bug:  T275807
Change-Id: I9789cd1dfab5181fa093bce46c5c9b0d338339f5
2021-03-23 10:40:20 -07:00
Translation updater bot 72518acb18 Localisation updates from https://translatewiki.net.
Change-Id: Ifd7c5e1bcfe5b758cee37982de2bb652365fb665
2021-03-23 08:27:26 +01:00
Translation updater bot a425c942a7 Localisation updates from https://translatewiki.net.
Change-Id: I1f23f2b3ad9e2462973cafa2d96791bbeb854178
2021-03-19 08:28:37 +01:00
Translation updater bot 06f82148a9 Localisation updates from https://translatewiki.net.
Change-Id: If1660001e34223a30288451676d1e0e14155cac1
2021-03-17 08:28:30 +01:00
jenkins-bot 991e4b0587 Merge "build: Updating eslint-config-wikimedia to 0.19.0" 2021-03-15 18:47:37 +00:00
jenkins-bot 0954ff6e2a Merge "tests: clean up requirements tests" 2021-03-15 15:43:17 +00:00
Translation updater bot 4a4d390e5e Localisation updates from https://translatewiki.net.
Change-Id: Ibfe7cce1f76dc79a2fd6b4d25c0bb35cf6b6ef80
2021-03-15 08:44:30 +01:00
libraryupgrader f01df6f803 build: Updating eslint-config-wikimedia to 0.19.0
The following rules are failing and were disabled:
* compat/compat

Additional changes:
* eslint: Renamed `wikimedia/client` profile to `client-es5` (T277085).

Change-Id: I12c1a88cef8e2c95bed496628d2fe74d031f8278
2021-03-15 04:57:07 +00:00
libraryupgrader 02c2268716 build: Updating dependencies
composer:
* mediawiki/minus-x: 1.1.0 → 1.1.1

npm:
* prismjs: 1.19.0 → 1.23.0
  * https://npmjs.com/advisories/1638 (CVE-2021-23341)
* elliptic: 6.5.3 → 6.5.4
  * https://npmjs.com/advisories/1648 (CVE-2020-28498)

Change-Id: Ibc3cd2c3772dc89f053a6a695a7717a391c9ee32
2021-03-12 08:32:23 +00:00
Translation updater bot 825c494848 Localisation updates from https://translatewiki.net.
Change-Id: Id8cda8aea8ce293f7b0a23688c260244388c3173
2021-03-11 08:42:31 +01:00
DannyS712 568dbebd47 tests: clean up requirements tests
Convert to unit tests, no integration needed
Use data providers

Change-Id: Ife758952b6bf8a046eddf4bdc478437564f0bc22
2021-03-10 14:45:24 +00:00