Commit graph

5191 commits

Author SHA1 Message Date
jenkins-bot 7dda175aed Merge "Update package-lock, move peer deps into dev deps" 2022-05-12 02:49:10 +00:00
jenkins-bot 3507b366dd Merge "Hide gadget in beta cluster, update reporter" 2022-05-12 01:40:02 +00:00
bwang c9bda9195c Hide gadget in beta cluster, update reporter
Change-Id: I9ee8dcfdac1d73182abf7933d6383518ec16409c
2022-05-11 20:24:59 -05:00
bwang 74f56886cc Update package-lock, move peer deps into dev deps
Change-Id: I4b5fd7f19ce65ea202140bbae8938865229ccea6
2022-05-11 15:08:41 -05:00
jenkins-bot ef42ef7e66 Merge "Create feature flag for VectorTitleAboveTabs feature" 2022-05-11 19:53:11 +00:00
Translation updater bot ec3ea816dc Localisation updates from https://translatewiki.net.
Change-Id: Ic6122536cc8774bea1d3bcc0139c4703b92cfb86
2022-05-11 08:13:34 +02:00
jenkins-bot 8d1dbab356 Merge "Simplify TOC spacing styles/logic by reusing the visible sticky header class" 2022-05-10 22:18:26 +00:00
jenkins-bot 0a596e3f98 Merge "Fix personal tools navigation landmark label" 2022-05-10 17:27:58 +00:00
bwang 2f32d1378c Fix personal tools navigation landmark label
Bug: T291304
Change-Id: I62c24cf739048b794cc33045cbe2333ecb51efdb
2022-05-10 17:12:46 +00:00
Jan Drewniak 29d938b0f9 Create feature flag for VectorTitleAboveTabs feature
Adds a feature called VectorTitleAboveTabs that will be used to
toggle a forthcoming feature that moves the page title above the
tabs (the ones that link to talk/history etc).

Bug: T303549
Change-Id: Ibadb4293eca16a83e5e7a9f90ddcf51fab0a0e41
2022-05-10 12:53:31 -04:00
bwang 91e2e55a10 Simplify TOC spacing styles/logic by reusing the visible sticky header class
- Remove the 'vector-scrolled-below-table-of-contents' class, reducing the number of classes added with JS and simplifying the scrollObserver logic
- Move the 'vector-sticky-header-visible' class from the sticky header element to the body element. Hopefully, this is where other feature specific classes can go in the future
- This approach means the TOC will not need JS to update it's spacing when the sticky header is not enabled

Bug: T307345
Change-Id: I1084defc7025f5c946e22a36d373224fae6f8bd6
2022-05-10 11:39:05 -05:00
Translation updater bot 5f341fbb36 Localisation updates from https://translatewiki.net.
Change-Id: I848204caedb7f1f318ecd575ec64c67d9f057f43
2022-05-10 08:11:22 +02:00
bwang 94be7578f5 Factor out a separate scroll observer for the TOC A/B test, which should be fired separately from the page title observer used by the sticky header and TOC
Bug: T307952
Bug: T307345
Change-Id: I3f247730fa1c399e6d2e4d866677703fc24e8c58
2022-05-09 20:44:54 +00:00
Translation updater bot 24ad8721b1 Localisation updates from https://translatewiki.net.
Change-Id: Idfaead7bfd6d2202cce852d66d286e639a4fa40b
2022-05-09 08:14:01 +02:00
bwang d06dabe897 Ensure main menu is open in a11y tests
Change-Id: Ib1077797a51af216c7fe014a8b1adfe93fefde7a
2022-05-06 14:04:29 -05:00
jenkins-bot b6847038f8 Merge "[HTML] Refactor Content header templates" 2022-05-06 18:43:34 +00:00
Jan Drewniak 1288c97179 [HTML] Refactor Content header templates
Creates two new templates:
- ContentHeader.mustache containing the site header and indicators or languages
- ContentSubheader.mustache containing site tagline and conditionally indicators

This changes DOM order.
- It adds the `<header class="mw-body-header">` to all pages,
  including special pages & edit pages, not just pages with the language button.
- It moves the #siteSub element (tagline) outside of the
  `<div id="bodyContent">` element.
- Adds a clearfix (or margin-collapse fix) to `.vector-body`.

This changes causes a minor difference (perhaps improvement) where on special pages,
the beginning of the content, starting with the `mw-specialpage-summary` element,
was positioned closer to the page title than on regular pages.

The clearfix ensures that the height between the page title and content is consistent across all pages.

Bug: T303549
Change-Id: I29ba337dbd6f9b0cf58c9a0ca517a9ba59cef414
2022-05-06 15:37:04 +00:00
Translation updater bot dba3050645 Localisation updates from https://translatewiki.net.
Change-Id: Ida7254c9506a331a51d15d98a10b71b852ae1802
2022-05-06 08:21:25 +02:00
jenkins-bot b614616581 Merge "[Grid preparation] ArticleToolbar component" 2022-05-05 22:45:24 +00:00
jenkins-bot 1c723f581c Merge "Update reporter to include screenshot, remove try statement to ensure CI fails when an error occurs" 2022-05-05 22:00:21 +00:00
Jon Robson 305fbdacf8 [Grid preparation] ArticleToolbar component
Structural change to prepare for CSS grid usage.
ArticleToolbar component is defined and self contained with
all layout rules relating to toolbar

UI regression testing suite shows 6 failures due to pixel alignment
changes to tabs. When comparing to the current release, you should
see 34 failures before /and/ after this change.

Notable changes:
- #mw-head element is no longer present in modern Vector skin
to allow us to distinguish between cached HTML and modern HTML

Bug: T303484
Change-Id: Ia261ea53931217f32a21b33c2ab3d4ec64efa48a
2022-05-05 21:13:01 +00:00
Jon Robson 9a2b3d6275 [Grid preparation] Structure the header
Restructure the header to have two child elements

Change-Id: Ib5b7f31419ae6b62f62878947651b8ab843a3955
2022-05-05 17:54:28 +00:00
bwang 6b814da689 Update reporter to include screenshot, remove try statement to ensure CI fails when an error occurs
Change-Id: I685c8a74352b4172d7a086467a9b3cfc84d57cee
2022-05-05 12:35:29 -05:00
jenkins-bot 2f25970dae Merge "Change "Article tools" to "Tools"" 2022-05-05 17:26:58 +00:00
jenkins-bot cdd144f928 Merge "a11y: create report in LOG_DIR or 'a11y/'" 2022-05-05 17:05:29 +00:00
Željko Filipin 09fe15e939 a11y: create report in LOG_DIR or 'a11y/'
If LOG_DIR environment variable is set, create report there.
If it is not set, create the report in 'a11y/'.

Bug: T301184
Change-Id: I74fa6e8ee59d43e5a6e57083999107ac27446a62
2022-05-05 11:46:13 -05:00
jenkins-bot 17bb448244 Merge "Disable max width on article toolbar container" 2022-05-05 16:14:25 +00:00
Amir E. Aharoni 4af78713ef Change "Article tools" to "Tools"
"Article" is a Wikipedia-specific term.

See https://phabricator.wikimedia.org/T291304#7905753

Bug: T291304
Change-Id: I678e7bed8c32dee35c7047e3ae5bb1ec5d26f452
2022-05-05 10:20:29 +00:00
Translation updater bot db60481d2b Localisation updates from https://translatewiki.net.
Change-Id: I982c2c6eddf423c3134980de00e7c29fcb02ae1e
2022-05-05 08:08:09 +02:00
Jon Robson 3b4b101459 Disable max width on article toolbar container
Bug: T306353
Change-Id: I1c9e223ebc22cf0e0a337856041f34449e6c483b
2022-05-05 02:21:17 +00:00
bwang cdc46e70da Fix TOC fadeout placement
Bug: T306893
Change-Id: Ib6fa8836948b6d6f202eb5365ae660acf210b473
2022-05-04 23:37:43 +00:00
jenkins-bot 3373d065c7 Merge "Fix Sidebar.less auto merge commit" 2022-05-04 20:19:12 +00:00
jenkins-bot a68409d262 Merge "[TOC] Remove pointer-events:none on .sidebar-toc-link" 2022-05-04 19:38:32 +00:00
bwang 6cc98aa449 Fix Sidebar.less auto merge commit
Auto merge commit for the 'Adjust table of contents margins at 1000-1200 breakpoint' patch incorrectly deleted a line from Sidebar.less. I need that deletion in 789210, because it will be backported later today
https://phabricator.wikimedia.org/F35103224

Change-Id: I0404c02d71160ec4537e49fc77489a8a5027a183
2022-05-04 17:05:42 +00:00
jenkins-bot 8a2f61ee02 Merge "Adjust table of contents margins at 1000-1200 breakpoint" 2022-05-04 16:49:53 +00:00
Jon Robson 9c26833af6 Adjust table of contents margins at 1000-1200 breakpoint
Bug: T307004
Change-Id: Ibb7be459305eaee57503d4efd67e19cd0f00046b
2022-05-04 16:04:33 +00:00
Željko Filipin f601fe480e a11y: create report in log folder
The report was created in log/a11y folder until now. Looks like Jenkins
expects it to be in log folder.

Bug: T301184
Change-Id: I9926e7446e4fc86526dab963066511bf8da2271e
2022-05-04 16:36:57 +02:00
Translation updater bot 7861e9b8f1 Localisation updates from https://translatewiki.net.
Change-Id: Ifa0a2d0a45e181320e3718da0a72c93ad7464067
2022-05-04 08:20:15 +02:00
bwang 0b27b29475 Hide navigation menu label and remove legacy sidebar styles from modern styles
Change-Id: I701860ce0bf5f34c8318a999cddd7eede94aee3a
2022-05-03 16:50:58 -05:00
jenkins-bot ff3d879ee2 Merge "Remove nav element from Vector menus and only render label elements in Vector menus when needed. Add new nav landmarks corresponding to user links, main site nav, and article editing tools. Split out legacy Menu template." 2022-05-03 15:42:02 +00:00
Translation updater bot d33a1a0fa3 Localisation updates from https://translatewiki.net.
Change-Id: Iea125ed24698ee1d6853f2b55842721ae406efb6
2022-05-03 08:47:15 +02:00
jenkins-bot 5fc5bb4ad2 Merge "On special page do not show empty more menu to low resolutions" 2022-05-02 21:25:22 +00:00
Jon Robson a1e5fd5fcc On special page do not show empty more menu to low resolutions
This is a follow up to I34ace0aeb3e23d8f6a8c5a8680bb492f37e343ad
On Special:Userlogin a "more" menu appears that's visible but empty
that should not

 Bug: T306229
Change-Id: I9384b3015de9991db41bde8ccc8f404ac533f198
2022-05-02 20:22:44 +00:00
Jan Drewniak 7e81c26712 [TOC] Remove pointer-events:none on .sidebar-toc-link
Previously, we relied on setting pointer-events:none on all child
elements of ToC links.

This propagated the click event up to the link itself in Javascript
and allowed us check if an element with the class `.sidebar-toc-link`
was clicked.

Unfortunately as of Chromium 101 this approach causes the entire link
in the sidebar to be unclickable.

Instead, this patch checks if the ToC link or any of it's children
have been clicked (using the less efficient `Element.closest()` ).

Bug: T307271
Change-Id: I2264b7862f6e1ef50c5c722daee81acc39eea54e
2022-05-02 19:48:30 +00:00
Translation updater bot 4a23431c58 Localisation updates from https://translatewiki.net.
Change-Id: I680e6186a20d348dd39ca39dbec90518fa46bf01
2022-05-02 08:22:28 +02:00
Translation updater bot 235c0872a6 Localisation updates from https://translatewiki.net.
Change-Id: I49bbd02b6087e31f7ea9cfb8652d0f666d06f524
2022-04-29 08:47:04 +02:00
jenkins-bot 3d36fac0ef Merge "Updates for core temp user autocreation feature" 2022-04-28 20:53:35 +00:00
jenkins-bot a5e54669a7 Merge "Fix a11y test runner setup issue" 2022-04-28 20:52:09 +00:00
Tim Starling 8d0659b1e6 Updates for core temp user autocreation feature
* Use pt-tmpuserpage for the temp user name.
* Use the userAnonymous icon for the temp user personal tools menu.
* Suppress the logout menu item for temp users.

Depends-On: Ib14a352490fc42039106523118e8d021844e3dfb
Bug: T300263
Change-Id: I8ac5de82f76a9ec58b0fbef85546bc7fd5b793d2
2022-04-28 20:32:53 +00:00
bwang 1d46d78ced Disable TOC in edit mode
Bug: T307112
Change-Id: Ic7bf195972d3f5bfe781a15fc805d7ef1b56e496
2022-04-28 20:09:05 +00:00