wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-12-21 12:12:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
5191 commits 15 branches 21 tags 97 MiB
Commit graph

5191 commits

This branch
This branch
All branches
Author SHA1 Message Date
Jon Robson 3dbadabdfe Document the importance of vector-menu class 
It's used by click tracking so marking with inline comment that
we need to be careful if we plan to remove it in our current
refactoring.

Change-Id: I6aee01363d2d150844e61fb27ab584c8ee78c4ae
 2023-01-03 14:45:40 -08:00
Translation updater bot e1639d0672 Localisation updates from https://translatewiki.net. 
Change-Id: Id15bffe0feb7a07b4aa014e5c9a66fdb3862890d
 2023-01-03 07:56:35 +00:00
Translation updater bot 9c06e44283 Localisation updates from https://translatewiki.net. 
Change-Id: I1a97bce69edce84c3a8140197c6f0b17c33904d5
 2023-01-02 08:47:17 +01:00
Translation updater bot 36b823a91a Localisation updates from https://translatewiki.net. 
Change-Id: I8f91306c4ff22de8dd42aa8e171765eca6e1cf1f
 2022-12-29 10:05:50 +01:00
Translation updater bot feec1e514e Localisation updates from https://translatewiki.net. 
Change-Id: Ia03fbc3dbb9bccab0493955f021f6bcf2e9254eb
 2022-12-26 09:13:55 +01:00
Dreamy Jazz 9d265af32f Test ServiceWiring.php 
Test ServiceWiring.php using tests copied from CentralAuth. Because
phpunit does not support marking a file as covered, the file is
marked as ignored for code coverage. However, these tests do not
fully cover the single service as these tests only verify that the
call to the service does not result in an error.

Change-Id: I6100d242aa61975cab7c44b35616cb2b19762cbf
 2022-12-24 01:07:25 +00:00
Translation updater bot e6d20f7fdb Localisation updates from https://translatewiki.net. 
Change-Id: I0fa851362bc8ca22280f11526da29834d80dcd54
 2022-12-23 09:11:00 +01:00
jenkins-bot 8052762455 Merge "Fix page title from overflowing" 2022-12-23 04:53:12 +00:00
Bartosz Dziewoński e076351311 Work around browser inconsistencies with 'clear' + 'margin-top' 
No visual changes expected.

Bug: T325391
Change-Id: I20c5aa5d0a2018f32dff6948cd210fecc7ba760f
 2022-12-22 16:26:19 +01:00
Translation updater bot bb402a4fb4 Localisation updates from https://translatewiki.net. 
Change-Id: Id04fc4ec11ec2e0ddc38e60ceabc6a899a91b8a2
 2022-12-22 11:08:13 +01:00
jenkins-bot a77229e2ee Merge "Update header spacing to match spec" 2022-12-21 20:31:54 +00:00
Translation updater bot 19abc50ee0 Localisation updates from https://translatewiki.net. 
Change-Id: I2e9c9d6ab13a03737c6c6da705841cb8d56f4dd5
 2022-12-21 09:22:34 +01:00
bwang 7f2118e756 Update header spacing to match spec 
Bug: T324877
Change-Id: I47be192f5ba726904dc225afd54ee9112e97dc10
 2022-12-20 17:58:54 -06:00
jenkins-bot ac2fc83112 Merge "Add generic classes to pinnable container" 2022-12-20 23:46:11 +00:00
bwang a348db9969 Add generic classes to pinnable container 
Bug: T324877
Change-Id: Iab94f9f600f8e6d032ad70d6b8e502686977441c
 2022-12-20 17:22:11 -06:00
jenkins-bot 7eb6d886be Merge "Fix missing TOC scrollable indicator" 2022-12-20 21:49:44 +00:00
jenkins-bot bcd382648b Merge "Clean up cached HTML code" 2022-12-20 18:04:25 +00:00
bwang a50654309d Clean up cached HTML code 
Follow-up: I59b3acd3d56cd5761e5978607634dfb9a88f60e3
Bug: T317900
Change-Id: Idfbd77c6b84c0c8541a81effc272f4f36f17b823
 2022-12-20 17:42:21 +00:00
Translation updater bot 4af3405618 Localisation updates from https://translatewiki.net. 
Change-Id: Id0ce700bda0422e685b8ebbfa04f617945f38aea
 2022-12-20 09:32:33 +01:00
Lectrician1 34b822196b Fix page title from overflowing 
Bug: T319052
Change-Id: Iab97354b4d1001d718c66d7e4ace8edc9801a775
 2022-12-20 03:32:25 +00:00
Translation updater bot 6b784bf5af Localisation updates from https://translatewiki.net. 
Change-Id: I45c27deded66ef298612517ad5db5e6723c8e98f
 2022-12-19 09:06:53 +01:00
bwang e585211336 Fix missing TOC scrollable indicator 
Introduced in Iea0d73005b91589c58ae38a3a640fa90c18a860d on Dec 5

Bug: T325388
Change-Id: I03f6d991492cbbdcfda63ed5a617cf26c691635f
 2022-12-16 13:39:13 -06:00
bwang 6c817e932f Use features.js for main menu pinning functionality 
- Register new feature for main menu pinned
- Update UserPreferenceRequirement to optionally handle default config values
- Add nav landmarks for the main menu

Bug: T317900
Change-Id: I8fc6e0a79a1155d68afb9e33e5101a2a160dc4e5
 2022-12-16 12:56:54 -06:00
bwang 46f17487fd Update main menu templates and classes to be consistent with other pinnable elements 
- Rename data-portlets-main-menu to data-main-menu
- Rename MainMenuContents.mustache to MainMenu
- Replace usage of .vector-main-menu-contents in favor of .vector-main-menu
- Add classes to PinnableContainer
- Use PinnableContainer and PinnableElement in main menu
- Remove MainMenuDropdown.less

Bug: T317900
Change-Id: I59b3acd3d56cd5761e5978607634dfb9a88f60e3
 2022-12-16 17:34:23 +00:00
Translation updater bot 6d894c2fb8 Localisation updates from https://translatewiki.net. 
Change-Id: I28a03ab51c29e8bd3a9afc3112ba24d97e7b888c
 2022-12-16 08:49:12 +01:00
jenkins-bot 41116ede40 Merge "Mark active sections even when their headings are in wrapper elements" 2022-12-16 00:36:12 +00:00
jenkins-bot 5c7a3d46fd Merge "Remove extraneous $isRegistered variable and VectorServices::getFeatureManager call" 2022-12-16 00:19:00 +00:00
Nicholas Ray c152db2cbe Remove extraneous $isRegistered variable and VectorServices::getFeatureManager call 
Some follow-up cleanup from 867701

Change-Id: I93d50c15b572b78a4861a8e4347d706fd2e4c04d
 2022-12-15 15:56:53 -07:00
bwang 9abdaf54c3 Remove -pinnable-element postfix from PinnableElement.mustache 
This allows '.vector-main-menu' to correspond to MainMenu.mustache, and 'vector-page-tools' with PageTools.mustache

Bug: T317900
Change-Id: I65c0d7cffbdf1cf9e59cde0c0fc4dca788e799de
 2022-12-15 22:46:51 +00:00
bwang 3ad3d70745 Rename VectorComponentPinnedContainer to VectorComponentPinnableContainer to match template files 
Bug: T317900
Change-Id: I557fbef46fd1ea5984ded7f1a067cc43656e7076
 2022-12-15 22:46:46 +00:00
jenkins-bot 9463861054 Merge "Refactor page tools, main menu, and TOC components" 2022-12-15 22:44:05 +00:00
jenkins-bot ebdea1b0df Merge "Clean up cached .vector-menu-portal code" 2022-12-15 22:30:30 +00:00
bwang 97de09dcba Refactor page tools, main menu, and TOC components 
- getTocData is moved into VectorComponentTableOfContents and it's test file
The following changes were made to the main menu, toc and page tools PHP components
- Avoid passing in $skin to the constructor
- Handle isPinned logic inside the component
- Add a public ID constant to the components
- Dropdown data for each feature use the same naming convention

Bug: T317900
Change-Id: I77a617a6c1d93bccd3b6e59353299f5534624e53
 2022-12-15 14:23:25 -08:00
bwang f006e00677 Clean up cached .vector-menu-portal code 
Follow up to I884cd33938b2670bddc90f698d8f61f37c6c29d4

Change-Id: Icd329aa4a43aa738b0127f7147b5401e07d90c05
 2022-12-15 14:30:58 -06:00
Translation updater bot 094acdf347 Localisation updates from https://translatewiki.net. 
Change-Id: I43ad9141e14e1db164d269c5d5a4bfd9e81f9e48
 2022-12-15 11:39:30 +01:00
jenkins-bot be98832afb Merge "Add comment to pinnableElement isPinned method" 2022-12-15 00:11:44 +00:00
jenkins-bot 89b3879bc5 Merge "Move toolbox and menus that follow into page tools" 2022-12-14 23:39:56 +00:00
jenkins-bot bfc7856488 Merge "Make h2 use explicit font for ckb on Linux to avoid broken ligatures" 2022-12-14 23:05:34 +00:00
Nicholas Ray a8aeb62a93 Add comment to pinnableElement isPinned method 
Follow-up from the review of 856718 which requested a comment be added to the
isPinned method pointing to future plans with TOC.

[1] https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/856718/28..38/resources/skins.vector.es6/pinnableElement.js#53

Change-Id: I899b6741e2407fe66aaaba8617974a9d58237ee6
 2022-12-14 15:19:16 -07:00
Nicholas Ray a25dba2a19 Move toolbox and menus that follow into page tools 
Uses all of the changes from Jon's patch in 866503 to move all of the sidebar
menus after and including the tools menu into the page tools component. The rest
of the menus remain in the main menu.

Additionally:

* Per T317898#8468437, the "Tools" label should be "General". It was also
assumed from the prototype that the "More" label should become "Actions"

Bug: T317898
Change-Id: Ic9c1586febd8ebfff4a17285e6bd59cee509bd34
 2022-12-14 13:38:13 -07:00
Translation updater bot 1323b82aa3 Localisation updates from https://translatewiki.net. 
Change-Id: I64d81ace7b7bffe0a19dd2ba36daa805c6b30629
 2022-12-14 08:18:04 +01:00
Bartosz Dziewoński f6c85143c6 Mark active sections even when their headings are in wrapper elements 
This partially reverts 94c7f31082.
Headings inside wrapper divs etc. actually are rendered in the table
of contents.

Bug: T318044
Bug: T324869
Change-Id: Ie3181d9e9605cd2b5897b12931572057e80d6661
 2022-12-13 23:17:57 +01:00
Jon Robson 85d75f1e7c Don't add empty table of contents to page 
Follow up to I0a740f8543831e266f2b1b874b40e44c8241d4cb

Bug: T317900
Change-Id: I1b63b5bd8e0f9f31fc7acd01665bf92061a45fd8
 2022-12-13 14:01:34 -08:00
jenkins-bot f597c53f74 Merge "Components: MainMenu and Pagetools use VectorComponentMenu" 2022-12-13 18:18:05 +00:00
jenkins-bot 2111e91253 Merge "Refactor: PageTools composes several different components" 2022-12-13 18:17:32 +00:00
Translation updater bot f89d05ee5b Localisation updates from https://translatewiki.net. 
Change-Id: I2e5cbb98204854e3d68593ab5ed62ed5fcd01a73
 2022-12-13 08:19:09 +01:00
Jon Robson 77aa8e0cbd Components: MainMenu and Pagetools use VectorComponentMenu 
Bug: T317900
Change-Id: Ic91a638a3d90f5533dc624870bbefbff2950767d
 2022-12-12 22:17:29 +00:00
Jon Robson c10ef66e6e Refactor: PageTools composes several different components 
* Introduce Dropdownmenu, PinnableElement and PinnedContainer components

Additional changes:
* Drops unused has-multiple-menus
* Update TableOfContents to use PinnedContainer and PinnableElement

Bug: T317900
Change-Id: I0a740f8543831e266f2b1b874b40e44c8241d4cb
 2022-12-12 22:17:24 +00:00
jenkins-bot e7cd7df568 Merge "Clean up code handling cached HTML for 3 patches" 2022-12-12 22:02:01 +00:00
jenkins-bot 514fb7fd70 Merge "Templates: Reorganize pinned containers" 2022-12-12 18:19:31 +00:00