Commit graph

4968 commits

Author SHA1 Message Date
ksarabia 515af497db Remove typography survey
* Removes code related to typography survey

Bug: T349337
Change-Id: Iae871ec0c61d630078108a5710705b4d3d118a54
2023-12-05 14:32:00 -06:00
bwang badd229bab Fix nonzebra sticky container scrolling behavior and scrollable indicator
- Remove unnecessary CSS from old grid styles
- Consolidate scrollable indicator styles, delete old styles

Bug: T352464
Change-Id: Id33e6d99dba2c680f02b246bbccf26a2aa7e77d9
2023-12-05 19:32:36 +00:00
jenkins-bot a9f7b251fd Merge "[Zebra] Update to 483c6bb Align sidebar TOC with main menu" 2023-12-05 17:00:16 +00:00
bwang 300028a42e [Zebra] Update to 483c6bb Align sidebar TOC with main menu
- Vertically aligns the sidebar TOC
and main-menu text, update after sticky-pinned
container was split into separate elements.
- Consolidate position: sticky and contain: paint styles onto sticky-pinned-container elements

47 expectecd visual changes to desktop-dev

Bug: T351697
Change-Id: I76b3e875f5793d3442e84215447a0ab9fa818300
2023-12-05 16:39:49 +00:00
Translation updater bot 09f065a429 Localisation updates from https://translatewiki.net.
Change-Id: I568a29b3766637abb2ad8ac15795a8957e680441
2023-12-05 09:18:43 +01:00
bwang 5331dfb7f6 Deploy VectorClientPreferences to beta
Bug: T351339
Depends-On: I459bacac64286a05ea434dd272033981030098b1
Change-Id: Ia20c824d114b043a47bee51f58c3f8752ef4b672
2023-12-04 23:43:37 +00:00
Moh'd Khier Abualruz 2384a32323 [Zebra] Make .vector-column-start cache compatible
preparing html and css to avoid caching issues
caused by differences between zebra and non-zebra HTML.

Bug: T347712
Bug: T351830
Change-Id: I6f8ae635ba38937729b77ea8517ef2eae0ae12f7
2023-12-04 14:29:06 -06:00
Translation updater bot 473262e431 Localisation updates from https://translatewiki.net.
Change-Id: I7031d68284be745494e6604120c893d8a301179a
2023-12-04 09:09:11 +01:00
jenkins-bot a0deea2158 Merge "Put font size control before limited width control" 2023-12-01 17:42:15 +00:00
Jon Robson 65908e0c7d Put font size control before limited width control
Bug: T351867
Change-Id: Ieab31c875ab87d3ffc103805e3012089ab118a28
2023-12-01 09:19:51 -08:00
Translation updater bot ed352efe8d Localisation updates from https://translatewiki.net.
Change-Id: Ib2efe042f644e7318e5da24c96c6cdb0e5aa617b
2023-12-01 09:44:30 +01:00
Jan Drewniak 531cbcbd25 Increase "large" font-size option for client-preferences
Increases "large" font-size option from
@font-size-large (18px equivalent) to
@font-size-x-large (20px equivalent)

Bug: T351693
Change-Id: I9e3dd8346b1d6f6a9efd04bb1e43fee9bfd79154
2023-11-30 12:57:37 -05:00
Translation updater bot e73017b3b6 Localisation updates from https://translatewiki.net.
Change-Id: I55b3c8f6f967a5dd7f6bc4d3d24d2957be3b36ff
2023-11-30 09:41:18 +01:00
bwang e7ebeec623 Fix incorrect client-pref-pinned classes when client pref feature is disabled
Bug: T351141
Bug: T352257
Change-Id: I2d527ee9a943feabb8c8ea26fd1078fd3721f625
2023-11-29 20:14:49 +00:00
gerritbot 51a0275250 Update UserOptionsManager's FQN
User-options related classes are being moved to
the MediaWiki\User\Options namespace in MediaWiki Core;
reflect that change here.

Bug: T352284
Depends-On: I9822eb1553870b876d0b8a927e4e86c27d83bd52
Change-Id: Ie1ab46338a660686394c79f49f21e6c1e0fa4a0a
2023-11-29 14:39:54 +00:00
gerritbot febf3e635e Update UserOptionsLookup's FQN
User-options related classes are being moved to the MediaWiki\User\Options namespace in MediaWiki Core; reflect that change here.

Bug: T352284
Depends-On: I9822eb1553870b876d0b8a927e4e86c27d83bd52
Change-Id: I084e01a29884f338fae22d7239d068823a2657c3
2023-11-29 12:42:02 +00:00
Translation updater bot 50ae71e660 Localisation updates from https://translatewiki.net.
Change-Id: I984415a0b346445c69f1ef42d02bc41f52cdc7a2
2023-11-29 08:33:40 +01:00
jenkins-bot 35a616368b Merge "Add styles for new heading HTML" 2023-11-28 22:42:11 +00:00
Jon Robson 15250424b3 Fixes: Duplicate events for radio buttons
Bug: T352075
Change-Id: I9cec0b23618162ba74ccd9cd2e27e9171cdc8d6e
2023-11-28 10:09:06 -08:00
jenkins-bot 991419e877 Merge "Adjust .vector-body paragraph margins" 2023-11-27 23:04:03 +00:00
jenkins-bot f647138f9a Merge "i18n: Update copy" 2023-11-27 20:07:00 +00:00
Jan Drewniak 522d655007 Adjust .vector-body paragraph margins
Adds bigger bottom margin (1em) while keeping
the smaller top margin (0.5em) as was previously define.

This keeps the headings close to the paragraphs
while seperating paragraphs from each other.

Bug: T351754
Change-Id: I833372002654ea30deb110af44fb412722bc0ccd
2023-11-27 14:50:03 -05:00
Jon Robson 1c2dff5690 i18n: Update copy
* Switch from "has been" to "has"
* Reorder limited width options
* Change headings
* Change options
* Change copy of beta feature

Bug: T351998
Bug: T351867
Change-Id: I65494a3cc75b661339e48df1bea0e09a365c0657
2023-11-27 11:21:55 -08:00
jenkins-bot e55034f3ad Merge "Fix misc client pref bugs" 2023-11-27 18:07:10 +00:00
jenkins-bot e75b2cda57 Merge "Fix sticky styles for pinnable elements by moving sticky styles into separate vector-sticky-pinned-container element" 2023-11-27 17:56:07 +00:00
bwang a304223f04 Fix misc client pref bugs
- fixes unpinned popup message not showing
- fixes radio button spacing in client pref dropdown in Zebra

Bug: T351141
Change-Id: Ieeb5caaa6ccbd83d28dae41d3ca30791c355fcc6
2023-11-27 11:40:53 -06:00
bwang b23f6f6722 Fix sticky styles for pinnable elements by moving sticky styles into separate vector-sticky-pinned-container element
Cached HTML change

Bug: T351141
Change-Id: I7d2b4417db15aad7ea788ac7adf131de2c702d27
2023-11-27 17:09:26 +00:00
jenkins-bot 1673d3522d Merge "Implement new font-sizes for custom front-size preference" 2023-11-27 08:08:40 +00:00
Translation updater bot fd4a7edac7 Localisation updates from https://translatewiki.net.
Change-Id: I7c6f072afaec2bae7774fc9d271ed08a026a39ca
2023-11-27 08:35:59 +01:00
Jan Drewniak edfdf05f12 Implement new font-sizes for custom front-size preference
Adds different font-sizes and line-heights for the custom
font-size UI. The custom font-size preference options are now:

1. Compact - 14px font-size & 22px line-height
2. Standard - 16px font-size & 24px line-height
3. Open - 20px font-size & 26px line-height

This removes the "xl" font-size option
(`vector-feature-custom-font-size-3`) and it's related i18n messages,
and changes the remaining message to match the new options.

The default font-size, when the custom font-size feature is disabled,
is "compact".

Bug: T351693
Change-Id: I5975a78ce7327f314fd55de55c222ac08d801fbd
2023-11-24 15:23:56 +00:00
Moh'd Khier Abualruz e480bfa2b5 Update theme icon for client preferences in user links
- Add appearance.svg file and classes
- Update the icon name in php
- Update icon name in test data and Snapshot

To test: change return value of
  isClientPreferencesPinned() from SkinVector22
  PHP Class to false

Bug: T351142
Change-Id: If61f3019430be3cb9c926b09bc397e27d8e636f2
2023-11-24 15:01:35 +00:00
jenkins-bot 9062e6f96e Merge "Follow-up to 7a8059d76 - Vector increase paragraph spacing to 1em" 2023-11-23 23:35:02 +00:00
jenkins-bot f26a8a0556 Merge "Revert "Vector increase paragraph spacing to 1em"" 2023-11-23 23:27:37 +00:00
Jan Drewniak 78f1f1c671 Follow-up to 7a8059d76 - Vector increase paragraph spacing to 1em
This patch changes the paragraph spacing for Vector 2022
instead of legacy Vector.

Bug: T351754
Change-Id: If205abd17236f9e325cb477b589fa35da246d623
2023-11-23 18:16:00 -05:00
Jdrewniak c3b10b4cac Revert "Vector increase paragraph spacing to 1em"
This reverts commit 7a8059d767.

Reason for revert: Didn't realize this changes the paragraph spacing in the legacy styles module instead of the Vector 2022 module.

Change-Id: I08f2a6b1f43fc088e6552fb6a9011b41ebb698a2
2023-11-23 23:09:03 +00:00
jenkins-bot a4ed8727cb Merge "Vector increase paragraph spacing to 1em" 2023-11-23 16:47:20 +00:00
jenkins-bot 37c2a0016f Merge "Make client prefs fully pinnable" 2023-11-23 16:34:33 +00:00
Translation updater bot 3e4cc22bec Localisation updates from https://translatewiki.net.
Change-Id: I0663354ddf899f244c772808793a608f28884cd8
2023-11-23 12:00:57 +01:00
Moh'd Khier Abualruz 7a8059d767 Vector increase paragraph spacing to 1em
.vector-body p now should have top and bottom margins as 1em instead of 0.5em which translate now to 14px instead of 7px

Bug: T351754
Change-Id: Ifd405d7754f9062d9a84237560495a36d1dab8e9
2023-11-23 11:28:06 +01:00
bwang d2b413a721 Make client prefs fully pinnable
Bug: T351141
Change-Id: Ic4a166fb3234b27dbf3d37891abfdf15781c8867
2023-11-22 14:39:28 -06:00
jenkins-bot 84ce8cdd41 Merge "Fix the toc header underline" 2023-11-22 18:44:26 +00:00
Piotr Miazga d6945f5f46 Skin shouldn't call SkinMustache::getTemplateData twice
Calling this method twice within the same function introduces
uncessary performance decline.

Bug: T351807
Change-Id: I5a28f2a3884ea22a6e0bba666f73bd8596ccafbe
2023-11-22 14:11:14 +01:00
Translation updater bot 98651517b9 Localisation updates from https://translatewiki.net.
Change-Id: I02ec5b825443f832514b59288f7bc3130b9435d3
2023-11-22 08:22:20 +01:00
Jan Drewniak 791b9bb0d5 [Zebra] Vertically align sidebar menus
Removes padding from the top and bottom of the
.mw-body element so that the border of the sidebar
menus align with border of the tab area.

Also removes the bottom margin on the sidebar menus
so that the bottom of the menus align with the bottom
of the content. (This was an artifact from the gray
background design).

**Visual Changes**
- The content will move up by 8px with this change.
- The bottom of the TOC will also move down by 24px
  to align with the content.

Bug: T351432
Change-Id: If0a8189b228ffb6fb63dfd8be40955653caa0b34
2023-11-21 18:59:15 +00:00
bwang b74b45d65d Fix the toc header underline
Bug: T340481
Change-Id: Iefbaae291c091b51910180c619993843895c9a20
2023-11-21 17:35:40 +00:00
jenkins-bot b64b137223 Merge "[Zebra] Align sidebar TOC with main menu" 2023-11-21 17:10:20 +00:00
jenkins-bot 76a81c6d10 Merge "Tweak OOUI dialog compatibility styles for better compatibility" 2023-11-21 17:10:12 +00:00
Jan Drewniak 483c6bb51f [Zebra] Align sidebar TOC with main menu
Aligns the text of the sidebar TOC with the
main menu using negative margins. This only
affects the TOC in the sidebar position.

Bug: T351697
Change-Id: Ie4e78379e8682636ebf72913e995b69e922b4983
2023-11-21 16:02:10 +00:00
Translation updater bot 4eaff59bdb Localisation updates from https://translatewiki.net.
Change-Id: Ia14c7d4cadc25c7627d51cb4a9e005debc6defb0
2023-11-21 08:31:12 +01:00
Jon Robson 845a0ab71d Make the limited width and font size controls work for logged in users
For time being manage classes inside Vector. Document with FIXME and a
test.

Bug: T351447
Change-Id: Icc084a59a0141ec2b7c772cf92e8cc58c11f15b1
2023-11-21 02:16:52 +00:00