Commit graph

9 commits

Author SHA1 Message Date
Jon Robson 9d054339db PerformanceBudget: Remove FlaggedRevisions workaround
With I1e45d0dacf58b2e03886d3b986309e13e754e324 this should no
longer be needed as the styles are now restricted to reviewers and
the default user is not a reviewer

After merging this change, please confirm that any open
FlaggedRevisions patches pass Jenkins CI.

Change-Id: I53e3f2c15ad6797f39747e5bc00039582edb8f61
2023-11-14 17:25:56 +00:00
Moh'd Khier Abualruz 9f35fd8d56 Vector PerformanceBudgetTest::testTotalModulesSize CI break
- Account for 10 Kbs in the case wikibase is enabled for scripts budget
- Message generation centralised function
- Added bundlesize.config.json file path to message.
- Update the message to show in Kbs

Bug: T350338
Change-Id: I8490cd7aa4468b54bab05960c8c594093167cb72
2023-11-07 17:15:59 +00:00
Leszek Manicki 72ec5037cf Skip PerformanceBudgetTest::testTotalModulesSize
The tests breaks CI for multiple extensions.

Bug: T350338
Change-Id: Id4879c3a8f53f7e59b9c04bfae3af11fe42a307c
2023-11-07 10:12:44 +01:00
Jon Robson b7dcd8ffa8 Restore test and increase budget with debug information
*. Current budget didn't take into account:
** RelatedArticles
** FlaggedRevisions
** VisualEditor
* Vector legacy budget is set to Vector 2022 to ensure both skins
have similar performance demands.
* Adds workaround for T350514

Bug: T346813
Bug: T350338
Change-Id: I3377bec5e1c368d30e77e22e93b2e44bbfe883bd
2023-11-03 21:27:39 +00:00
Moh'd Khier Abualruz bcc71fc459 Performance budget Test message update
Followup to Id5c28ecec20c4a74a113dd8781b6a022391ae443

- Make the message more readable

Bug: T350292
Change-Id: I299bcca61b8df30024ad70c17ca33bf0f6c322fe
2023-11-03 13:35:38 +01:00
jenkins-bot cb9bf63924 Merge "PerformanceBudgetTest: Use existing title" 2023-11-02 11:56:01 +00:00
Jon Robson dcf343e1c7 PerformanceBudgetTest: Use existing title
Follow up to Id5c28ecec20c4a74a113dd8781b6a022391ae443
Certain modules may only load if a page exists, so using an existing
title may catch more issues in CI.

Bug: T346813
Change-Id: I399f97720702c038ade6394f0193c27feb4a3bc8
2023-11-02 11:53:02 +01:00
Gergő Tisza 160fc79bc1
Skip PerformanceBudgetTest::testTotalModulesSize
Broke CI.

Follows up Id5c28ecec20c4a74a113dd8781b6a022391ae443.

Bug: T350338
Change-Id: Ief89f9dbc10b51d4eab238484e3b7f546c40c769
2023-11-01 22:03:00 -07:00
Moh'd Khier Abualruz 20b9d04b2f Performance budget's should consider modules added by hooks
- Add ModulesSizeTest.php that checks the total loaded scripts and styles budget sizes and checks if they exceed the budgets assigned in bundlesize.config.json.
- Changed the json structure of bundlesize.config.json to support both ModulesSizeTest.php and BundleSizeTest.php.
- Handled the new data structure in the BundleSizeTest.php so the dataProvider gets proper data.

Bug: T346813
Change-Id: Id5c28ecec20c4a74a113dd8781b6a022391ae443
2023-11-01 20:50:48 +00:00