wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-14 19:26:42 +00:00
Code Issues Packages Projects Releases Wiki Activity
4054 commits 239 branches 5 tags 93 MiB
Commit graph

11 commits

Author SHA1 Message Date
bwang fca03c873b Update user links dropdown id 
- Update naming convention to use dropdown instead of menu

Follow-up: Iac0586893fec26a8a6c2c904ce08fbf1e19b339c
Change-Id: Ie51f7fc280eeef8470613c07850dad83e4435ee8
 2023-02-16 11:21:56 -06:00
Jon Robson 0c0ce631ee Components: Model table of contents in title bar. 
Bug: T320927
Change-Id: Icd871e1bdf4ab0c7aa5b906b913416f4b1747750
 2023-01-11 15:42:23 -08:00
bwang cb64e8f7ba Use PinnableHeader in the TOC all the time 
[Visual Changes in this patch]
This patch introduces changes to whitespace inside the Mustache template
which corresponds to an HTML change, resulting
33 minor changes in pixel, the spacing of the ToC label shifts by
1 pixel

- Remove page tools feature flag from TOC
- Remove usage of .vector-toc-collapsed and .vector-toc-not-collapsed
- Remove now unused `moveToc()`
- Update jest tests to use PinnableHeader

Bug: T318013
Change-Id: I82f23e69b0249c844af9e45fec342217a0755893
 2022-11-30 01:09:43 +00:00
bwang 0f7411bdf2 Update TOC to use PinnableHeader 
- Update 'collapsed' naming convention to 'pinned'
- Introduce VectorComponentPinnableHeader

Bug: T317897
Change-Id: I752eadc9bf54d58c799060a9eaefa0b125dd7952
 2022-11-15 16:37:50 -06:00
Jon Robson c9cdaadb5e [Technical] Separate Dropdown template into 3 templates 
Use the new format to remove the need for getTemplateParser
in SkinVector

Bug: T319349
Change-Id: Ic4ac1d6d58099a689c29c16b3029bf43a849e50e
 2022-11-03 20:41:20 +00:00
Bernard Wang 15d95fc24a [Technical] Split up Menu.template, restrict decoratePortletData to legacy Vector 
Changes:
* Code is moved from SkinVector to SkinVectorLegacy verbatim since it is now only
needed by SkinVectorLegacy
so we remove it:
** This step broke MainMenu rendering so this was captured in VectorComponentMainMenu
** The isLegacy code no longer makes sense and is removed in a follow up

* storybook no longer run on CI

Authors: Bernard Wang and Jon Robson
Bug: T321102
Bug: T319349
Change-Id: Ib424ca1c767161fdae8c0aeedfe662b7fa039ff6
 2022-11-02 21:22:50 +00:00
bwang 9c6f6709c6 Create new sticky toc container 
Bug: T313060
Change-Id: Ia263c606dce5a6060b6b29fbaedc49cef3e17a5c
 2022-08-31 21:27:06 +00:00
bwang 006ea3517b Add collapsed TOC to sticky header by moving the TOC 
Visual changes:
- TOC icon in sticky header
- Small update to the narrow screens collapsed TOC spacing when open

Bug: T311103
Depends-on: Ic94fda79bd14856ccda14985d5860aa54d3118d0
Change-Id: I977092f951ba2843816609e706bce4b99583f623
 2022-08-11 11:25:21 +00:00
bwang dd8cc5dfe8 Add snapshot class to sticky header tests 
Change-Id: Id1383f234bd0518786feebbbb2d92f7345aa6e70
 2022-05-12 10:51:43 -05:00
Mortal303 ae50914d4e Remove custom handling of aria-expanded in Vector checkbox hack buttons 
Removed class "vector-menu-checkbox-expanded" and "vector-menu-checkbox-collapsed" in
includes/templates/Menu.mustache and deleted the necessary lines in
resources/common/components/MenuDropdown.less, tests/jest/stickyHeader.test.js,
includes/templates/skin.mustache, skin.json, i18n/en.json and i18n/qqq.json.

Bug: T299173
Change-Id: Ibf8a08e6e5d1a6c607abf170c030a0285e84ad74
 2022-03-21 23:14:51 +05:30
Jon Robson 2dcd99ed21 Sticky header dropdown should not contain gadgets in personal menu 
Bug: T302087
Change-Id: Iae1f42c3c526398d7dea038786ae9001e118307b
 2022-02-18 21:30:29 +00:00