wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-18 05:01:25 +00:00
Code Issues Packages Projects Releases Wiki Activity
1923 commits 239 branches 5 tags 93 MiB
Commit graph

5 commits

Author SHA1 Message Date
Sam Smith 7cbc30ebac SearchBox: Add data-search-loc attribute 
The mediawiki.searchSuggest protocol part of the SearchSatisfaction
instrumentation reads the value of an element with the "data-search-loc"
attribute and sets the event's inputLocation property accordingly.

Set the appropriate value for the attribute in
SkinVector::getTemplateData and render the attribute in
the SearchBox.mustache template.

Bug: T256100
Change-Id: I0edbd8906a042072b2055adc2889b083b2c6cac4
 2020-09-17 18:24:24 +00:00
jdlrobson 39a333452b Refactor: html-userlangattributes -> html-user-language-attributes 
This matches the name in core and is needed in preparation for
switching to SkinMustache

Additional change:
The JS variable htmluserlangattributes is renamed
"htmlUserLanguageAttributes"

Change-Id: I306ebb615f720852fb35c25ac240d6b802d05ecc
 2020-07-15 10:18:45 -07:00
jdlrobson 87f08dcf5b [refactor] Drop form-id template property 
In preparation for using the SkinMustache class and
core buildSearchProps method [1],
and to reduce the risk of that change,
move the ID from the template
data to the template itself:

[1] https://github.com/wikimedia/mediawiki/blob/master/includes/skins/SkinMustache.php#L93

Change-Id: I8d62ea6b1adf6ef0cbfa20e1876806eba70b169f
 2020-06-25 18:21:38 +00:00
jdlrobson df2895f610 Cleanup: Use consistent naming in SearchBox 
We have conventions about template variable naming.

* Drop camel case
* Prefix message keys with `msg-` followed by message key name
* Prefix HTML with `html-`

Change-Id: I34f04f3d217dc8caa4dcc29e60058951a6555b1e
 2020-06-01 20:11:14 +00:00
Stephen Niedzielski 9d427dcb30 [Hygiene] [Mustache] rename SearchComponent to SearchBox 
For consistency with VectorTabs, rename SearchComponent to only imply
component. At least two word names seems like a good target (instead of
just "Search") for grepability and standard component style conventions.

Bug: T239248
Change-Id: I1e4f7270ba29c2f35f08e92f8a28cd8a2ec8fe87
 2019-12-06 17:00:42 -07:00
Renamed from includes/templates/SearchComponent.mustache (Browse further)