Commit graph

3184 commits

Author SHA1 Message Date
Jon Robson 10810ec1da [Refactor] Generalize checkbox hack code
Allow it to apply to any appropriately marked up checkbox hack
element.

Change-Id: Ic3770877ee8e92574900715413a51acc964741be
2022-06-10 13:56:56 -07:00
Jon Robson de0729e604 [Refactor] Separate sidebar persistence code from checkbox hack code
Change-Id: I5d7d8897f656419a71b1327c37e88c9dd7f0767c
2022-06-10 13:55:22 -07:00
Translation updater bot 6f56c7b77c Localisation updates from https://translatewiki.net.
Change-Id: I3dd252157662f63d0ec37a6ee582adc45f086f2f
2022-06-10 08:53:23 +02:00
jenkins-bot 268ec7795f Merge "Hide TOC in print mode and clean up other print styles" 2022-06-10 00:12:45 +00:00
bwang e9ea4cee29 Hide TOC in print mode and clean up other print styles
Bug: T306719
Change-Id: I706225e01d1cc09bd387a008b56d9c2dcf8bdf4f
2022-06-09 19:15:27 +00:00
Ed Sanders 10322dbd29 skin.json: Fix 'tittle' typo in documentation
Change-Id: I7e27ae3dcc1ade05b00c817a948ec271bc437fc9
2022-06-09 18:50:33 +00:00
Translation updater bot 9e6db341d2 Localisation updates from https://translatewiki.net.
Change-Id: I9cf24a68deb46cfa79283d47febbae4af4459100
2022-06-09 08:19:17 +02:00
bwang d6e1dbd843 Move menu border style to legacy
Bug: T309398
Change-Id: Idfd88d98cb51ee35a359eef90ed54bc0a9feea87
2022-06-08 21:23:23 +00:00
jenkins-bot d91c921daa Merge "Make footer take up full width" 2022-06-08 19:33:12 +00:00
Jan Drewniak c5cfd4dce8 Restyle Vector tabs in modern Vector
Removes gradients from tabs (i.e. article toolbar) in new Vector, moving
the existing MenuTabs.less component into the skins.vector.styles.legacy module
and creating a new MenuTabs.less component for modern Vector.

Bug: T309398
Change-Id: I5d807f09bfbbceaded756daa78dbb023efcc91dc
2022-06-08 11:26:17 -07:00
Jon Robson c9fe4e83a1 Make footer take up full width
Bug: T293443
Change-Id: I0cea23fc6f7e013900211f10cc3da4066acf4d0c
2022-06-08 14:48:40 +00:00
Translation updater bot 2adf046c9a Localisation updates from https://translatewiki.net.
Change-Id: I741afd2d46911fe88a3529fcd2858664b1fef873
2022-06-08 08:29:57 +02:00
Jon Robson 664b6c5cc5 [Grid] Vector 2022 layout uses CSS grid
It gracefully degrades to a single column
layout on grade C browsers, IE11, and Safari 9.

Bug: T303484
Change-Id: Iaa3c1bee146dc39b1259a1ce712a29c6b22305d1
2022-06-07 17:23:08 +00:00
jenkins-bot 304027073a Merge "[Grid] Minor HTML restructure for grid" 2022-06-07 14:31:31 +00:00
Translation updater bot fb4ce31536 Localisation updates from https://translatewiki.net.
Change-Id: I2729abc4c140e55d59a06024c8953985bf8a9966
2022-06-07 10:03:34 +02:00
bwang 467d994123 Follow-up: Update menu label elements
- Update the modern menu template to avoid using aria-hidden on the `label` element, and avoid using a `label` element when no checkbox is present.
- Revert legacy menu template to use h3 elements


Bug: T301051
Change-Id: I6ab10e35f0d67d70877e55cca5a512c2af4cb972
2022-06-06 23:59:13 +00:00
Jon Robson a018a909d9 [Grid] Minor HTML restructure for grid
Make the sidebar and content siblings of the header element. This
will allow us to easily apply grid column and rows to these elements.

Bug: T303484
Change-Id: I0a91eddbddbe58781892eddb93edfc3d58777968
2022-06-06 14:58:20 -07:00
jenkins-bot 1bc1ead2e9 Merge "Hide central notice from a11y tests" 2022-06-06 21:51:56 +00:00
bwang 41997db7bf Hide central notice from a11y tests
Change-Id: I4c9a58642cdba94996cab82d5f699e398e858adc
2022-06-06 15:51:34 -05:00
Jon Robson e4aaf02ce8 [Grid] Move header rule into search rules
This will also apply to the grid layout so this seems a more
appropriate place, given the class relates to search.

Bug: T303484
Change-Id: Ib5b57fd948ecb5eefbf1d66e0e71045aed6e3102
2022-06-06 19:24:09 +00:00
Translation updater bot 556b32f326 Localisation updates from https://translatewiki.net.
Change-Id: Id47b25bfc527a0d9ba9b3e2e9700925cba811b79
2022-06-06 09:28:56 +02:00
Jon Robson 02fb90531b [Grid] Add TableOfContentsContainer
In preparation for grid work where the table of contents will
be moved into a new container.

Bug: T303484
Change-Id: I931d5148e314c1c05f0474b47be5efd7c166144d
2022-06-03 22:27:22 +00:00
jenkins-bot 3bc8b3a40e Merge "[Grid] Remove vector-layout-legacy selector from sidebar rules" 2022-06-03 22:05:34 +00:00
Jon Robson e801f917ae [Grid] Remove vector-layout-legacy selector from sidebar rules
These should actually be retained in the new design.

Bug: T303484
Change-Id: Ie1755e3cf5dec5da64615084ddc815fab7eb8bb1
2022-06-03 21:29:55 +00:00
bwang c45a4dd1e1 Add back search title to WVUI component
Bug: T291671
Change-Id: I30a917b4392256c0d23e57da882e0a1dc7b59562
2022-06-03 19:08:47 +00:00
Translation updater bot d75fd2d963 Localisation updates from https://translatewiki.net.
Change-Id: I998615f94051d56f7b000204a9d98044b6075131
2022-06-03 08:59:52 +02:00
Translation updater bot 148bc95ca0 Localisation updates from https://translatewiki.net.
Change-Id: I68209e71f2552bce17bc89abf220b55e0d2b7bd5
2022-06-02 08:17:16 +02:00
Jon Robson deb54f9452 Correctly hide the sticky header when it is not in use
When the  vector-sticky-header-enabled class is removed from the body
it means the feature is not enabled, it doesn't mean the sticky header
should be invisible.

Call the hide method instead, and move it out of the function given
its a side effect

Bug: T308343
Change-Id: I4ecd6524146f203af926847812e20275c9573cab
2022-06-01 19:07:49 +00:00
Jon Robson b8701a3b58 [Grid preparation] Restrict certain rules to old layout
Having a clean slate to work from will help with the development of
introducing the grid

Bug: T303484
Change-Id: I8fb9a9d958e4e73e8bfbf4b797cee1353c915db5
2022-06-01 17:24:47 +00:00
jenkins-bot 8c4ed23069 Merge "Adds tests for stickyHeader A/B test logic" 2022-06-01 16:22:13 +00:00
jenkins-bot 5bf70d7fbb Merge "Sticky header edit button A/B test bucketing (updated)" 2022-06-01 16:20:33 +00:00
jenkins-bot f94c86c3e0 Merge "Exclude from max-width via query string patterns" 2022-06-01 16:15:01 +00:00
jenkins-bot 54991e1d13 Merge "Remove unnecessary inner-tag whitespace and self-closing tags" 2022-06-01 15:05:50 +00:00
jenkins-bot 1f8a3c5318 Merge "i18n: Use correct direction for collapse Table of Contents" 2022-06-01 08:17:54 +00:00
Translation updater bot b208c352d9 Localisation updates from https://translatewiki.net.
Change-Id: I417af8b3001e4457fad0a1b9fbf9713a05a11f00
2022-06-01 08:22:34 +02:00
Sam Wilson 87e4ca9a21 Exclude from max-width via query string patterns
Add action=edit to the exclusions in $wgVectorMaxWidthOptions
and update the parsing of the query string values for that config
variable to accept a regex.

Bug: T307725
Change-Id: Iba526033d45e18cb340a2648378d3d90ef3ae3c6
2022-06-01 10:00:39 +08:00
Jon Robson b031247336 Adds tests for stickyHeader A/B test logic
Follow up to I3effbb3e5f0bb1c8663255936458e3849511dfca

Bug: T299959
Change-Id: I8703587a6e616c426638e44ca6dad12617f10ae7
2022-05-31 17:10:49 -07:00
Jan Drewniak d7e6690b52 Sticky header edit button A/B test bucketing (updated)
Adds behaviour for conditionally adding the edit button
to the sticky-header based on A/B test bucketing.

This behaviour depends on having the `$wgVectorStickyHeaderEdit` config
set to true for logged-in users:

    $wgVectorStickyHeaderEdit = [
        "logged_in" => true,
        "logged_out" => false
    ];

as well as an AB test configured with the following buckets:

    $wgVectorWebABTestEnrollment = [
        'name' => 'vector.sticky_header_edit',
        'enabled' => true,
        'buckets' => [
            'unsampled' => [
                'samplingRate' => 0
            ],
            'stickyHeaderEditButtonControl' => [
                'samplingRate' => 0
            ],
            'stickyHeaderEditButtonTreatment' => [
                'samplingRate' => 1
            ]
        ]
    ];

With that config, this change hides the sticky header for all users
except those in the stickyHeaderEditButtonTreatment bucket.

NOTE: This patch address the sticky header being visible on incorrect
namespaces when the AB test is enabled and the revert of
42b808738a.

Bug: T299959
Bug: T309370
Change-Id: I3effbb3e5f0bb1c8663255936458e3849511dfca
2022-05-31 15:58:35 -07:00
Jan Drewniak a3cef30154 Move page title above article toolbar menus
Moves the page's title above the article toolbar (i.e. tabs) based
on the VectorTitleAboveTabs config option. This feature remains
off by default, but can be accessed via the query parameter `vectortitleabovetabs`.

Removes the Navigation.mustache template since it's just a wrapper
for the sidebar + tabs elements, which, with this change, are placed
in different locations in the DOM and don't need a common parent element.

Bug: T303549
Change-Id: Id4816b753a1b2133c53c3b1d390b45631c704daf
2022-05-31 18:06:11 -04:00
jenkins-bot a6f5acd9de Merge "In max-width mode, constrain the width of page previews" 2022-05-31 15:29:26 +00:00
jenkins-bot 0a0bd88d9e Merge "Follow-up I1dee51009: Add url() to list-style-image" 2022-05-30 19:10:55 +00:00
Translation updater bot b7029084ca Localisation updates from https://translatewiki.net.
Change-Id: I5b4824e38db95b0dfe4a4f56590cfc5a23f6bbce
2022-05-30 09:26:28 +02:00
Sam Wilson 0ebae6c4ef In max-width mode, constrain the width of page previews
This allows the editing form to be wide, but makes sure that the
preview seen will more closely match how the page will end up
after being saved.

Bug: T307725
Change-Id: Ib2085eece69fe08b7fca4aaeacef66b26cdd5f16
2022-05-30 11:52:59 +08:00
Ebrahim Byagowi aebd782d75 i18n: Use correct direction for collapse Table of Contents
Collapse Table of Contents has incorrect direction for RTL, this fixes it.

Bug: T309478
Change-Id: I43f2d225aed7c3a74e35f8e72c1e261b39af9737
2022-05-30 02:37:10 +04:30
Ed Sanders 72d2653f59 Follow-up I1dee51009: Add url() to list-style-image
Bug: T309374
Change-Id: I91d690700cf82e315e98be7bfcadd8bdb4cc3450
2022-05-28 23:00:49 +01:00
jenkins-bot 8be6a96b7c Merge "Revert "Sticky header edit button A/B test bucketing"" 2022-05-27 18:30:19 +00:00
Jdlrobson 0df8d35b43 Revert "Sticky header edit button A/B test bucketing"
This reverts commit 42b808738a.

Reason for revert: The sticky header is now showing up in unexpected
places e.g. special pages.

Bug: T299959
Bug: T309370
Change-Id: Ie7f224d84440279ba28e031e13d05984c81a3ad4
2022-05-27 18:10:29 +00:00
Translation updater bot 088d49581b Localisation updates from https://translatewiki.net.
Change-Id: I16c8ff8e3e79b6723eb822c6331c11d535b06276
2022-05-27 10:29:24 +02:00
jenkins-bot 3c847290c5 Merge "Sticky header edit button A/B test bucketing" 2022-05-26 22:35:54 +00:00
Translation updater bot 24f078ce7c Localisation updates from https://translatewiki.net.
Change-Id: I87de623fdb6f2b61b70adb84c608f78a1b74acf3
2022-05-26 08:53:24 +02:00