Commit graph

1365 commits

Author SHA1 Message Date
jenkins-bot 9cf4eb0e7e Merge "Hygiene: remove vectorConfig and use the getConfig" 2020-01-13 22:43:12 +00:00
Piotr Miazga 02d4e4929f Hygiene: remove vectorConfig and use the getConfig
The SkinVector implements IContextSource, thus it has to provide
the getConfig() method. Vector skin is currently using
it's own `vectorConfig` in one place and it passes the VectorConfig
to the VectorTemplate class. Sadly the VectorConfig is the same
thing what $this->getConfig() provides. There is no need to make
this code more complex by handling two different config containers
which at the end are the same GlobalVarConfig instances.

If we decide to handle VectorConfigs differently, let's thing it
through, for now we should simplify code and remove all uncessary
logic. Thanks to that, there is also no need to override the
setupTemplate().

Change-Id: I89c8a77f7d96f867c8c72e61f9e104e14d9512d9
2020-01-13 23:01:42 +01:00
jenkins-bot f40247a9d4 Merge "Hygiene: remove SkinVector::setupSkinUserCss" 2020-01-13 19:38:35 +00:00
jenkins-bot 68af887faf Merge "Convert $templateParser in VectorTemplate.php into an instance variable" 2020-01-13 19:37:56 +00:00
jenkins-bot d4bfcd02ce Merge "build: Updating mediawiki/mediawiki-codesniffer to 29.0.0" 2020-01-13 17:07:55 +00:00
Jan Drewniak a706618a9d Convert $templateParser in VectorTemplate.php into an instance variable
Change-Id: Iaebfaefdd0722d1e63cb73585e0148f54fcdd77e
2020-01-13 15:40:57 +01:00
Piotr Miazga 8a8a44ca00 Hygiene: remove SkinVector::setupSkinUserCss
Tthe SkinVector::steupSkinUserCss is deprecated and
we should use the ::getDefaultModules instead.

Change-Id: I359049d0f159a0dfc374d1c0124e8989aeb4182d
2020-01-13 14:14:39 +01:00
libraryupgrader b1978d572f build: Updating mediawiki/mediawiki-codesniffer to 29.0.0
Change-Id: I336d23b2d322d1ae1a4c3101e69088c11eb9f43c
2020-01-13 06:06:46 +00:00
Ammar Abdulhamid 672dd7b9a8 Upgrade skin.json schema to manifest_version 2
Bug: T242469
Change-Id: Idb96560efc8517ee8d353e856eb3a272af51ed4c
2020-01-13 04:40:02 +01:00
libraryupgrader 24b72c8bfa build: Updating npm dependencies
* grunt-stylelint: 0.12.0 → 0.13.0
* stylelint-config-wikimedia: 0.7.0 → 0.8.0

Additional changes:
* Also sorted "composer fix" command to run phpcbf last.

Change-Id: I59abf3b90868ae225a70bc3c0ba287f2c2335c8b
2020-01-10 18:36:03 +00:00
Jan Drewniak d29adb5dcc Fix uerlangattributes echoing output from PersonalMenu component
Followup to 4f471bfa5e

Bug: T240062
Change-Id: I13c099befc98b42f28e58a669df495b9324190f4
2020-01-10 13:15:17 +01:00
Vedmaka 2fce68778c Replaces $user->isWatching call with WatchedItemStore isWatching service call
Bug: T208766
Change-Id: I178b1a1aa0106d82f1b336f2bda5c6371468d741
2020-01-09 21:50:40 +00:00
Jan Drewniak 4f471bfa5e Extract PersonalMenu,mustache component from VectorTemplate
PersonalMenu is the login/logout notifications etc. menu at the very
top of the Vector skin.

Bug: T239248, T240062
Change-Id: Iae224cbd838e44669a9f27e6dd303c6c3b402d41
2020-01-09 16:01:46 +01:00
Translation updater bot 05aab42559 Localisation updates from https://translatewiki.net.
Change-Id: Ifc5454f72af675170317630447a40b8f2db74dac
2020-01-06 08:21:20 +01:00
Translation updater bot 6abb5bffc2 Localisation updates from https://translatewiki.net.
Change-Id: I08b11aa759a21186847b0ca97f89e058382bdf80
2020-01-03 08:22:32 +01:00
Translation updater bot 14567269b7 Localisation updates from https://translatewiki.net.
Change-Id: I6037449a8ed1a106d23420d96d2bdc4524c59daa
2020-01-02 08:32:21 +01:00
libraryupgrader cfe2ff0864 build: Updating mediawiki/mediawiki-phan-config to 0.9.0
Additional changes:
* Added .eslintcache to .gitignore.

Add check for unset 'class' attribute.

Change-Id: Ib5b8993e89f4cb8f2f5325cbbc1e02401dd19d81
2019-12-22 20:11:34 +01:00
libraryupgrader 36f3475c52 build: Updating mediawiki/minus-x to 0.3.2
Additional changes:
* Added .eslintcache to .gitignore.
* Removing manual reportUnusedDisableDirectives for eslint.

Change-Id: I3de49aad51738d3c0af1cef9af0b714a597a3e2a
2019-12-19 03:47:15 +00:00
Translation updater bot 52a272216b Localisation updates from https://translatewiki.net.
Change-Id: I683e3f1e7cdea2bc71431546aca26c3150977c62
2019-12-16 11:21:35 +01:00
Volker E bf365aa1ac Fix CSS selector in 'print.less'
Change-Id: I630132f551fa49513058f937ee4a845c02acdc2a
2019-12-13 16:43:42 -08:00
Translation updater bot 470870cd6d Localisation updates from https://translatewiki.net.
Change-Id: Ic625474a2ca63ff60f06998f998c2aa5078b3805
2019-12-12 08:55:08 +01:00
Stephen Niedzielski 9d427dcb30 [Hygiene] [Mustache] rename SearchComponent to SearchBox
For consistency with VectorTabs, rename SearchComponent to only imply
component. At least two word names seems like a good target (instead of
just "Search") for grepability and standard component style conventions.

Bug: T239248
Change-Id: I1e4f7270ba29c2f35f08e92f8a28cd8a2ec8fe87
2019-12-06 17:00:42 -07:00
Stephen Niedzielski 60148a1a92 [Hygiene] [Mustache] improve template parameters and docs
Add typing expectations to search box template parameters. Add context
expectations to search box and tabs templates.

Bug: T239248
Change-Id: I4ff1920f5489b68ef73a219ceeceb1f5511fc9e8
2019-12-06 17:00:42 -07:00
Stephen Niedzielski e0b29624d1 Fix: tab attributes
The tab attributes were mistakenly being echoed instead of passed by
value. E.g., http://localhost:8181/wiki/A?uselang=he.

Bug: T239248
Change-Id: Ia0af96df717948743a2d66f8432b47e6f8a9c8f1
2019-12-06 17:00:39 -07:00
jenkins-bot 11ad91633f Merge "Move namespace & view tabs into a VectorTabs.mustache component" 2019-12-04 15:44:38 +00:00
Jan Drewniak c12c5f06db Move namespace & view tabs into a VectorTabs.mustache component
Creates a new VectorTabs.mustache component and uses it to render
the namespace & view tabs.

Bug: T239248
Change-Id: I859e4e95a2a12470f66564db547679c9f0a16727
2019-12-04 15:51:02 +01:00
jenkins-bot 72e5a640f0 Merge "Fix: search header attribute escaping" 2019-12-03 23:37:17 +00:00
Stephen Niedzielski 71672d60b3 Fix: search header attribute escaping
Broken in my previous commit, d6f4aaa. This causes attributes to be
doubly escaped. For example,
http://localhost:8181/wiki/Main_Page?uselang=he.

Change-Id: I9776a3c355081dc5fec7753edf256f55dfe6045b
2019-12-03 16:05:56 -07:00
Fomafix 4102f69d0e Restore arrow flipping for menu indicator
Bug: T239718
Change-Id: I3ff5c40d99aa9bab4d930881a1a4d13f2f18109f
2019-12-03 17:29:14 +01:00
Translation updater bot f790133284 Localisation updates from https://translatewiki.net.
Change-Id: I3b721a7b6fa8bd02316c5813f865d2e10618c271
2019-11-29 08:44:40 +01:00
Translation updater bot d97834d65d Localisation updates from https://translatewiki.net.
Change-Id: I375b30a4689d5b2dbd80b8cec84926b6f586a8ef
2019-11-25 08:29:51 +01:00
Stephen Niedzielski d6f4aaa88e Hygiene: extract VectorTemplate inline HTML to SearchComponent Mustache file
Extract SearchComponent.mustache from VectorTemplate. The "search"
message is now escaped by the template parser. As is, htmlspecialchars()
for "wgScript".

A later patch will change each component renderer function as well as
renderNavigation() to return a string.

Change-Id: I3084b7e0ef73d320c85ee780c9eff13ecea92906
2019-11-20 16:41:05 -05:00
Stephen Niedzielski c9f15a4206 Hygiene: move VectorTemplate inlined PHP to variables
Move template logic outside of the template and into variables. This
will allow a future refactor to move the template to a separate
template-only file.

Change-Id: I91c2df11106cf09428a890a2d96ecbddb18ef0fe
2019-11-20 16:35:04 -05:00
jenkins-bot 501b94f1b4 Merge "Hygiene: divide VectorTemplate.renderNavigation()" 2019-11-20 20:00:40 +00:00
jenkins-bot 546560c755 Merge "Set overflow-y to scroll to prevent reflow" 2019-11-19 14:21:34 +00:00
jenkins-bot 7aa2e8f19a Merge "Hygiene: remove getPageClasses" 2019-11-18 22:59:52 +00:00
Volker E c8e0ea32b1 Set overflow-y to scroll to prevent reflow
Setting `overflow-y: scroll` to prevent reflow as soon as content
comes in. Adding it to `body` as there might be side-effects when
it's set on both, `html` and `body` and latter seems to be the
place where volunteers or third parties would have set it already.

Bug: T204084
Change-Id: Id9ee2e85225f969b6a286628b70fb7a4e447040c
2019-11-18 14:42:03 -08:00
Volker E 6d6e1f1121 Bump h3 to 14pt to set apart from running text
Bug: T183105
Change-Id: I56ebe653a49f548a84643944fd96453219cad804
2019-11-18 14:22:03 -08:00
Stephen Niedzielski 625ec18f81 Hygiene: divide VectorTemplate.renderNavigation()
Cut up renderNavigation() into several discrete methods. Smaller methods
are easier to read and reason about.

Change-Id: I4e55d858ab1745fb2baddef02f7046ec842eb149
2019-11-18 15:26:20 -05:00
Piotr Miazga 2f355a3e11 Hygiene: remove getPageClasses
Looks like the SkinVector::getPageClasses is doing nothing, only
calling the Skin::getPageClasses and returning the output.

Change-Id: I5becaa1505d46cbf9a07b8bfe73ddf324b740876
2019-11-18 15:13:24 -05:00
Translation updater bot 6ce3b83954 Localisation updates from https://translatewiki.net.
Change-Id: I42bcb178a4fe1df0e617b218e7cce99c8d7fae87
2019-11-18 08:35:36 +01:00
jenkins-bot dca39c79cc Merge "Bump running text to more generally readable 12pt on print stylesheet" 2019-11-12 10:45:43 +00:00
Volker E 1d68f1dec3 Bump running text to more generally readable 12pt on print stylesheet
Also bumping headings to not go smaller than running text and
leaving footer text unchanged.

Bug: T183105
Change-Id: Ifb57a6261b6908f23dca52e4544c58ec1935009a
2019-11-12 10:30:24 +00:00
Translation updater bot 45f66ed038 Localisation updates from https://translatewiki.net.
Change-Id: Iaf9ec4c1d26fbc0c580ae03c2edbe8159f8d7f07
2019-11-11 08:40:46 +01:00
Translation updater bot 28b575ddff Localisation updates from https://translatewiki.net.
Change-Id: Ia65aaa9ca4b598f45f1a4b9c5957cab46aa4b6c8
2019-11-07 08:52:29 +01:00
Translation updater bot e8c9b1e47d Localisation updates from https://translatewiki.net.
Change-Id: I4730c4ffcfa25dac408e2449dfa734b4661ee8d8
2019-11-04 08:41:24 +01:00
Umherirrender c19da7d224 build: Updating mediawiki/mediawiki-phan-config to 0.8.0
Bug: T235049
Change-Id: If87fa3451b328419055ddb1700d9fd3a770f8c76
2019-11-02 19:50:52 +01:00
Ed Sanders c61f6469db build: Update linters
Change-Id: I17a65638e0c7d074d4c1db282b278798e875fbe1
2019-10-31 21:43:20 +00:00
Translation updater bot 04c50cedc4 Localisation updates from https://translatewiki.net.
Change-Id: I56654ae229775b3671161fad50175242bc2aaad0
2019-10-30 08:38:51 +01:00
jenkins-bot ac483a78ed Merge "hygiene: Make LESS imports non-ambigious" 2019-10-28 08:31:27 +00:00