Commit graph

81 commits

Author SHA1 Message Date
Bartosz Dziewoński d82e4db35e Make dropdown menus keyboard-accessible without JavaScript
Instead of implementing keyboard (and mouse click) handling in
JavaScript, put an invisible <input type="checkbox"> into the
dropdown handle. It can be focused and toggled using keyboard
actions like a normal checkbox. This checkbox also takes over
the duties of handling mouse hovering and clicking.

Old JavaScript and CSS are left in place for compatibility with
cached page HTML, to be removed later in a follow-up.

Bug: T168080
Change-Id: I27532140b06c97921f1cfb64e44bff814d99a358
2018-01-03 21:58:51 +00:00
Fomafix fb79cd46b3 Restore indicator for menuForceShow of tab menus
The previous indicator was removed in 7a42af066b because of a position
transition. The new indicator has no animation.

An indicator is useful to distinguish between the hover and the click
actions.

Change-Id: Icf765d4985aea36e4f4f6653e769aafaf3c30d07
2017-11-19 19:34:15 +01:00
jenkins-bot 4e990c081f Merge "Use mw-parser-output for content styles, instead of mw-body-content" 2017-11-13 12:44:04 +00:00
Bartosz Dziewoński e4b05ae836 Revert "Fix reversed nav elements when viewing cached HTML"
No longer needed for Wikimedia wikis after the HTML caches expired.
This reverts commit e951a09913.

Change-Id: I5eda153e3368f6a7f9d2f88e336e02b65d01f2b5
2017-11-10 19:17:57 +01:00
Ed Sanders f582645407 Use mw-parser-output for content styles, instead of mw-body-content
Change-Id: Idf0f5f12724d6ce7558102cd4eedc4004e045054
2017-11-10 15:48:18 +00:00
Bartosz Dziewoński ff2f37bc7c Use 'color' to change lightness of "More" menu label rather than 'opacity'
Changing 'opacity' from 1 to other values can cause the browser to use
a different text rendering method, producing unpleasant effects.

We still have to use 'opacity' to change the lightness of the arrow
icon, so move it into an :after pseudoelement.

Bug: T179988
Change-Id: I19c5eafb9ab7e652f2661144abc1e03b381f5ff4
2017-11-07 23:37:46 +01:00
Volker E 29c515ae3f Align VectorMenu items and unify padding with tabs
Aligning VectorMenu items horizontally with menu handle and
set `padding` consistently to `8px` – taking into account
different `font-size`.
Also removing unnecessary duplication of `margin-top` as `margin`
is set in same rule.

Bug: T179782
Change-Id: I30e9b4e50589ef09a0e5dcb0e6c4486e7779a39d
2017-11-07 20:46:33 +00:00
Volker E e2c9a585e4 Bring menu tab appearance closer to standard widgets
Bringing appearance and behaviour closer to standard widget like
DropdownWidget:
- Amending color to be (closest) aligned to WikimediaUI color
  palette, but switch normal and `:hover`/`:focus` state in order not
  to be too disruptive of a change and align with rest of Vector tabs,
- removing obsolete JS functionality as IE 6 as only major browser
  affected does receive the menu items as tabs nonetheless and replacing
  with simple CSS selector,
- removing unnecessary and obsolete images and
- Lessifying selector

Bug: T153043
Change-Id: Ia15480162bb8f923d0e9b6e42ca90c2c880978de
2017-10-19 23:24:15 +00:00
Volker E 0d95e5b6cd simpleSearch: Reduce selector specificity & clean up
Reducing selector specificity and cleaning up CSS as in reducing
properties and putting main colors on top of selectors.

Change-Id: I91959f07404382fcc143607ab4cd5cf0c9aed13e
2017-10-09 17:44:34 -07:00
Volker E 7060ec573f Align simpleSearch border with inputs elsewhere
Aligning
- `border-color`
- `:hover` `border-color`
- `border-radius`
and introducing `transition` to be on par with inputs elsewhere.

Bug: T177808
Change-Id: I41c2719c13935d07f4310c0c752bdfc7377d8670
2017-10-09 17:36:59 -07:00
jenkins-bot f30141fdc3 Merge "Remove fallback color from tabs" 2017-10-09 16:17:46 +00:00
Volker E c163acbdc7 Replace footer text color with WikimediaUI color palette one
Very subtle change from `#333` to tad higher contrast `#222`.

Bug: T153043
Change-Id: I705d03f9c79eafd4569e8ed321939d1044245f59
2017-10-07 20:47:10 -07:00
Volker E 84d1510a38 Remove fallback color from tabs
Removing fallback color from Vector tabs, that isn't part of
WikimediaUI color palette and isn't needed at all resulting
in a worse than necessary appearance.

Bug: T153043
Bug: T168420
Change-Id: Ia9790435dd3ec4df47b70d1a007fca7af79686c9
2017-10-07 18:13:19 -07:00
Bartosz Dziewoński 8db5779682 Do not use icon for "Watch" link when it is inside the "More" dropdown
Bug: T177106
Change-Id: Ia50817afe6395d8a52567599d23a232d6f07c0ce
2017-10-01 20:12:11 +02:00
jenkins-bot e56077fc0b Merge "Remove some unnecessary direction-specific CSS" 2017-09-28 14:05:30 +00:00
Bartosz Dziewoński 6b6c6ba762 Remove some unnecessary direction-specific CSS
Both of these survived across many rewrites, I tracked down the
original commits that added them:

* footer.less: Added in 6d5dca5a899d45512c1031c4235f26cc755b933b in
  MediaWiki core (rSVN62030) as a workaround for "weirdness" in IE 7.
  Users of IE 7 experience much worse weirdnesses when viewing pages
  these days.

* tabs.less: Added in 299d1f328c2ad1475c8a1ac19b4fa07fc087d239 in
  MediaWiki core (rSVN53247) under a generic label of "RTL fixes".
  After change 5d0a07bf9d this is
  actually a no-op.

Change-Id: Iac3d2a26438226a3e23e067780c4b2810ac4903f
2017-09-28 13:22:53 +00:00
Bartosz Dziewoński ee0cfe1833 Remove stray unnecessary @noflip
Follow-up to 5d0a07bf9d.
As it happens, it actually doesn't matter whether this
element has 'float: left' or 'float: right', the
rendering is exactly the same. Let's remove the @noflip
for consistency with .vectorTabs, .vectorMenu etc.

Change-Id: I167c5f6cab7fb85344a558b632b38cbca85fa37c
2017-09-28 04:23:07 +02:00
Bartosz Dziewoński e951a09913 Fix reversed nav elements when viewing cached HTML
Follow-up to 5d0a07bf9d.
See T48947#3641618 for a detailed explanation of the
problem this is fixing. Essentially, our CSS has to be
compatible with both new and old HTML to avoid problems
with cached pages on Wikimedia wikis. To do this, we
add a CSS class to the body and make the new CSS only
apply on pages that have this class. This patch should
be reverted when the caches expire.

Bug: T48947
Change-Id: Icf26e6690b59f470765b2634534d18d2df25ee2a
2017-09-28 04:23:01 +02:00
Rammanoj 5d0a07bf9d Vector: Flip horizontal nav elements with CSS
Flip horizontal nav elements with CSS prperties in RTL(right-to-left) mode

Bug: T48947
Change-Id: I30a5837f84bcdeab205760644bfa40b12cefbece
2017-09-26 10:30:11 -05:00
Mukunda Modell e70a1d38b9 Consolidate duplicate CSS properties
I really should not have merged I30e0642d3cb93c4d9a8b2bdfb7f04912d8ca8649
without getting this fixed first.

Bug: T56919
Change-Id: I870591e63b89f05d7e3714081340c76dcf9f55ac
2017-09-22 21:06:28 +00:00
jenkins-bot 765a143a60 Merge "Tabs (Read / View Source / Search) collapsed under more in resolution < 700px" 2017-09-21 20:21:01 +00:00
Rammanoj f74002b727 Tabs (Read / View Source / Search) collapsed under more in resolution < 700px
tabs such as read/view source are collapsed into more in screens
whose resolution is less than 700 px so that they don't wrap to
the next line and cover the content of the page

Bug: T56919
Change-Id: I30e0642d3cb93c4d9a8b2bdfb7f04912d8ca8649
2017-09-21 20:03:39 +00:00
Bartosz Dziewoński 206efa4c96 Make dropdown menus appear above VisualEditor toolbar
Bug: T171840
Change-Id: I36dc747ec2c41816df371aa5e1d4b81dff24a7dd
2017-08-03 01:27:05 +02:00
Volker E 7a42af066b Remove irritating transition on menu tabs
Removing irritating dropdown arrow position transition
on menu tabs. It is the only place we're using this and it seems obscure
and not helpful to the users from UI Standardization point of view.

Bug: T68698
Change-Id: I8d30108b86b47358349de2ea424c0ba7f67ee7e2
2017-07-20 21:20:59 +00:00
golopot 3f19c24696 Fix misaligned menu tabs
Ensure vertical alignment of menu tabs (for example “More” button) 
with link-only tabs by setting:

* `padding-top: 1.25em;` as on `div.vectorTabs span a`
* `line-height: 1.125em;` as on `div.vectorTabs ul li`

Bug: T171142
Change-Id: Ic4ef86589c6c3d442035f3d768cb9036e1ecc237
2017-07-20 14:14:15 +00:00
golopot ffc0837bf3 Remove position: absolute from #p-logo element
This was inherited from Monobook (r2881, b52a2a1567).

The #mw-panel (sidebar) was at `top: 160px`.
The #p-logo was at `top: -160px`.
This looks hacky so I set #mw-panel `top: 0`.

Bug: T170053
Change-Id: Ifb99ff36e3a9c530c944df2ea0a6c75759045c1c
2017-07-13 16:28:08 +08:00
Fomafix 56ec1a3c87 Remove <div> inside of the <h3>
The <div> was introduced in aba11a7b but this is not valid in HTML 5.

This change ommits the <div> and attaches the background image to the
existing <span>.

Cached HTML with the <div></div> does not matter for the result.

Bug: T169551
Change-Id: I04f7032b6f6bafe10548fde690f55de66b56f61f
2017-07-12 06:21:51 +02:00
jenkins-bot 40699a9a28 Merge "Remove unused selectors for action menu" 2017-07-11 23:45:36 +00:00
Fomafix 5c363643a7 Remove unused selectors for action menu
This change is a follow-up to aba11a7b1c.
Do not deploy this change until HTML cache from before aba11a7b1c expired.

Change-Id: I631260d58229b1b70e2d4e55f8302f9769de3511
2017-07-11 02:59:14 +00:00
Ed Sanders b85dd78e0f Use same left margin (0.5em/8px) for all sidebar items
Bug: T168598
Change-Id: Ice96ba4b7d0af3312baff69a6bb4c34e6e12c205
2017-06-22 12:08:54 -07:00
jenkins-bot c3f5aea44b Merge "Use <div> instead of <a> for action menu" 2017-06-21 21:50:52 +00:00
Jack Phoenix d575e3878a Optimization: move styles specific to redirect pages out of common.less
HT MatmaRex

Change-Id: I6169692547378379dbc935976ad83cf4f366eeeb
2017-06-15 16:13:42 +03:00
Fomafix aba11a7b1c Use <div> instead of <a> for action menu
This change prevents that a middle click opens a new tab with the URL "#" and
prevents a wired outline around the button when selected of focused in Chrome.

The selector "> a" will be removed in a separate change which must get
deployed not before the HTML cache has expired.

Bug: T44241
Bug: T68388
Change-Id: I7255552d3bdec9e40727721b91630623ae24a08b
2017-06-06 08:02:49 +02:00
Arlo Breault dcd01fc1e2 Separate some shared layout with Parsoid
* This is in service of T116508.  See
   Id41c1d2840f441eddb14ca66ba545ee7b160088e where .mw-body is being
   removed from Parsoid content.

 * This is only possible since T155863

Change-Id: I60e3cb3e838fa19d321c4eac0a6828bcfddb6f3e
2017-04-17 14:14:36 -04:00
Rammanoj 7631b496c0 Proper indentation applied to horizontal links in the vector skin
Bug: T67444
Change-Id: I5dc48995583a0e0bd3d8bee6e698effecc4d3f7f
2017-03-29 17:21:40 +00:00
Ed Sanders d183c39d06 Allow edit sections outside of mw-body-content
Bug: T160269
Change-Id: Ib4830cde634b6ca0c3ceb0ba06831c3b4ccedfbd
2017-03-12 11:14:37 +00:00
jenkins-bot 4ab8dc17bc Merge "Align text and border colors to WikimediaUI color palette" 2017-03-10 22:24:39 +00:00
Ed Sanders 24802a3aaf Move heading, paragraph and editsection styles into mw-body-content
Bug: T155863
Bug: T155774
Change-Id: I4c907bd48d472c970b79a7a234c2079254567a7e
2017-03-07 17:52:23 +00:00
Ed Sanders 44473d2a2b Change mw-body ancestor selector to mw-body-content and add to siteNotice
Bug: T155863
Bug: T159578
Change-Id: I036d4def3f61d4a604c804c5368d74ec74883d2e
2017-03-03 22:32:09 +00:00
Volker E 463d95a356 Align text and border colors to WikimediaUI color palette
Aligning some text and border colors (all greyscale) to WikimediaUI color
palette and also add toolbar `box-shadow` to “More” menu dropdown
following standard pattern.

Bug: T153043
Change-Id: Ic3247ce29059ea7d7f59a99ca742334600d85ce6
2017-03-02 17:23:52 -08:00
Ed Sanders 53cabcfe66 Use new placeholder mixin
Also fix site search to use use the same shade of grey
as is used in OOUI and mw-ui.

Depends-On: I96686bb53cee1a833db8f4d0b691d5e4a1b82885
Change-Id: Ib6437b13760e8c13d06927cb45ef674a5f301e35
2017-02-23 16:37:16 +00:00
James D. Forrester 298af67c06 build: Bump stylelint and make pass
grunt-stylelint              0.6.0  →   0.7.0
 stylelint-config-wikimedia   0.3.0  →   0.4.1

Change-Id: Id87b8df04d415e1f1058a4042a31408236402037
2017-02-17 16:34:04 -08:00
Ed Sanders f7d8d036ac build: stylelint more files
Change-Id: If62fa6ff9810de253b65feb1f7e312d22e33bfa8
2017-01-23 15:04:05 +00:00
pppery 3621078abf Specify height of tabs
This fixes the display of the tabs when `box-sizing: border-box` is
specified in local CSS. Previously, they were shifted upwards and shrunk
slightly.

Bug: T104767
Change-Id: I04333300bd1d29003e609091e0f64a73489f04c6
2016-12-14 15:43:43 -05:00
Bartosz Dziewoński 9452689791 search.less: Use only one background-image for overlaid buttons
Bug: T145928
Change-Id: If701930e469283c969e9a8a16574fa1a96cd502f
2016-09-18 16:09:13 +02:00
Volker E 1f8e54b6a0 Make role=search heading and label accessible
Making `role=search` heading and label accessible by using
`.mixin-screen-reader-text` instead of `display: none;`.

Bug: T139427
Change-Id: Ia54fcc2b19854315a2f0c26a1596b32019a42c1b
2016-07-07 14:35:17 +02:00
nirzar 211660e6b0 Allow an alternate, generic header font to be specified for certain languages
Introducing variable `@content-heading-font-family-generic`, that may be
used to specify an alternate font for `h1` and `h2` for languages which
render poorly using the standard heading font stack.
Set it for now on JA, HE and KO languages, based on reported issues.

Bug: T73240
Change-Id: I5217a7947427055f4cb61185d9d7d79848605dd3
2016-07-06 12:30:04 +02:00
Timo Tijhof 600abc4103 Make vectorMenu expand as tabs in IE6
Right now, Vector loads the csshover.htc extension in order to
emulate CSS :hover support in IE6.

This commit makes the vectorMenu expand as basic tabs instead.
Thus allowing us to remove the csshover.htc extension.

Note that the "page action" vector menu (p-cactions) is only created if it
contains items. By default, the only actions in this menu are actions for
logged-in users. For logged-out users, the menu isn't even on the page.

The tabs aren't pretty, but they don't look broken either.

Change-Id: Ibf2332ab0a0d9d7ba3ec03665ad61ca287750ad3
2016-03-01 23:16:34 +00:00
Derk-Jan Hartman 3ca33440f4 .redirectMsg needs to be 0 height
It wasn't because ".mw-body p" introduces a margin, causing an
undesired extra spacing on redirect pages.

Change-Id: I53f63703b086ff6b28c1fb5325ee6693e3322390
2016-01-26 20:12:40 +01:00
This, that and the other 5a10091acc Make "Not logged in" gray text WCAG AA compliant
Follows up 9285a2ae91.

Change-Id: I92157a694d46e198538c1279abd4e37f2abb4bbf
2015-12-10 20:47:13 +11:00