Commit graph

1676 commits

Author SHA1 Message Date
bwang 5d83c55f5e Update tables code to only target unwrapped tables
Bug: T367248
Change-Id: If4267e083cd6721bdb80d32a84c1fd9306096b50
2024-10-03 13:16:59 -05:00
Jon Harald Søby 6d069498e9 Add cursor:inherit to .mw-selflink
Add `cursor: inherit;` to the class `mw-selflink` to get back
the expected behaviour of these 'links'.

Bug: T375876
Change-Id: I52d54dc1265fd1a64bc461892e69475a3b3d50b2
2024-09-29 21:06:06 +02:00
jenkins-bot 9bba83b53f Merge "Add logging to table wrapping experiment" 2024-09-28 03:00:40 +00:00
bwang 1ccb5be4c3 Add logging to table wrapping experiment
Bug: T374493
Change-Id: I276a58635504cfb30c3bcdec93f6bb29f5df730b
2024-09-28 00:51:46 +00:00
jenkins-bot 72118a48b6 Merge "Fix linter warnings" 2024-09-27 16:16:03 +00:00
jenkins-bot 0c79d70470 Merge "Remove @font-size-base from vector-2022" 2024-09-27 02:58:48 +00:00
bwang dd570d7912 Fix linter warnings
Change-Id: I012a98cb3fcbfaa2ba40d85c0225bcf44deb5c01
2024-09-26 14:24:25 -05:00
obamwonyi d71150f46d component: notheme isn’t respected for text color in automatic night mode
More details. Fix for notheme text color issue in automatic night mode

Bug: T374794
Change-Id: I673c11789ab57fe70ed3557d294da65f6d9cc58d
2024-09-26 18:24:35 +01:00
bwang 25f4bc2a37 Remove @font-size-base from vector-2022
Bug: T367899
Change-Id: I6ec44a10a7bfeb6b03912ca6d5a23eaed046db08
2024-09-26 11:44:57 -05:00
Jon Robson 111b3155e0 Drop support for non-Codex message box styles in Vector 2022 and Vector
Going forward these styles will be provided where needed by
the mediawiki.legacy.messageBox module.

Bug: T360668
Change-Id: I58d9e41f0c98adbd816240b161b5145a667436cd
2024-09-18 21:08:01 +00:00
Ebrahim Byagowi 475f80cf76 Use browser native URL instead of mw.Uri
Bug: T374314
Change-Id: I66be10c017e853ea130b0919789b22c4c3f12622
2024-09-13 07:08:12 +03:30
Jon Robson 3fbf5b49f0 Drop unused code relating to old limited width toggle.
Follow up to Ie2617e2fa83b6a888a7a2799cc39f048731dc60d

Bug: T367591
Change-Id: I270f1902f40946f31de29777735dee2e10ebfebe
2024-09-11 00:12:59 +00:00
Jon Robson ea8660bb60 Cleanup: Remove dark mode banner code
This is not being utilized any more, tested or maintained so should
be removed.

Change-Id: I9410171e1025e428b48e5dd12c7dc1161cc800f6
2024-09-06 21:11:04 +00:00
Ed Sanders 64e586d2a4 Follow-up Ie0a938249: Add comment explaining why resize event is needed
Bug: T374092
Change-Id: I27e66bbab4c2f915c80db8ac823972b2f31a07e9
2024-09-06 14:50:03 +01:00
jenkins-bot 5f944947e4 Merge "Reset border-radius on links" 2024-09-05 18:15:52 +00:00
Ed Sanders f653d50f12 Emit a window resize event when client preferences are changed
Bug: T374092
Change-Id: Ie0a9382498c682ac8c1f7942cc3590e9789a1e80
2024-09-05 11:26:43 +01:00
jenkins-bot e2d1b76da5 Merge "Fix override to let indicators float into heading area on legacy Vector" 2024-09-05 01:41:17 +00:00
Jon Robson a6e4370bbd Fixes: Echo icon not visible after click
Due to T343838, we need to adjust the Echo icon after clicking
so it renders consistently with Codex. This is a longstanding bug
and a slight adjustment to how we approach the icon now that Codex
and Vector 2022 use mask-image for their icons.

Bug: T373936
Change-Id: Icdb9cc49c157cb5cbf13fe1f7d5e91b7e986e92e
2024-09-04 18:16:13 +00:00
Ed Sanders 317107b3f6 Reset border-radius on links
This was introduced in I16411a7ea47, which only documented the
changes to the colors used. An unintended side effect was inheriting
the standard border-radius, but that should be applied in a
more targetted manner to avoid conflicting with existing
UI components (e.g. OOUI toolbars).

Bug: T373989
Change-Id: I0615ce1594d66cb5207cd119597ae4d0765e94af
2024-09-04 12:06:33 +01:00
Bartosz Dziewoński aac902c545 Fix override to let indicators float into heading area on legacy Vector
Bug: T373617
Change-Id: I05124bbd20833cd4051ba5b51f7962ce223a5ee2
2024-09-04 03:10:51 +02:00
ksarabia ae6f0d5486 Remove old limited width toggle
* Removes js
* Updates bottomDock style rules
* skin mustache updated
* Remove appearance feature flag - show appearance menu
to all users.

Bug: T367591
Change-Id: Ie2617e2fa83b6a888a7a2799cc39f048731dc60d
2024-09-03 11:25:23 -07:00
Jon Robson 0a4f5c8dc9 Language button dropdown arrow should be progressive color
Currently black.
Flagged by Pixel.
Follow up to 010e7e92d

Bug: T363920
Change-Id: Iaa9ea69c8a1f1b50bb8eedda1acc2c657bef0132
2024-08-29 20:27:57 +00:00
jenkins-bot 92a73b6701 Merge "styles: Remove outdated skin variable" 2024-08-29 19:57:18 +00:00
Volker E. f0b5f234c4 styles: Remove outdated skin variable
`@opacity-base--disabled` is not used anywhere
including in the Vector skin anymore.

Change-Id: Ia0a483b8d3e2d5597aeb512d04f6dc2e95317430
2024-08-29 19:41:36 +02:00
Jon Robson 9695647608 VISUAL CHANGE: Use mask-image for all Vector icons
Visual changes are subtle, but impact 43 scenarios. The color
and positioning is slightly modified to match Codex.

Bug: T363920
Change-Id: Ie5c88e0aa243f73f2dc9f310d18fd59b831edc64
2024-08-29 17:17:35 +00:00
Jon Robson 1b4d07e1d2 Add tooltip to reporting link
Bug: T369849
Change-Id: I225c83e9ee1c95957479a684527d1297b7a471c1
2024-08-27 21:37:54 +00:00
jenkins-bot 66ca79e907 Merge "Remove "report" link for logged-out users" 2024-08-27 20:58:58 +00:00
jenkins-bot c0332419e4 Merge "Revert "Allow gadget/browser extension extensibility of empty search state"" 2024-08-27 17:59:27 +00:00
Jon Robson 16b300ca45 Remove "report" link for logged-out users
Bug: T372754
Change-Id: I8225791f24271cbb8319f07f3a300c62f51e826a
2024-08-27 17:50:47 +00:00
Jdlrobson 0e030b1310 Revert "Allow gadget/browser extension extensibility of empty search state"
This reverts commit 98bee1c71f.

Reason for revert: This wasn't ready for merging. Caused T373463.

Change-Id: Id02bc3528216d1a43e6b505b44362059ab0ffc69
2024-08-27 17:15:51 +00:00
jenkins-bot 9390bb9046 Merge "Fix workaround for position: sticky disabling subpixel rendering" 2024-08-26 21:07:25 +00:00
jenkins-bot 43c6c7f95c Merge "Allow gadget/browser extension extensibility of empty search state" 2024-08-26 16:51:06 +00:00
Bartosz Dziewoński cb58da455e Fix workaround for position: sticky disabling subpixel rendering
Follow-up to badd229bab. Moving
`position: sticky` to the same element as `contain: paint` defeated
the workaround. Move it to the parent elements again to make it work.

Bug: T373066
Change-Id: Ic942bfd599661a29cf7b2dbb6c6cc2ec521b8c82
2024-08-22 02:31:19 +02:00
jenkins-bot 14de6d0d95 Merge "Revert "Prevent dark-mode styles from affecting print media"" 2024-08-13 12:08:54 +00:00
Jdlrobson 2d281db7b1 Revert "Prevent dark-mode styles from affecting print media"
This reverts commit b3ca12e628.

Reason for revert: Icons are appearing black on black in dark mode
in origin/wmf/1.43.0-wmf.18.

Change-Id: Ifdf3970c77b66e5a7835ca44eb45deec2b44eb43
2024-08-13 07:24:28 +00:00
jenkins-bot 4215196b6c Merge "Prevent dark-mode styles from affecting print media" 2024-08-08 22:29:36 +00:00
Jon Robson acb79c5e1b Improve documentation for how feature manager classes work.
This changes nothing about the existing classes, it just improves
how they are documented.

The FIXME comment was making things confusing.

Make sure every feature class is accounted for and audited and
throw a RuntimeException if we forget to document it.

Change-Id: I9d8f6553fe6b8c2ae80d8b2490c8895a8334a537
2024-08-08 20:19:48 +00:00
Jon Robson 98bee1c71f Allow gadget/browser extension extensibility of empty search state
Add hook that renders when search displays for first time to allow
experimentation.

Code can call
```
mw.hook( 'search.display' ).add((node)=> { node.innerHTML = 'hello world' } );

Bug: T371294
Change-Id: Ib3ec73b8ed66877c11e0d8d290a6b564a013702b
2024-08-08 21:19:27 +01:00
Jdrewniak b3ca12e628 Prevent dark-mode styles from affecting print media
Prevents dark-mode styles from affecting print media
by adding `@media screen` to dark-mode related styles.

Bug: T371331
Change-Id: I2ed7fbfc078c6d738c13a71c677783f7ccea2582
2024-08-08 16:06:33 -04:00
jenkins-bot faa0ccdbd5 Merge "Dark mode: Images should have background" 2024-08-02 14:40:07 +00:00
Jon Robson e00536a6b3 Dark mode: Images should have background
Bug: T370074
Change-Id: Ibd49b2ccfa77d4f0e677e0726738c831ad962c28
2024-08-01 18:55:13 +00:00
bwang 6e9047eb12 Migrate bare division math to parens division
Bug: T369669
Change-Id: Iadd66c626c0b61bc06db03b1c0a849995ffb87c4
2024-08-01 13:14:50 -05:00
Derk-Jan Hartman 8eae49df26 Make fake link a button
Bug: T371377
Change-Id: Ic0dc885eea16f7b24f6f67742cf603753ad3ecd3
2024-07-31 14:51:59 +00:00
jenkins-bot 379aa37d1f Merge "Dark-mode feedback link UX improvements" 2024-07-26 00:06:39 +00:00
Jdrewniak 13f0e379b8 Dark-mode feedback link UX improvements
- Makes the dark-mode feedback link (the "report a dark mode issue" )
link in the Appearance menu, only appear when dark-mode is activated.
- Keeps the Appearance dropdown menu open after the dark-mode feedback
link has been clicked.

Bug: T367871
Change-Id: I75d040650f613a7af5db553689d734e56f910431
2024-07-25 11:30:00 -04:00
Jdrewniak 7b35e6b1e8 Create dark mode launch banner for Vector 2022
Creates a dark mode launch banner, (copied from the MinervaNue skin) to
announce the launch of dark-mode for Vector 2022.

The banner itself is not invoked anywhere by default, but will be
invoked through CentralNotice as a banner as part of a launch campaign.

To invoke the banner manually, execute the following in the dev console:

```
mw.loader.using( 'skins.vector.DarkModeLaunchBanner', function( require ) {
    require( 'skins.vector.DarkModeLaunchBanner')();
} );
```

Bug: T370303
Change-Id: I1ca4aab8c302ef418bc1d12dde0d80c96c3b8d4f
2024-07-22 16:13:56 -04:00
Jdrewniak a8d047b319 Increase specificity in dark-mode feedback link styles
Prevents dark-mode feedback link from turning blue
when clicked, caused by styles in the
`.mixin-vector-dropdown-menu-item()` mixin

Additionally, decreases the size of the heart icon
beside the dark-mode feedback link.

Bug: T367871
Change-Id: I348dbafcc3d3d3519da77dc6799818fdd743bba2
2024-07-16 11:27:49 -04:00
Steph Toyofuku b8e9eaf6ed Show night mode gadget disable message on the correct section
Currently, this selector is not specific enough, and so if there is an
additional client pref that is disabled on the page, we'll put the night
mode gadget message in the wrong spot.  Target the skin-theme section
correctly this time, and add a test to ensure this is fixed properly

Bug: T369846
Change-Id: I3495aa9ebf3be510f62a8f19440968fe444be892
2024-07-11 11:44:56 -07:00
jenkins-bot 50c05dca2b Merge "Follow-up to f115016 - Add beta tag & feedback link to Appearance menu" 2024-07-03 23:29:26 +00:00
Jdrewniak 9b93a64fdf Follow-up to f115016 - Add beta tag & feedback link to Appearance menu
Addresses edge-cases for feedback link for dark-mode.
- Feedback link should not be visible if dark-mode gadget is enabled.
- Feedback link should not be visible if page is excluded from dark mode.

Additionally, turns feedback link green after click
and prevents further clicks on link (without removing link,
since removing the link changes the margins on the text)
and adds heart icon beside success message.

Bug: T367871
Change-Id: Idff14ffa7e8f497ec38250cf10252e998c234057
2024-07-03 18:40:39 -04:00