Clare Ming
f12659fff6
Layout + visual style changes for sticky TOC
...
- Layout updates per design review.
- Visual updates per design review.
Bug: T304166
Bug: T305069
Change-Id: I2f95d5938674bb8263b6203c5f6a469762bf0cc2
2022-04-15 10:24:46 -06:00
Translation updater bot
66ee043a6e
Localisation updates from https://translatewiki.net .
...
Change-Id: I994a706f735f3f34464d4c1919ffd197b7e2889d
2022-04-15 09:59:25 +02:00
bwang
58b6831e4d
Rely on core to provide accesskey/title attributes, update search toggle location in DOM
...
Bug: T299980
Depends-on: Ide214de5f246b38689799e20db9e8a4671d9b7ac
Change-Id: I43eb04ec095cc9c1d683df9da05887595c2eddfb
2022-04-14 13:53:07 -07:00
bwang
21f124dad5
Fix missing create account link icon and ensure icon attributes aren't showing up in rendered HTML
...
Bug: T306116
Depends-on: I509dd153ea2c1e04cb89415f185b7abbe0403773
Change-Id: Iaea83098fda7d77fda6629722dcef3e17e21fe06
2022-04-14 11:03:56 -05:00
Translation updater bot
7b85a7d88a
Localisation updates from https://translatewiki.net .
...
Change-Id: I634c48b62b85f76db868395539d1784344fd6e9b
2022-04-14 08:29:06 +02:00
Translation updater bot
cabd1e78d2
Localisation updates from https://translatewiki.net .
...
Change-Id: I101d62380809ac2aead8eeca26786242fe202a0b
2022-04-13 08:34:20 +02:00
Translation updater bot
7acd382329
Localisation updates from https://translatewiki.net .
...
Change-Id: Ie20ecfb916c77ce967194fc40d2537b91c8d8481
2022-04-12 08:16:38 +02:00
jenkins-bot
b7268dd661
Merge "Fix position of search box in vector-22"
2022-04-12 00:41:52 +00:00
Nicholas Ray
5eacd5e629
Fix position of search box in vector-22
...
Looks like the selector for `vector-search-box-show-thumbnail` needs to
be adjusted as it is on the same element as the `vector-search-box-vue`
class.
Change-Id: Ief1dadddc082add65ae4bf29c951f2ddefb15d5b
2022-04-11 18:01:19 -06:00
Clare Ming
28a3c06cdf
Replace TOC arrow icon
...
Bug: T304166
Change-Id: I182c9e5399d95ecea58dcdabb563a98b4e34e47e
2022-04-11 14:56:42 -06:00
Jon Robson
9f6295426f
Prepare for grid layout
...
Add a legacy class to allow us to transition out certain CSS
with new grid system
Bug: T303484
Change-Id: Ie85451b721b64aee42eb4b356f38c3621ce40b5e
2022-04-11 18:12:43 +00:00
Translation updater bot
1f6430a001
Localisation updates from https://translatewiki.net .
...
Change-Id: I8fcbb258c77ac3a839bc7c8a1fc07029f781de19
2022-04-11 08:16:20 +02:00
jenkins-bot
107abe79a0
Merge "Scope ULS styles to when language button is in header"
2022-04-09 00:07:09 +00:00
Jon Robson
3432cf2c80
Only consider article ID if A/B test enabled
...
The article ID shouldn't matter for display of table of contents
unless the A/B test is enabled.
This also has the added benefit of making the content provider
work with table of contents on articles again (content provider articles
always have a page id of 0)
Change-Id: I6af5e1476827828d0974ecbb110476ac1e5dc0c9
2022-04-08 20:04:24 +00:00
Translation updater bot
193b33d85e
Localisation updates from https://translatewiki.net .
...
Change-Id: I05dbfe917e41570b6018330590b0f71225bf1ce5
2022-04-08 08:30:42 +02:00
jenkins-bot
e527168978
Merge "Force legacy TOC to render at lower resolutions"
2022-04-07 23:39:14 +00:00
jenkins-bot
e2149ee0c1
Merge "Remove TOC margin to not always show fade out"
2022-04-07 21:20:26 +00:00
jenkins-bot
a961f3fb28
Merge "Remove env option from a11y test to enable tests to run in docs env"
2022-04-07 21:12:33 +00:00
Clare Ming
b24cf900fe
Force legacy TOC to render at lower resolutions
...
- If TOC A/B test is enabled, page is in treatment group, and
viewport is below tablet, force legacy TOC to render.
- If TOC A/B test is disabled and new TOC feature is enabled,
and viewport is below tablet, neither TOC should render.
Bug: T300975
Change-Id: Ib30c3473eb47d6ac60924f40ccd0e42d29625407
2022-04-07 15:06:30 -06:00
bwang
18c65141f9
Remove env option from a11y test to enable tests to run in docs env
...
Change-Id: Ieef80011996b8e7c5ff11239f2c9ae53da9b3e99
2022-04-07 15:13:17 -05:00
bwang
40045c6e0e
Scope ULS styles to when language button is in header
...
Bug: T304468
Change-Id: Iebacb6a7bf3412a6ee76eb5c9fdb9471c02dd16c
2022-04-07 14:47:44 -05:00
jenkins-bot
1e75d6f373
Merge "Clean up unused constants and outdated comments"
2022-04-07 18:19:28 +00:00
Clare Ming
805c6c97c2
Remove TOC margin to not always show fade out
...
Bug: T302076
Change-Id: I06dd5fc56c30299aceeae46b16d3ebd3e3cf11aa
2022-04-07 11:49:47 -06:00
jenkins-bot
125a8641e5
Merge "Prepare Vector for temporary user accounts"
2022-04-07 17:35:15 +00:00
jenkins-bot
72e842e1f7
Merge "Update puppeteer chrome config for a11y tests"
2022-04-07 16:55:52 +00:00
jenkins-bot
6fc95b72ba
Merge "Drop the Vector.Config service"
2022-04-07 16:54:01 +00:00
bwang
b51aa00a03
Update puppeteer chrome config for a11y tests
...
Change-Id: I9e7940445f18c8a9d01273208545cd60c260279a
2022-04-07 11:20:44 -05:00
Func
12c7d6a0ca
Clean up unused constants and outdated comments
...
Change-Id: If6462e3a67726234abe62fd4d02a5d19ff4f02e0
2022-04-07 16:10:52 +00:00
jenkins-bot
a56698c706
Merge "Update sticky header to use ARIA attributes for section collapsing and add accessible label to toggle buttons"
2022-04-07 15:51:56 +00:00
Translation updater bot
9092f6cf85
Localisation updates from https://translatewiki.net .
...
Change-Id: Ib3242b86b0cb88292e8f254c61e49abff14abf42
2022-04-07 08:11:18 +02:00
Func
b61a92f052
Drop the Vector.Config service
...
It didn't vary by the skin version as documented in the Constants class,
and merely another instance of GlobalVarConfig.
Change-Id: I0acd0366a241e04bb79f6aae5dc52284dfa578df
2022-04-07 04:30:20 +00:00
Clare Ming
a0b1b5b056
Fix TOC fadeout proper
...
Bug: T302076
Change-Id: I247a1a92e6eaa3413053514866966393ff3c1964
2022-04-06 16:25:07 -06:00
bwang
f1c70e99b7
Update sticky header to use ARIA attributes for section collapsing and add accessible label to toggle buttons
...
Bug: T303766
Change-Id: Idda4f286a42152af1d233588a1839ada5491ce95
2022-04-06 17:24:34 -05:00
jenkins-bot
94d9445ba3
Merge "Add automated a11y tests with pa11y"
2022-04-06 19:48:39 +00:00
bwang
dd9b6e1dbc
Add automated a11y tests with pa11y
...
Bug: T301184
Change-Id: If3d5aa74b9b1f5bf0f7aa2ea6950853c9a5f5ada
2022-04-06 19:29:58 +00:00
Ed Sanders
f04f62ec05
Update debounce param order
...
Parameter order was changed in
I2ef1c949d68c5642943a614e2cb3f2f0a4cb140c
Change-Id: Iefc61dd84e53de60a95a69275d5c5619b0db25ff
2022-04-06 17:15:20 +01:00
Translation updater bot
54897659fc
Localisation updates from https://translatewiki.net .
...
Change-Id: Ie76303942a2df27922a79ec4e0d9ea08f14d3fac
2022-04-06 08:28:21 +02:00
jenkins-bot
ec3b66e0ed
Merge "Only track headings that are included in the table of contents"
2022-04-05 22:10:33 +00:00
jenkins-bot
8842c61422
Merge "Revert unnecessary TOC section id change"
2022-04-05 21:14:55 +00:00
bwang
aa8ec1a878
Revert unnecessary TOC section id change
...
Change-Id: I62736b47557b79929b8ad984d6709e762b3db549
2022-04-05 15:38:00 -05:00
Clare Ming
83f324e863
Add fixes for sticky TOC fade out
...
Bug: T302076
Change-Id: I9fffb17e60182ef2d667ed86218b8f24e1d76f5c
2022-04-05 13:52:40 -06:00
jenkins-bot
e3684ba8a0
Merge "Build A/B test bucketing infrastructure for the table of contents."
2022-04-05 17:25:08 +00:00
Translation updater bot
e48a8101b5
Localisation updates from https://translatewiki.net .
...
Change-Id: Ibeba7b06be25b72dedf4aef57be809da7c34daa9
2022-04-05 08:27:43 +02:00
Nicholas Ray
6fbf08a198
Build A/B test bucketing infrastructure for the table of contents.
...
* Bucket and sample on server by using the
`WikimediaEvents.WebABTestArticleIdFactory` service from
WikimediaEvents (soft dependency)
* Add linkHijack.js so that users bucketed in one group have the
possibility of remaining in that group if they click a link to another
page.
Bug: T302046
Depends-On: Ie6627de98effb3d37a3bedda5023d08af319837f
Change-Id: Iff231a976c473217b0fa4da1aa9a8d1c2a1a19f2
2022-04-04 17:06:29 -06:00
jenkins-bot
19f114281a
Merge "Drop the LatestSkinVersionRequirement"
2022-04-04 20:18:35 +00:00
jenkins-bot
b7b5976a13
Merge "Small clean up and TOC update"
2022-04-04 19:54:23 +00:00
Jon Robson
7e3d0828d5
Prepare Vector for temporary user accounts
...
Bug: T300263
Change-Id: I603b232da338655e54f372bec5df68dd96adfb2e
2022-04-04 19:45:14 +00:00
Jon Robson
eca9fcbf79
Drop the LatestSkinVersionRequirement
...
The LatestSkinVersionRequirement is problematic for various reasons:
1) It uses the "useskin" query string
parameter which may or may not refer to the correct
skin (in the case of a non-existent skin it will always come to the conclusion that
it is not modern Vector and thus must be legacy).
2) It uses the User object which may or may not be safeToLoad
depending on when called.
The feature seems redundant at this point, as we are separating code
into separate classes Vector and Vector22 and all the features only apply
to modern Vector. I suggest we remove it and use the features explicitly in the skin
intended.
Bug: T305232
Bug: T305262
Bug: T302627
Change-Id: I92fa33547bd601e05ddc8c1468e681892e47c16b
2022-04-04 19:22:38 +00:00
Translation updater bot
dc6936fe5d
Localisation updates from https://translatewiki.net .
...
Change-Id: I17deb4b18c86d58e6b44d0d3d334a8fc21bc4eb3
2022-04-04 09:37:23 +02:00
bwang
733990f881
Small clean up and TOC update
...
Change-Id: Ic093888cb2b06d8eef95a1317d791e7e1627d0f6
2022-04-01 13:14:02 -05:00