Commit graph

6 commits

Author SHA1 Message Date
Sam Smith 9177c22365 features: Add minimalist feature manager
With complex additions to Vector's codebase like the Desktop Improvement
Program upcoming, it's important that we have a shared, intuitive
language to talk about features and their requirements. Centralising
the registration of features and creating an API satisfies does exactly
this.

This change introduces a greatly-reduced version of Piotr Miazga's
(polishdeveloper, pmiazga) original proposed API and associated
scaffolding classes for feature management in Vector, which itself was
based upon his work in MobileFrontend/MinervaNeue. This is done to
establish a foundation upon which we can build the more sophisticated
parts of Piotr's proposal in a piecemeal basis, thereby minimising risk.

Distinct from Piotr's proposed API is the ability to register sets and
features that are always enabled or disabled.

Additionally:

- A Vector.FeatureManager service is registered but not used

- A list of proposed immediate next steps is included

Bug: T244481
Change-Id: Ie53c41d479eaf15559d5bb00f269774760360bde
2020-02-26 11:49:29 +00:00
polishdeveloper 09671d768f Introduce PHPUnit tests in Vector
To make it happen, we also need to provide a way to
inject different TemplateParser.

Change-Id: I14d8474a2b52f040b688245cbd5bd6f12dddf846
2020-01-31 16:48:43 +01:00
Kunal Mehta a21735b270 Upgrade to newer phan
Change-Id: If7d8badf4f5c564b7a9d6ab3575f9307ee98e9e7
2019-03-20 19:37:59 -07:00
Phantom42 0363a54bf4 Add phan configuration for static analysis
Bug: T179554
Change-Id: I587285fb3687541233156e19e24cd448e9a7976a
2018-05-02 14:16:00 -07:00
Jdlrobson 4d63b91152 Revert "Move Selenium test from mediawiki/core"
This reverts commit 68292ad0a8.

This test seems to be running on other skins that it should
not run on - for example Minerva. I'm not sure if this
is configuration related or test related.

I will follow up and restore these personally.

Bug: T188553
Change-Id: I4aa58fd021aceab1a01c288782111faeb52723f2
2018-03-01 18:00:01 +00:00
addshore 68292ad0a8 Move Selenium test from mediawiki/core
Bug: T187859
Change-Id: Ib153f1d55e4471c4dc1e16ad3c9ae0ea9f73acf5
2018-02-27 19:24:02 +00:00