Commit graph

24 commits

Author SHA1 Message Date
Timo Tijhof c5d49d71fb Remove 'SkinVectorStyleModules' hook
Bug: T185782
Bug: T140664
Change-Id: I67950b4bed34b56d17bbea82f311bfe31683ad1e
2018-01-26 10:33:47 -08:00
Timo Tijhof a14ba2a1e7 Deprecate 'SkinVectorStyleModules' hook
Bug: T185782
Change-Id: Ie40309964797cbb5af7682d7f566fc674bc4ef12
2018-01-26 10:33:46 -08:00
Bartosz Dziewoński 7abf395766 Revert "Revert "Print styles in Vector are no longer feature flagged""
The revert looks like it has been performed incorrectly,
and I found a much better solution to the task anyway.

This reverts commit 7d2fc6df27.

Bug: T178028
Bug: T183640
Change-Id: Ib46c69b061b522fc6365459297ad3f3d4f4d0d0d
2017-12-27 11:26:29 +00:00
Paladox 7d2fc6df27 Revert "Print styles in Vector are no longer feature flagged"
This reverts commit c863b94302.

This breaks the MediaWiki Installer ui.

Bug: T183640
Change-Id: I9f249db503c4df6ab9d87b97d9f2d1dca80744ba
2017-12-23 19:17:49 +00:00
Bartosz Dziewoński e4b05ae836 Revert "Fix reversed nav elements when viewing cached HTML"
No longer needed for Wikimedia wikis after the HTML caches expired.
This reverts commit e951a09913.

Change-Id: I5eda153e3368f6a7f9d2f88e336e02b65d01f2b5
2017-11-10 19:17:57 +01:00
jdlrobson c863b94302 Print styles in Vector are no longer feature flagged
Remove feature flagging of print styles

Changes:
* Merge experimental module into skins.vector.styles
* Update skins.vector.styles RL class to support LESS variable
* Remove feature flag class in HTML and LESS (update indents in
LESS file)

Bug: T178028
Change-Id: I8d5c59c5c9f415ffbd7fa41a512cbea87887e9e7
2017-11-02 11:04:58 -07:00
Bartosz Dziewoński e951a09913 Fix reversed nav elements when viewing cached HTML
Follow-up to 5d0a07bf9d.
See T48947#3641618 for a detailed explanation of the
problem this is fixing. Essentially, our CSS has to be
compatible with both new and old HTML to avoid problems
with cached pages on Wikimedia wikis. To do this, we
add a CSS class to the body and make the new CSS only
apply on pages that have this class. This patch should
be reverted when the caches expire.

Bug: T48947
Change-Id: Icf26e6690b59f470765b2634534d18d2df25ee2a
2017-09-28 04:23:01 +02:00
Umherirrender 73e498d24b Improve some parameter docs
Change-Id: Iade09edaa5d10dfa68defc1735b1fb4f888855e3
2017-09-09 13:52:04 +00:00
Piotr Miazga 678e39fb91 Hygiene: Do not use ConfigFactory::getDefaultInstance()
ConfigFactory::getDefaultInstance() is deprecated and code should use
MediaWikiServices instead

Change-Id: I085c6cfd724e6005bf8ea6933bf13de98dadb018
2017-07-28 17:59:03 +02:00
jdlrobson 3a3e7ac046 Feature flagged print styles
These are feature flagged to allow editors to test before making
them the default. A class is added to the body tag to allow us
to switch between old and new styles at a later date.

To start with we introduce some typography improvements.
Further iterations will focus on other elements.

Changes:
* headings were previously diluted in the body content and difficult to spot.
This evens out the spacing between last content and its own content block.
* clear ownership of <p>s with its heading
* We would like to match Latex style body typography with single column.
The new styles reduce the number of pages by around 20-25%
* hyperlink underline -
This is a community requested feature. We do not use color in print styles
because it's printer friendly. Because of this, it is not possible to indicate
blue links in articles. If a user wants to know if this article exists on wikipedia,
it's not possible given solution.
We would like to underline the <a> tags in print styles.
it's better for accessibility as well.

Bug: T169823
Change-Id: I453ae43099796a74c39d965b796f2fa13942106c
2017-07-20 11:54:55 -07:00
jdlrobson e53b4cf522 Vector should operate in responsive mode when the mobile skin
With MobileFrontend installed applying
?useskin=vector&useformat=mobile will ensure that responsive vector
mode is invoked.

I'm keen to do this, as it would help to have more examples of skins
that are MobileFrontend aware as part of the work I am doing in
T166748

Change-Id: I81edd855a5e96400d1179fb10907fcc30ea43ef7
2017-07-03 15:57:49 -07:00
Gilles Dubuc 1dc22027b7 Toggle logo preloading via the skin
Bug: T100999
Change-Id: Ibef1efcce807b1da4f1723cc8a51038ecb4ce577
Depends-On: I0e18dc7fdbf133f3e4002f48f3040604687571dc
2017-05-02 15:03:47 +02:00
Siebrand Mazeland 8a09ba2014 Use mediawiki-codesniffer 0.6.0
Change-Id: Ibbc42739d1bafea203c14f0ab351e7e063dc66bc
2016-03-07 14:24:27 +01:00
Ori Livneh c2a6262807 Remove IE6 CSS hover support
The hover effect is not a basic usability requirement.
Having this ancient cruft in our HTML depresses me.

Change-Id: I0ca5b3b6a6037a9ec733283c656996969cc020e3
2016-03-01 23:19:22 +00:00
Kunal Mehta ac43e74cfb Unbreak styles for installer
The installer hardcodes and expects to find a "skin.vector.styles"
module in skin.json, so moving it into a hook broke the styles. Moved it
back into skin.json, and left a comment so future developers don't make
the same mistake.

The responsive code is now a separate module,
"skins.vector.styles.responsive", which is only added to the page output
if VectorResponsive is enabled.

Bug: T106747
Change-Id: I7540b7871531ef650e799f012477cef6cdd32fb7
2015-07-23 17:05:26 -07:00
Florianschmidtwelzow 0eaadb3b14 Don't use core config in Vector skin
Vector's own configuration properties should be fetched from
Vector's own config object, instead of core's config object.

Follow up: Ib611357bbce739b1d193abaf89c228ba52613d6a

Change-Id: I358a5c1876098a85d77e90b11b3bf4e77c0f6c78
2015-07-23 07:19:47 +02:00
Derk-Jan Hartman a8f8ecf234 Fix viewport argument value to use commas
The fields separator is a , not a ;
This is a common mistake, because it was in one of the first
blogposts that discussed viewports.

Change-Id: I0b88db484c906f3c717aced67360d0f899af8f1f
2015-07-22 21:18:06 +00:00
Jack Phoenix cec2337aac Make Vector more responsive
This functionality is off by default, behind a configuration variable
($wgVectorResponsive) by popular developer demand.

CSS/LESS code by James Hare, with tweaks and testing by Jack Phoenix.

Bug: T46387
Change-Id: Ib611357bbce739b1d193abaf89c228ba52613d6a
2015-07-18 16:54:33 +00:00
Chad Horohoe 7ad814d427 wfRunHooks() -> Hooks::run()
Change-Id: Ib2c61f675bb7bbd44cec5b7a9ab68721865b4b09
2015-04-27 21:53:29 -07:00
Kunal Mehta 85d097ba4c Simplify construction of SkinVector
* Don't require a Config instance to be passed in the constructor,
  as that breaks skins that extend it.
* Don't manually register the skin with SkinFactory, use $wgValidSkinNames

Change-Id: Ie8539027c17caff35c1fc52a56676763df667fd9
2015-01-18 11:42:39 -08:00
Bartosz Dziewoński 4cec8a7058 Remove CSS transition on window resize
They do more harm than good.

We still have the "HD" and "non-HD" styles, just no smooth transitions
between them.

Bug: T85614
Change-Id: I52dd9883eb4e7df00f0613182d4adaa3f28fe5b7
2015-01-15 14:30:02 -08:00
Kunal Mehta 9ff29df16a Make it obvious the config object belongs to the Vector skin
Change-Id: Id4504565feedaa31e170ea21782fed8043511b31
2014-08-16 13:19:26 -07:00
Kunal Mehta 83707028e5 Use SkinFactory to register skin, and Config instead of globals
Change-Id: Ic90969e5d71458c880f2b59e160ffedd7a5ac9be
2014-08-13 16:46:22 -07:00
Bartosz Dziewoński d28f09df31 Move Vector skin from core
This is the final step of the process described at
<https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki>.

Corresponding core change: Idfc38503.

Change-Id: I84fcf7ce6385b8323544cafe6912a00f1886d20d
2014-08-07 13:38:34 +02:00