wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-26 00:25:40 +00:00
Code Issues Packages Projects Releases Wiki Activity
4072 commits 29 branches 5 tags 93 MiB
Commit graph

8 commits

Author SHA1 Message Date
Ed Sanders 7323d6af4e Use tabs consistently in .mustache files 
Change-Id: I3874b8a03f8a512a4d31f4c85a030de63cbc3c69
 2023-01-17 11:48:34 +00:00
bwang fe105edcdb Update dropdown and pinnable element styles to match spec 
- Generalize spacing for pinnable header and menu items under PinnableHeader.less and PinnableElement.less
- Impacts main menu, page tools & personal tools

Bug: T324877
Change-Id: I4042e5c1957d64797f21146f687ef960721299ce
 2023-01-04 11:24:55 -05:00
bwang 46f17487fd Update main menu templates and classes to be consistent with other pinnable elements 
- Rename data-portlets-main-menu to data-main-menu
- Rename MainMenuContents.mustache to MainMenu
- Replace usage of .vector-main-menu-contents in favor of .vector-main-menu
- Add classes to PinnableContainer
- Use PinnableContainer and PinnableElement in main menu
- Remove MainMenuDropdown.less

Bug: T317900
Change-Id: I59b3acd3d56cd5761e5978607634dfb9a88f60e3
 2022-12-16 17:34:23 +00:00
Jon Robson a7f008b9bc Page tools: Main menu is a dropdown 
This is an incomplete styling of the menu.

This should be enough to start an initial design
review and unblock other work on the dropdown.

Out of scope for this patch:
- Pinning (being done in T317900)
- Design (will be done in follow up)

This should cause no visual regressions in Pixel.

Bug: T317899
Change-Id: Id7b47cc16fc8cf93d406687198ba37acf7a9cf24
 2022-12-07 23:19:29 +00:00
Jon Robson 769818514d [Refactor] Rename Portal component to MainMenuGroup 
The Portal component is only ever used inside the MainMenu component

Change-Id: I3a3c58b11416f28c58f02a8bdfdacfbb7df6de9b
 2022-12-01 14:45:52 -08:00
bwang 099eed0487 Remove CSS classes and selectors from cached HTML 
Bug: T316570
Depends-on: Ib4050768f20b1734d356104f18aa539f657099d8
Change-Id: I97f87b32402d7f4fd790f9a8b9abab42efd9d890
 2022-11-03 11:12:39 -05:00
Bernard Wang 15d95fc24a [Technical] Split up Menu.template, restrict decoratePortletData to legacy Vector 
Changes:
* Code is moved from SkinVector to SkinVectorLegacy verbatim since it is now only
needed by SkinVectorLegacy
so we remove it:
** This step broke MainMenu rendering so this was captured in VectorComponentMainMenu
** The isLegacy code no longer makes sense and is removed in a follow up

* storybook no longer run on CI

Authors: Bernard Wang and Jon Robson
Bug: T321102
Bug: T319349
Change-Id: Ib424ca1c767161fdae8c0aeedfe662b7fa039ff6
 2022-11-02 21:22:50 +00:00
bwang 51457a78e7 Replace incorrectly mw- prefixed classes 
Rename template and CSS files to match updated naming conventions, replaces instances of "sidebar" with "main menu"

Bug: T316570
Bug: T317437
Change-Id: Ib4050768f20b1734d356104f18aa539f657099d8
 2022-10-25 10:28:31 -05:00