Commit graph

2564 commits

Author SHA1 Message Date
Clare Ming 37c9a24f75 Update scroll observer to allow event logging
- Permits logging for scroll events without sticky header.
- Update function name to be more precise.

Bug: T292586
Change-Id: I441b4bf81bc4a36a03f0f1c215d86b01dce2911d
2021-12-01 16:12:06 -07:00
Translation updater bot ca251c25f8 Localisation updates from https://translatewiki.net.
Change-Id: Ifc1ad14f60b9b6d7c983b2993541030fd70c30be
2021-12-01 08:16:56 +01:00
jdlrobson f0ed70d709 Restores language button icon font size
The font size of icons should never be changed. Since it's also a span

Bug: T296212
Change-Id: I8bf4e9a7d43a9e5206d3ff6d89e2c3f74fa0d25a
2021-12-01 01:08:49 +00:00
Translation updater bot 0b232afc06 Localisation updates from https://translatewiki.net.
Change-Id: Ibc1f508538927b4bf8bef1aabd46b69a21c0042a
2021-11-30 08:24:03 +01:00
vladshapik 262a520a2c Avoid using User::getOption
Remove using of User:getOption since this method
will be hard-deprecated. Now it is soft-deprecated.

Bug: T296083
Change-Id: I3194a9c1c5c70592f88bc4dbedc78846d1141768
2021-11-29 23:46:05 +00:00
jenkins-bot 8c19f565d1 Merge "Update style for page title in sticky header" 2021-11-29 23:11:58 +00:00
jenkins-bot 0b8c30cc25 Merge "Update sticky header height." 2021-11-29 22:56:37 +00:00
Translation updater bot abecd7b66d Localisation updates from https://translatewiki.net.
Change-Id: I782ae1872950d14a6320b31d8cd95c8ebdc646d3
2021-11-29 08:14:31 +01:00
Translation updater bot 6d7ba2bca6 Localisation updates from https://translatewiki.net.
Change-Id: I7df367a116031aee0ce653ce3c04ac84cbef2e70
2021-11-25 09:04:24 +01:00
Clare Ming d8eff021e1 Update sticky header height.
Bug: T296321
Change-Id: Ic8efa9404282a98aee37dcf9ba33a0b26d6abaff
2021-11-24 14:20:31 -07:00
Clare Ming 101c438c02 Update style for page title in sticky header
Bug: T296320
Change-Id: I0deabfb598e92f07296824c94a9c7c81daefe486
2021-11-24 13:59:16 -07:00
jenkins-bot 1c96e32b6f Merge "Remove unused markup icon" 2021-11-24 20:21:55 +00:00
jenkins-bot 409405474a Merge "Update sandbox user menu icon" 2021-11-24 19:35:51 +00:00
Translation updater bot a8c243134d Localisation updates from https://translatewiki.net.
Change-Id: Ia685ce317233109b5552b409394b6a6df26b5859
2021-11-24 08:24:38 +01:00
bwang a364e93d94 Remove unused markup icon
Bug: T288928
Depends-on: I553bbcc9f1a98d75e160ede7a66ffcf6510fa28a
Change-Id: I4c4ce87012325c239838de7dc0a7555ba6298d2b
2021-11-23 17:26:10 +00:00
bwang 3981333271 Update sandbox user menu icon
Bug: T288928
Change-Id: I9b781ade0cdc1114dc1cb2aa087fb49bf8aa4acd
2021-11-23 11:21:45 -06:00
jenkins-bot 5e7dc81e38 Merge "Ensure sticky header ULS is tracked by DesktopWebUIActionsTracking" 2021-11-23 16:09:45 +00:00
jenkins-bot ed4ec0079a Merge "HTMLLegacySkinVersionField: accept string 'default' value" 2021-11-23 11:27:41 +00:00
Translation updater bot 5c9f05c105 Localisation updates from https://translatewiki.net.
Change-Id: Ia5dd5e7d8dab4534b6ede62530b2ac0e014af44f
2021-11-23 08:28:11 +01:00
MusikAnimal 5207a15b91 HTMLLegacySkinVersionField: accept string 'default' value
After I628435a4a, we were asserting a boolean was given because we're
extending HTMLFormField which requires a boolean value. This was safe
because GlobalPrefs would provide a boolean, but that changed with
I594f6297.

We could rework GlobalPrefs once again to ensure only a boolean is
passed in, but since HTMLLegacySkinVersionField already has special
handling around the data types, it seems to make sense to contain the
type transformation in this class.

Simply removing the Assertion is enough to prevent T296068, however
depending on when the global preference was saved (such as since MW
1.38.0-wmf.9 but before wmf.10), it's possible either a bool or a string
was saved, hence we check for both to ensure correct display.

Bug: T296068
Change-Id: If10b948617d2bb8346475f207fe425fb768cb987
2021-11-23 00:57:25 -05:00
Translation updater bot ed61ffc192 Localisation updates from https://translatewiki.net.
Change-Id: Ia362619cfa11f461d83e9eca2419661d1be86ecb
2021-11-22 09:05:48 +01:00
bwang 90a3a226e7 Ensure sticky header ULS is tracked by DesktopWebUIActionsTracking
Bug: T289815
Change-Id: I1960614e12a50a20af157874b925610d29dfa2c7
2021-11-19 16:51:37 +00:00
Translation updater bot b8d0ee861b Localisation updates from https://translatewiki.net.
Change-Id: I9b9761cc1044e8037314ccd1557caebfe455dd84
2021-11-19 08:31:17 +01:00
bwang 54639c4af3 Fix icon button spacing, make it consistent with margin defined in core
Since a margin was added to adjacent sibling spans of icons (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/736919), Vector icon buttons have had too much spacing. This patch removes the extra spacing defined in Vector CSS and the accidental whitespace that was included in the ULS buttons..

Change-Id: I308d1941c5f82cb144c2a9d233fbf44c730413a7
2021-11-18 18:55:00 +00:00
Translation updater bot 4cbfdcb2f7 Localisation updates from https://translatewiki.net.
Change-Id: I6b66bcc6dcc1d27b820e3d8360a66fe419218c9a
2021-11-18 08:44:01 +01:00
Clare Ming ea0fccb5b8 Disable edit button in sticky header for logged users.
Bug: T294926
Change-Id: I9c987a6962155b04b161111e1a1783d750fee74b
2021-11-17 13:54:02 -07:00
Translation updater bot d3e7ce493b Localisation updates from https://translatewiki.net.
Change-Id: I909f89e2042be6b526b2b340bc4db1942a533ddd
2021-11-17 08:32:23 +01:00
Translation updater bot 633275e093 Localisation updates from https://translatewiki.net.
Change-Id: Ica5e8e60220689ba2b5fb9521e45271e78133215
2021-11-16 08:17:34 +01:00
jenkins-bot 611af67401 Merge "Revert "Fix font size in editor preview"" 2021-11-15 20:11:19 +00:00
Esanders ad9492896d Revert "Fix font size in editor preview"
This reverts commit 058551e9b9.

Bug: T287733
Bug: T295712
Change-Id: Ic239d1334f09d2a1ecbb7f28d69abd0a349128e5
2021-11-15 18:03:50 +00:00
Translation updater bot 1d8b6d5d38 Localisation updates from https://translatewiki.net.
Change-Id: I96f516e20ecb200aa5104c3f32be22d421050f19
2021-11-15 08:15:52 +01:00
Umherirrender 0c154bba36 build: Updating mediawiki/mediawiki-codesniffer to 38.0.0
Change-Id: Ic16a1f89fc5ccae3eddd31b1d566128e60592b90
2021-11-13 19:01:31 +01:00
jenkins-bot 4982868628 Merge "search: Prepare for Vue 3 migration" 2021-11-13 00:09:18 +00:00
jdlrobson 058551e9b9 Fix font size in editor preview
Depends-On: I7eaef3ef89a23932edd5abdd74703eb3297ee061
Bug: T287733
Change-Id: I42c6a8da06d1ab9c4d546b940bc4d627b118e2a6
2021-11-12 17:50:31 +00:00
bwang b196d68326 Use searchFooterText slot in typeahead search component
- Create new 'vector-searchsuggest-containing' translation for WVUI search footer text
- Use 'search-footer-text' slot in WVUI typeahead search
- Remove instances of old 'footerSearchText' prop

Bug: T290392
Depends-on: I8fb7761e60be330e58cd017872318fe3675c0be1
Change-Id: I9c946f85c3e4a603c362c3ea4b8016c585cdd212
2021-11-12 10:47:55 -06:00
Translation updater bot 7a57ae93fe Localisation updates from https://translatewiki.net.
Change-Id: I772990e90deee00bc966f2f064e5efe1b81d4828
2021-11-11 10:04:42 +01:00
jenkins-bot 39ffd2c8e3 Merge "Revert "Apply typography rules to .mw-body-content elements outside .vector-body"" 2021-11-10 20:58:37 +00:00
Jdlrobson 0b6636d587 Revert "Apply typography rules to .mw-body-content elements outside .vector-body"
This reverts commit da832cc53d.

Reason for revert: Bartosz reports this made
things worse, so probably best to go with
the VisualEditor selector approach.

Change-Id: Ifcb18c7a388986df44424f9a58be35314c3d3e2c
2021-11-10 15:07:19 +00:00
jenkins-bot e95e48ce51 Merge "Add scroll event + init A/B test logging to sticky header, AB js" 2021-11-09 23:26:17 +00:00
Clare Ming 457dcfc472 Add scroll event + init A/B test logging to sticky header, AB js
- Pull IntersectionObserver into new file to share observer with different callbacks:
  - Wrap show/hide functionality of sticky header in conditionals based on user test group or by default.
  - Fire hooks for scroll event tracking in WME.
- Add new js for A/B test functions and variables:
  - Fire hook to send data for A/B test initialization.
- Update main js to include scrollObserver, A/B test init functionality.
- Add A/B test config.
- Update ResourceLoader package dependencies for sticky header.
- Though not a strict dependency, see I42e3e7c2084c1e88363d5d1662630ed23a28c4d2 in WME repo which uses these hooks to log scroll events.
- This patch includes changes from I56f40e706f8706fde1c0891a0561dd32c5e02bfc which were consolidated here for simplicity and ease of review - related to T292587 which calls for logging an init event for bucketing of users during A/B testing.

Bug: T292586
Change-Id: If6446e1e84cea3649905808c4f0e9f6862255fa3
2021-11-09 15:00:25 -07:00
jenkins-bot e3b5356aab Merge "Apply typography rules to .mw-body-content elements outside .vector-body" 2021-11-09 21:38:11 +00:00
jenkins-bot 4efa75aa7f Merge "Fix specificity of widespread .external selector" 2021-11-09 17:14:03 +00:00
jdlrobson da832cc53d Apply typography rules to .mw-body-content elements outside .vector-body
Bug: T287733
Change-Id: Ib737f215104b2aa234bf694e734de12fccff2fc3
2021-11-09 06:32:01 +00:00
Translation updater bot 63af267555 Localisation updates from https://translatewiki.net.
Change-Id: Ic5cf468df7639856dbcc7450f32db46e47519e7b
2021-11-09 07:31:41 +01:00
Volker E 2ba2af97cf Fix specificity of widespread .external selector
Returning to `a.external` over only `.external` as it's used widely
within MediaWiki and skins and it needs to kick in in appropriate
places.
`.external` is besides one false positive only for anchor elements,
nonetheless more specific is simpler and more fail-safe than the
other way round.

Change-Id: I3e2fec26d1f835b11f9a66fdf4ba7faeca12d9d2
2021-11-08 21:58:57 -08:00
Translation updater bot a20bf464b3 Localisation updates from https://translatewiki.net.
Change-Id: Iaa8925f1fa698a237b90b5e0fbf493809129c1cf
2021-11-08 08:19:02 +01:00
Roan Kattouw 5dee570cb2 search: Prepare for Vue 3 migration
Port the initialization code for the Vue search to use Vue.createMwApp()
instead of new Vue( ... ). The former mimicks Vue 3's API for mounting
components.

Without this change, this code breaks in Vue 3 (even in compatibility
mode) because the compat support for new Vue(...) is imperfect. By the
time renderFn is called, the searchForm container has already been
emptied by Vue's internal mounting code.

Instead, inspect searchForm and generate the prop list before mounting,
then pass the props to createMwApp() and mount the component.

Bug: T294476
Depends-On: I1fcdcf7bf87f5af2deb9763a231f2c360ea45b23
Change-Id: I5b6e66051d97e75f8f03b8258894daba22525797
2021-11-05 15:53:34 -07:00
jenkins-bot 04ff34bd0c Merge "Initialize the skins.vector.es6 module before the skins.vector.js module" 2021-11-04 18:11:29 +00:00
Translation updater bot ac481991e6 Localisation updates from https://translatewiki.net.
Change-Id: I1a8224d993adff5b85afd5b071eba88ab621fe06
2021-11-04 10:09:25 +01:00
jenkins-bot 2d501e987c Merge "Add comment to dropdownMenus.js regarding the CHECKBOX_HACK_BUTTON_SELECTOR" 2021-11-03 17:47:00 +00:00