Commit graph

4391 commits

Author SHA1 Message Date
Jon Robson 080b6958e8 Use modern ES6 methods
* Prefer dispatchEvent to $.trigger
* Prefer Object.assign to $.extend
* Prefer URLSearchParams to $.params
* Prefer getAttribute / properties to $.attr
* Prefer document.querySelectorAll over $.find

Change-Id: I5f4464e5bfa11b401e663f0b8761fc6092380627
2023-04-14 13:38:38 -07:00
jenkins-bot 1f95d60531 Merge "Point out the limited width control" 2023-04-14 18:00:14 +00:00
Jon Robson 2622472983 Point out the limited width control
The limited control will be pointed to on page load
When wgVectorPageLoadIndicator is set to true (defaults
to false)

Clicking the button should show the indicator.

Additional change:
* Update config.json to reflect new state
(Follow up to 28ada2dc)

Bug: T333601
Change-Id: I188ed7226b9a1530e54b1aaa80caa0830bf73633
2023-04-14 17:15:56 +00:00
Translation updater bot 7c884f79d1 Localisation updates from https://translatewiki.net.
Change-Id: Ifdbd39184b3a5679f0b2d810334bf1cc26738f8e
2023-04-14 09:30:42 +02:00
jenkins-bot a0c7b58ec6 Merge "Drop ES5 compatible code" 2023-04-13 20:06:31 +00:00
jenkins-bot 9189ec50ae Merge "Remove Eslint disable and TypeScript ignore rules, bump coverage" 2023-04-13 15:15:29 +00:00
Translation updater bot 9bc906fcce Localisation updates from https://translatewiki.net.
Change-Id: Ie3efe32f14aa8f1b322478ac70acea65d055b0df
2023-04-13 08:49:18 +02:00
Jon Robson 10033b294e Drop ES5 compatible code
Drop usages of $.closest in favor of ES6 closest

We also no longer need to check for whether closest is available
now that we do not need to worry about ES5 code.

Change-Id: I2442a4f69f8181dd761ca7ac418839cfca26a36f
2023-04-13 00:27:22 +00:00
Jon Robson 2499e834bb Remove Eslint disable and TypeScript ignore rules, bump coverage
Follow up to 87dd101a
* bump coverage to reflect improved test state
* remove ts-ignore statements
* Drop eslint-disable-next-line compat/compat rules in ES6 code
* Drop TypeScript checking on Jest files
* Identifies an existing usage of ES7 includes method in place
where ES6 browsers need to be supported.
* Update App.vue booleans to default to false. Note this doesn't
impact our usage of the search app as we always pass these values
in.
* Drop unused eslintEs6.json configuration file

Change-Id: Ib6f1ef77bf4e27ecdcc54b5fb963818437f8195c
2023-04-13 00:20:44 +00:00
Jon Robson d4a7fb6479 Rearrange setupIntersectionObservers
Update setupIntersectionObservers so it only contains code
that uses observers. Other code is moved to the skin.js entry point
along with other features.

Change-Id: Ia11b4e07f899426687c616ce2054e0df9d36ab7c
2023-04-12 17:39:36 +00:00
jenkins-bot 86256aa162 Merge "Consolidate and fix eslint errors, dropping ts-ignores" 2023-04-12 17:16:19 +00:00
Translation updater bot 8f60a74e5a Localisation updates from https://translatewiki.net.
Change-Id: I230c98500c5a5b1c04a214e059e07237a9f96082
2023-04-12 08:46:54 +02:00
Jon Robson 87dd101a69 Consolidate and fix eslint errors, dropping ts-ignores
* Upgrade @wikimedia/types-wikimedia to allow us to drop several
@ts-ignores
* Merges eslint rules now that ES6 is default everywhere
* Runs autofix command
* Fixes various prefer-const errors

Change-Id: Iee5bcb93f10a76d80dbeec813f6387c13438263e
2023-04-11 16:56:31 -07:00
Jon Robson c3e57e0ecd Merge skins.vector.es6 into skins.vector.js
With T178356 ES6 is the default, so these can now be
managed in the same module. Keeping them in the same module
will hopefully allow us to make more optimizations on the long
term.

Change-Id: I3fe9e50143b85b4cdc3d9171a60c3720a7c26b4b
2023-04-11 23:18:46 +00:00
Jon Robson 96baf5db50 Eslint: Modernize tests for ES6
Change-Id: I3600afd2eeacddc8e1c983eaad0a96e0755c7ba5
2023-04-11 23:18:38 +00:00
jenkins-bot c4fc73465f Merge "Refactor: Separate A/B test configuration from site configuration" 2023-04-11 23:10:54 +00:00
Jon Robson 28ada2dc78 Refactor: Separate A/B test configuration from site configuration
Making it easier to add configuration variables to JavaScript
in future. This will be used for the pointer indicator.

Change-Id: I65396a3867e7e92d7385ebaa573fb48105ecb9fd
2023-04-11 22:40:45 +00:00
Translation updater bot bd0201e9df Localisation updates from https://translatewiki.net.
Change-Id: Ie6edb2ee47ea24c8b37b505522c87b055712f441
2023-04-11 09:16:21 +02:00
Jon Robson dd146468ff Bundlesize: Document JS bundles
Change-Id: Iceed7fe32110ae3d8d88f1df389710eeee394106
2023-04-10 14:35:40 -07:00
Translation updater bot d30a0eb4e3 Localisation updates from https://translatewiki.net.
Change-Id: I4c366d5b80cfd0e5fd3fe396de1c3a08e54fe764
2023-04-10 09:51:23 +02:00
jenkins-bot 161bf3ce7d Merge "Special Search: Improve the search layout and search preview widths on tablets" 2023-04-07 12:48:17 +00:00
Translation updater bot 01b24c64a8 Localisation updates from https://translatewiki.net.
Change-Id: I073fc1fcffce1db28bbb40d4a43e9397463741d4
2023-04-07 09:38:03 +02:00
jenkins-bot b3a59090e2 Merge "Remove vector-feature-page-tools-enabled class" 2023-04-06 15:12:33 +00:00
jenkins-bot 45b66e9fd1 Merge "Follow-up to 6e8a98ca removing checkbox.js" 2023-04-06 15:11:00 +00:00
Simone Cuomo 64141c1f4a
Special Search: Improve the search layout and search preview widths on tablets
- [x] Add skin specific styles

Bug: T323843
Change-Id: I69fe0e4df2ec13fea2b4a5bc76881505b8bd8cf3
2023-04-06 10:59:14 +01:00
Translation updater bot fa6d23e1f3 Localisation updates from https://translatewiki.net.
Change-Id: If71a0f28753c71e15e683ed191416ecf2efee77d
2023-04-06 09:26:58 +02:00
Jan Drewniak 40130dbf5f Follow-up to 6e8a98ca removing checkbox.js
Removes checkbox.js and related styles as well
as rules for #mw-sidebar-checkbox which was removed
in a previous patch.

Bug: T332090
Change-Id: I168c1161a1d3365e79c2ff6b1c2ab5455f7c4c00
2023-04-06 01:01:21 -04:00
bwang 2bc51bef44 Clean up cached grid CSS from moving the Header
Can be merged after 04/07
Follow-up: I038fc17cbb88a29dbe8d7841b824761a91d38405

Bug: T332449
Change-Id: I8bfee300fe9d164143dbf1acac26015e9ca4df89
2023-04-05 23:29:05 +00:00
jenkins-bot 16dc80fdd1 Merge "Remove custom checkbox-hack implementations" 2023-04-05 22:52:40 +00:00
bwang ac73b57465 Follow-up: add border to zebra header
Bug: T332449
Change-Id: I93704a647b6c3d1dfd1741f223379019816a60e6
2023-04-05 16:25:15 +00:00
Translation updater bot 11a1bc0b97 Localisation updates from https://translatewiki.net.
Change-Id: I36183874de246302a46e160c4be0b2231d3d639d
2023-04-05 09:10:17 +02:00
jenkins-bot 093527a92d Merge "Remove Vector2022PreviewPages configuration" 2023-04-04 22:44:13 +00:00
Jon Robson 146de6396e Remove vector-feature-page-tools-enabled class
Bug: T332090
Change-Id: I8d20cc4f5db3d2a612fecf03dce6eaa99e1ef2a7
2023-04-04 15:16:05 -07:00
ksarabia d983dadab4 Remove Vector2022PreviewPages configuration
Remove Vector2022PreviewPages configuration in Hooks and Skin.json.

Bug: T332797
Change-Id: I2c28a4e253b4dc17578793e1e4ce73e80392d08c
2023-04-04 17:07:04 -05:00
jenkins-bot 639cf4ae07 Merge "Implement new zebra design for the header under the flag" 2023-04-04 22:00:58 +00:00
bwang 070349dd2e Remove Storybook and jsdoc and its dependencies
Bug: T321102
Depends-On: Ia21c14f72631e607e0d626408557eacb83529a03
Change-Id: I3535398826e67825965c024805fd5e921fe5298c
2023-04-04 21:27:45 +00:00
bwang 628804871e Implement new zebra design for the header under the flag
Bug: T332449
Depends-On: Ia21c14f72631e607e0d626408557eacb83529a03
Change-Id: I9a7d6fac7c44be1983281a44766d34a16f515b40
2023-04-04 21:27:31 +00:00
jenkins-bot 4994a6df8e Merge "Adjust table of collapsing auto-collapse algorithm for articles with few top level sections" 2023-04-04 16:19:00 +00:00
Jan Drewniak 6e8a98ca8b Remove custom checkbox-hack implementations
Removes several styles that were used for
expanding/collapsing the table of contents at narrow
widths for non-js users as well as the main menu
for no-js users.

Existing `.vector-menu-checkbox` styles address this
use-case with the addition of a display:none rule for the
two affected checkboxes.

Related to the Page Tools clean-up since these styles
were once scoped to the .vector-page-tools-disabled
class.

Bug: T332090
Change-Id: I13efd4a87bacecb0e9f5a5e44d5e15861d632c62
2023-04-04 10:01:09 -04:00
jenkins-bot 5d4115fdcd Merge "build: Updating npm dependencies" 2023-04-04 13:33:32 +00:00
Moh'd Khier Abualruz 098811f200 Adjust table of collapsing auto-collapse algorithm for articles with few top level sections
Bug: T333021
Change-Id: I9eef0fc0715f5f1917c205b7b7987b0ed76f31a2
2023-04-04 10:35:12 +02:00
Translation updater bot 0e0787f95c Localisation updates from https://translatewiki.net.
Change-Id: I86099aa00f585c860904497e2efc9e9b2501d3b6
2023-04-04 09:19:49 +02:00
Umherirrender d2b8ce8a3e build: Updating npm dependencies
* eslint-config-wikimedia: 0.22.1 → 0.24.0
* grunt-banana-checker: 0.9.0 → 0.10.0
* @wikimedia/codex: 0.7.0 → 0.8.0
* @wikimedia/codex-icons: 0.7.0 → 0.8.0
* @wikimedia/codex-search: 0.7.0 → 0.8.0
* @wikimedia/mw-code-qunit: 6.4.1 → 7.0.0

Change-Id: I3982576a6e8e932efa0ae00be58af343b29ef59c
2023-04-03 23:44:22 +02:00
bwang 2121a05012 Fix sticky header search
Follow up to fix bug introduced in: I038fc17cbb88a29dbe8d7841b824761a91d38405

Bug: T332449
Change-Id: I5cc6cabb766a744e103d48abc380dda509edc936
2023-04-03 19:23:13 +00:00
Translation updater bot bdab7d37ff Localisation updates from https://translatewiki.net.
Change-Id: Iba4d0897fa4a34fff2726cebed1d74a454b0d6cb
2023-04-03 09:22:08 +02:00
jenkins-bot 6a2204682a Merge "icons: Remove unnecessary code from SVG files" 2023-04-01 12:42:23 +00:00
thiemowmde f32daab81a icons: Remove unnecessary code from SVG files
The extra complexity provided by these SVG source code constructs is
apparently not needed. They look the same as before.

Change-Id: Iff2ef6b8549d182655b6eb1f3f93d0389e1b4c6b
2023-04-01 12:23:11 +00:00
jenkins-bot 206138f241 Merge "Remove custom sidebar config" 2023-03-31 23:28:01 +00:00
jenkins-bot edc75c5d8f Merge "Setup header and sticky header to be able to be full width" 2023-03-31 18:50:54 +00:00
Jan Drewniak 15be8a0340 Remove custom sidebar config
Removes configuration for
1. Custom sidebar pinning
2. Default sidebar visibility for logged in & anons

The first config is no longer necessary because
the main menu now uses the pinnable header for
showing/hiding and persisting it's state.

The second config is no longer necessary since
the Page Tools menu moves many sidebar items into
a different location.

Bug: T332090
Change-Id: Iaf25237757dc1e43e096b8c5991e9dd31ad25c2d
2023-03-31 13:09:04 -04:00