Commit graph

3052 commits

Author SHA1 Message Date
jdlrobson 64ee622c73 Validate the value of VectorWebABTestEnrollment
The generation of JavaScript will throw a RuntimeException
making it obvious when an invalid A/B test has been setup.

Bug: T297662
Change-Id: I75b0e923463bf52f8fc5b5c6b7f9baf586053154
2021-12-14 22:22:26 +00:00
Translation updater bot 0cbf9c61d9 Localisation updates from https://translatewiki.net.
Change-Id: Ia395437065234bf77bbe5c6910382996fb18ed98
2021-12-14 08:44:20 +01:00
Clare Ming 60553ff324 Prevent A/B test enrollment hook from firing for unsampled
Bug: T297662
Change-Id: Ibeca32a3c0fab7de403d69ea274c653cf4bd6c0e
2021-12-13 17:31:17 -07:00
Nicholas Ray 3187fa41ad Close .vector-menu-dropdown menus in modern Vector beforeunload
Per T295085, because of the checkbox hack, these menu would stay open
when navigating back to a page.

Bug: T295085
Change-Id: Ief9523030384b4bcaa00379988e2042b4d177dcc
2021-12-13 17:24:44 -07:00
jdlrobson 983437312b Don't add language button to sticky header on pages without languages in content
In Commons languages appear in sidebar.
The language button shouldn't show in the sticky header on these wikis

Bug: T297362
Change-Id: I17d283a7c0ad20bdcaf39b234a7fe766880ab28a
2021-12-13 20:04:50 +00:00
Translation updater bot 326a9db5e3 Localisation updates from https://translatewiki.net.
Change-Id: Ic347171aa298f0f3befccf52a8e14fdaa5faf7a7
2021-12-13 08:24:32 +01:00
Kosta Harlan 23bfd3ff36 Add composer test:size as shortcut bundle size test
Change-Id: Id3c6519eba22babd694cc5fdf3ca85bd44ba7df4
2021-12-10 19:59:19 +00:00
jenkins-bot 1ceb673578 Merge "Move bundlesize test to MediaWikiIntegration test" 2021-12-10 19:55:16 +00:00
Clare Ming dfa649741d Fix format of VectorWebABTestEnrollment
mw.experiments.getBucket expects buckets to map to numbers

Bug: T295972
Change-Id: Ie3e35f78a42ed633ad2f26a72ad87a8bf190fc51
2021-12-10 12:18:49 -07:00
jenkins-bot dc6bd9af95 Merge "Remove need for html-class template property" 2021-12-10 18:03:22 +00:00
jenkins-bot 2e492515b3 Merge "Add language switching alert in sidebar for language in header" 2021-12-10 17:04:06 +00:00
jdlrobson ca501bb581 Remove need for html-class template property
Follow up to 9dcfc1f

This simplifies the template by removing the need for the html-class.
The font-size can be provided to the entire content area meaning we don't
need the link-only class

Change-Id: Id5c49358f6ec007b3205ee390cf68334a1e56de5
2021-12-10 08:40:01 -08:00
Kosta Harlan 6270246d44 Move bundlesize test to MediaWikiIntegration test
The main motivation is to reduce runtime by not invoking an unneeded
Selenium test phase in Quibble, which currently needs about 1 minute to
install npm dependencies.

Depends-On: Ieb7591f3c0ac843677a2a61b4ad47f920fc2ca2d
Bug: T255149
Change-Id: I0563421b3a3d3e6e81abec987c266ade275b47a1
2021-12-10 08:48:59 +01:00
Translation updater bot fd690f36fe Localisation updates from https://translatewiki.net.
Change-Id: I5762622cf9946d309fedaa4efabe98d4d13567c7
2021-12-10 08:27:43 +01:00
Clare Ming 9dcfc1ff27 Add language switching alert in sidebar for language in header
- Add i18n messages.
- Update relevant data methods in Vector.
- Update sidebar template + styles.
- Add new template partial for sidebar actions.
- Add feature flag to turn on/off alert.

Bug: T295555
Change-Id: I232ce13770917d51495391f4b8d8d1a3a8a7afb8
2021-12-09 16:37:36 -07:00
jenkins-bot cc44e46229 Merge "Define sticky header ULS behaviour" 2021-12-09 23:15:05 +00:00
jdlrobson 51cce2d0d4 Define sticky header ULS behaviour
* It sticks to the header on scroll
* It hides when the sticky header hides

Bug: T296680
Change-Id: I5a4e2ba42e172ea55fbdac8f35ec895f6b2756cd
2021-12-09 22:18:35 +00:00
Clare Ming 454a2845b4 Update A/B test enrollment name
Bug: T292587
Change-Id: Ib4174119e18496139bb942032a2401ebc4d1849f
2021-12-09 13:16:54 -07:00
jenkins-bot d0116e07f9 Merge "Make ULS in header quiet progressive button" 2021-12-09 17:33:03 +00:00
bwang b79290f5c9 Make ULS in header quiet progressive button
Bug: T291286
Change-Id: Id1e056330606b87bafb8f43e7ff28d96290465b4
2021-12-09 15:27:04 +00:00
Translation updater bot 95284c7a8e Localisation updates from https://translatewiki.net.
Change-Id: I5f99067ececef3b9c982a548eeb0e7daf2dfcb05
2021-12-09 08:24:45 +01:00
jenkins-bot a7c16c7f30 Merge "Feature flag language button in main page header" 2021-12-08 23:11:53 +00:00
Nicholas Ray 24a5817315 Feature flag language button in main page header
Per the ticket, when this flag is enabled (and the
VectorLanguageInHeader config is enabled) we want to move the language
button from the bottom of the main page to beside the main page's title.

This config can be toggled with the `languageinmainpageheader` query
param (e.g. `?languageinmainpageheader=1`).

Bug: T293470
Change-Id: I41b4677f80b939810d16907b508ab29936f8629c
2021-12-08 15:11:25 -07:00
Translation updater bot ac917532fa Localisation updates from https://translatewiki.net.
Change-Id: Ib739f6f4dca431f4598c2c802199d23d95b40f10
2021-12-08 08:14:00 +01:00
Clare Ming 43c1fee6b4 Add data-event-name attribute to sticky search icon.
Bug: T296999
Change-Id: I3d5d8534f1946a9e9c876451fb7f7605712827e4
2021-12-07 16:30:15 -07:00
jenkins-bot 662fa2a013 Merge "Align mw.notify() alerts to avoid overlapping sticky header" 2021-12-07 22:38:02 +00:00
jenkins-bot fa5cf0890a Merge "Use sans-serif for figures" 2021-12-07 22:12:00 +00:00
Arlo Breault 4df9857726 Use sans-serif for figures
This matches the .thumb class for the new media structure.

Bug: T287965
Change-Id: I55c2f8fdc6c1b882bd1c7b8411e7aa5c475ead3c
2021-12-07 21:44:21 +00:00
Jan Drewniak aa44696222 Align mw.notify() alerts to avoid overlapping sticky header
Aligns the notifications produced by `mw.notify` so that they don't
obstruct the sticky header or usage of elements inside the sticky header.

Bug: T260338
Change-Id: If00f27ec19e71f6803231678fbb733ffaa6c6aaf
2021-12-07 14:41:46 -05:00
jdlrobson fbc5241c45 [Documentation] Document decision in T293441 in code
Not 100% clear why it works this way so recording.

Change-Id: I8c6eb4c1e17916fe06b071dfc98f1c0d4529731d
2021-12-07 18:48:45 +00:00
Translation updater bot 13744f3bad Localisation updates from https://translatewiki.net.
Change-Id: Ica4ebff670a3734db02776c3e7b993272c7586f6
2021-12-07 08:13:47 +01:00
jdlrobson bb0b3373c7 Mount search to parent node of search form
Follow up to 5dee570cb2.

It seems the mount works slightly different in that it creates a div,
appends by the App element to the element you give it, after
clearing all it's child nodes.

The previous behaviour was that the old element was /replaced/
by the App element.

Bug: T296889
Change-Id: Iee7493c032f4de5389207bba288a1a70e4cd14f3
2021-12-06 22:42:31 +00:00
Translation updater bot 2088dd9793 Localisation updates from https://translatewiki.net.
Change-Id: I901a2fdac5cc80a724e3935b664c0de53a1b5833
2021-12-06 08:22:19 +01:00
jdlrobson d834329e15 [Sticky header refactor] Separate responsibilities
Move A/B test code to AB.js
Consolidate the show/hide code spread across scrollObserver
and stickyHeader by adding a show and hide function.

This is needed to fix T296680

Change-Id: Ia2e0c50278df0dfc1600610f281be20f4cc755c2
2021-12-03 14:30:10 -07:00
Translation updater bot 2bccc4e8d4 Localisation updates from https://translatewiki.net.
Change-Id: I593a9f1928a56147a565cd998f98ad92f95bf96d
2021-12-03 08:44:59 +01:00
jenkins-bot 23ac01428b Merge "Update search box margin in sticky header." 2021-12-02 22:37:36 +00:00
Translation updater bot bee9ef0695 Localisation updates from https://translatewiki.net.
Change-Id: I2e71fc39621751dfc4800dc574c91ae6c4571a69
2021-12-02 08:44:29 +01:00
Clare Ming 37c9a24f75 Update scroll observer to allow event logging
- Permits logging for scroll events without sticky header.
- Update function name to be more precise.

Bug: T292586
Change-Id: I441b4bf81bc4a36a03f0f1c215d86b01dce2911d
2021-12-01 16:12:06 -07:00
Clare Ming f45cd69381 Update search box margin in sticky header.
Bug: T296318
Change-Id: Icc70723a79ca9b2632229226ef43a1d29d025d09
2021-12-01 22:52:30 +00:00
Translation updater bot ca251c25f8 Localisation updates from https://translatewiki.net.
Change-Id: Ifc1ad14f60b9b6d7c983b2993541030fd70c30be
2021-12-01 08:16:56 +01:00
jdlrobson f0ed70d709 Restores language button icon font size
The font size of icons should never be changed. Since it's also a span

Bug: T296212
Change-Id: I8bf4e9a7d43a9e5206d3ff6d89e2c3f74fa0d25a
2021-12-01 01:08:49 +00:00
Translation updater bot 0b232afc06 Localisation updates from https://translatewiki.net.
Change-Id: Ibc1f508538927b4bf8bef1aabd46b69a21c0042a
2021-11-30 08:24:03 +01:00
vladshapik 262a520a2c Avoid using User::getOption
Remove using of User:getOption since this method
will be hard-deprecated. Now it is soft-deprecated.

Bug: T296083
Change-Id: I3194a9c1c5c70592f88bc4dbedc78846d1141768
2021-11-29 23:46:05 +00:00
jenkins-bot 8c19f565d1 Merge "Update style for page title in sticky header" 2021-11-29 23:11:58 +00:00
jenkins-bot 0b8c30cc25 Merge "Update sticky header height." 2021-11-29 22:56:37 +00:00
Translation updater bot abecd7b66d Localisation updates from https://translatewiki.net.
Change-Id: I782ae1872950d14a6320b31d8cd95c8ebdc646d3
2021-11-29 08:14:31 +01:00
Translation updater bot 6d7ba2bca6 Localisation updates from https://translatewiki.net.
Change-Id: I7df367a116031aee0ce653ce3c04ac84cbef2e70
2021-11-25 09:04:24 +01:00
Clare Ming d8eff021e1 Update sticky header height.
Bug: T296321
Change-Id: Ic8efa9404282a98aee37dcf9ba33a0b26d6abaff
2021-11-24 14:20:31 -07:00
Clare Ming 101c438c02 Update style for page title in sticky header
Bug: T296320
Change-Id: I0deabfb598e92f07296824c94a9c7c81daefe486
2021-11-24 13:59:16 -07:00
jenkins-bot 1c96e32b6f Merge "Remove unused markup icon" 2021-11-24 20:21:55 +00:00