Commit graph

2895 commits

Author SHA1 Message Date
jenkins-bot 97c3674d22 Merge "Reset scroll position when sticky header search input receives focus to fix Safari bug" 2022-01-07 01:30:45 +00:00
Nicholas Ray 416f4c3284 Use explicit line height for user menu items
IE11 doesn't support the `initial` value which results in hidden user
menu item text. Instead set an explicit value.

Bug: T298746
Change-Id: I89511419b2d2c753be96f9c1eb842ef80623bce7
2022-01-06 17:52:15 -07:00
jdlrobson 99cf6eb5be Restore gadget support to new internal skins
For vector-2022 skin:
* MediaWiki:Vector.css and MediaWiki:Vector.js are added via the
existing ResourceLoader hook.
* User:<name>/vector.js and User:<name>/vector.css are added via new
VectorResourceLoader modules

Bug: T297758
Change-Id: I37e9a9d353695502213c7a651530995252d9505f
2022-01-07 00:18:17 +00:00
jdlrobson 7d2d50873f Vector is split into 2 skins
A new vector-2022 skin is added. This will be the eventual home
of the new Vector skin when we are ready to migrate.

Please see SkinVector class for the migration plan to simulate this
as part of testing.

Bug: T291098
Change-Id: Ibaddf94a5bfb5e21bbbaf1e0aa1b343a3f566d2d
2022-01-06 15:52:10 -08:00
Nicholas Ray 17e742e2ab Reset scroll position when sticky header search input receives focus to fix Safari bug
I haven't found any code responsible for making the scroll position
jump. It looks like Safari is doing this on its own. Looking at the
focus event in detail [1], it looks like there is an `preventScroll`
option you can pass to .focus() which might help in this situation, but
unfortunately, Safari doesn't seem to support this. Therfore, a hack
like this may be necessary.

[1] https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/focus

Bug: T297636
Change-Id: I90651293b7dd0f7f2970ba06255a12617b43661f
2022-01-06 15:30:21 -07:00
bwang dca94de026 Fix caction menu button from having a width that's 1px too small
Bug: T294883
Change-Id: Ibda07f60d8e94305d36a6bdc2c095b1a93dd6cba
2022-01-05 20:55:43 +00:00
jenkins-bot 42fec59f54 Merge "Refactor search component expand behavior and add auto-expand-width prop to search component" 2022-01-05 17:52:35 +00:00
Translation updater bot 142d6614c5 Localisation updates from https://translatewiki.net.
Change-Id: I0694072b377f82a537b5128518e31a281e801c5a
2022-01-05 08:17:28 +01:00
Nicholas Ray 3028a4f9d8 Refactor search component expand behavior and add auto-expand-width prop to search component
In preparation for I30c670e3f195f77a27715c6b494a3088b7a55712, refactor
the search component expand behavior so that it can accomodate the new
changes in WVUI while maintaining backwards compatibility with the
status quo.

Additionally, pass/enable the `auto-expand-width` prop to the main
header's search. This will be inert until the new changes in WVUI have
landed.

Bug: T297531
Change-Id: Id8d3bd4aa74113b91ecaf66cb58cf5625db8a302
2022-01-04 15:14:49 -07:00
jenkins-bot dce2ea9566 Merge "Update Abkhaz language name" 2022-01-04 17:01:02 +00:00
Translation updater bot b1ec274b4a Localisation updates from https://translatewiki.net.
Change-Id: I34f31ccaa68a80a2878b0a6407eeb43acc80ce55
2022-01-04 08:29:39 +01:00
Translation updater bot b302054e98 Localisation updates from https://translatewiki.net.
Change-Id: Ife2af7ef89bd703abb02e83c2678e21b30bdb92e
2022-01-03 08:13:01 +01:00
Translation updater bot c7966b2041 Localisation updates from https://translatewiki.net.
Change-Id: I3514243feb90ac9831d4188a30cba788f12ddab1
2021-12-30 09:39:22 +01:00
Translation updater bot 2d8246e11f Localisation updates from https://translatewiki.net.
Change-Id: Ic9b33e22bad39df40bdab2225c7a8ad6681a5542
2021-12-27 09:33:10 +01:00
Amir E. Aharoni b064c131d6 Update Abkhaz language name
Bug: T298309
Change-Id: I735da5e1ce214fa41d4401274daa3ad361987344
2021-12-25 14:08:46 +02:00
Translation updater bot 939c89a72b Localisation updates from https://translatewiki.net.
Change-Id: I1807c6fa10d4d9d82266875481dccd8137ab493a
2021-12-24 09:11:05 +01:00
Translation updater bot 69a91758a0 Localisation updates from https://translatewiki.net.
Change-Id: Ibe92055267945b84e3d6f4389940387bc52b8aa2
2021-12-23 08:39:55 +01:00
jenkins-bot eccf02edfc Merge "Fix dependencies for debug mode" 2021-12-22 15:35:23 +00:00
Translation updater bot 289bcb291f Localisation updates from https://translatewiki.net.
Change-Id: Id18884c6f2cdac1d466e458af9ea7811e33ce55e
2021-12-22 08:35:37 +01:00
bwang 80141b61c9 Use core checkbox hack consistently for all dropdown and provide custom JS enhancements for the sidebar button
Depends-on: Id74a80cda6cf460cc2b579269b8d5b2ce81c8ca5
Change-Id: Ibd9518dab78d1d9a541b501d920fe3bd4d362093
2021-12-21 23:33:59 +00:00
jdlrobson d8010c321a Fix dependencies for debug mode
Saw Query.Deferred exception: mw.user.getId is not a function
when using debug mode due to missing dependency

Change-Id: I9ff89e5632da6941bce77b079dee36f47a5fbcc8
2021-12-21 23:00:12 +00:00
jenkins-bot af2b4a0da4 Merge "Add watchstar to sticky header (alternative)" 2021-12-21 19:30:28 +00:00
bwang bd799ecc2e Add watchstar to sticky header (alternative)
Bug: T294759
Depends-on: I88af8585e8fc75f77ebef867d267199aeb2c6592
Change-Id: I15c409830ef8970ff7319b4dd447904443949b8d
2021-12-21 09:40:48 -08:00
Translation updater bot 6de9169227 Localisation updates from https://translatewiki.net.
Change-Id: Id3e18de503799587a52dc82cf2308d2f02060dc9
2021-12-21 08:13:30 +01:00
Translation updater bot 4e8585957e Localisation updates from https://translatewiki.net.
Change-Id: I600452529ab340aa8448db1550444cd819d3fe54
2021-12-20 08:23:34 +01:00
jdlrobson 9444bc3e86 DRY up mw-ui- class generation
Repeated in multiple places now, making it harder to change
button/icon classes.

Change-Id: I3799d065ac0c4ccdc900cbebe9140fb8ea657008
2021-12-17 10:06:46 -08:00
Translation updater bot 9684566e4f Localisation updates from https://translatewiki.net.
Change-Id: Ifb5acda88572da10dff699f2769c5708c898b7da
2021-12-17 08:19:03 +01:00
jenkins-bot c6691a191d Merge "Disable table of contents in article body" 2021-12-17 00:17:16 +00:00
jdlrobson ef59d7b973 Disable table of contents in article body
This will currently remove table of contents in article body
for legacy and modern skin.

To prevent us deploying this in current form, a check is
added in generateHTML

This requires an adjustment of OverridableConfigRequirement to
support requirements which do not vary on whether the user is
logged in or not.

Bug: T297610
Change-Id: I847a284229e498b3aa04c16ea3f84c360e735052
2021-12-16 16:11:05 -07:00
jenkins-bot 44ef14574f Merge "Drop language A/B test bucketing check" 2021-12-16 22:00:45 +00:00
jdlrobson 5a8a3d0d13 Drop language A/B test bucketing check
The existence of this code means we can't safely use this service
inside the skin's constructor.

We no longer need this, so that's fine.

Change-Id: Iffd82c00030c4cf1238a931dc971ffb4686d2620
2021-12-16 12:15:47 -08:00
jdlrobson d79dbf37c9 Don't use ts-ignore. It is hiding real errors
We are passing the wrong arguments to
addVisualEditorHooks

Bug: T297119
Change-Id: I2f8ced4513a1e5fcca2a2a2393cbb8fd7a3db388
2021-12-16 10:27:42 +00:00
Translation updater bot d20e32f8d1 Localisation updates from https://translatewiki.net.
Change-Id: Ie83c6deba7cd2025907768708e9931902ff69d0a
2021-12-16 08:32:28 +01:00
jenkins-bot 9e710f9a96 Merge "Add composer test:size as shortcut bundle size test" 2021-12-16 00:00:23 +00:00
bwang 321e6b19e1 Move watchlist button out of user menu dropdown and adds temporary feature flag
Bug: T289619
Change-Id: I57addbed2ea8ead5d98bce659f3db1f88f8a5094
2021-12-15 23:21:37 +00:00
jenkins-bot d06a4ab2e7 Merge "Update skin authors to include web team" 2021-12-15 23:17:59 +00:00
jdlrobson cae801747f Update skin authors to include web team
Change-Id: I0aa3bf23f8b55b215d5429ced5e47e1395cf69bb
2021-12-15 22:43:45 +00:00
jdlrobson 44aeee5d83 Vector uses html-title-heading
The H1 is available with the correct attributes in core now, so
we can use that instead of our own markup. This also means Vector
will benefit from updates to the heading in core such as main page
special handling.

Bug: T297728
Change-Id: I4d10370678fad6455d73994bf340891760543b71
2021-12-15 22:27:48 +00:00
jenkins-bot 9efaaf8afa Merge "Add feature flag for sticky table of contents" 2021-12-15 18:16:16 +00:00
Translation updater bot 3f269d87e3 Localisation updates from https://translatewiki.net.
Change-Id: Id4ee92cb91fbab971db99918b52972289f0e1f95
2021-12-15 08:10:44 +01:00
jenkins-bot 8357b2c325 Merge "Validate the value of VectorWebABTestEnrollment" 2021-12-14 23:36:21 +00:00
Clare Ming 72fecd41f2 Add feature flag for sticky table of contents
- Add TOC feature requirement.
- Update data for SkinVector.
- Add TOC template.

Bug: T297610
Change-Id: I90bc5e21ba187ac9dd74d5e97763834795a0545b
2021-12-14 16:26:58 -07:00
jenkins-bot b538d23c57 Merge "Close .vector-menu-dropdown menus in modern Vector beforeunload" 2021-12-14 22:53:54 +00:00
jdlrobson 64ee622c73 Validate the value of VectorWebABTestEnrollment
The generation of JavaScript will throw a RuntimeException
making it obvious when an invalid A/B test has been setup.

Bug: T297662
Change-Id: I75b0e923463bf52f8fc5b5c6b7f9baf586053154
2021-12-14 22:22:26 +00:00
Translation updater bot 0cbf9c61d9 Localisation updates from https://translatewiki.net.
Change-Id: Ia395437065234bf77bbe5c6910382996fb18ed98
2021-12-14 08:44:20 +01:00
Clare Ming 60553ff324 Prevent A/B test enrollment hook from firing for unsampled
Bug: T297662
Change-Id: Ibeca32a3c0fab7de403d69ea274c653cf4bd6c0e
2021-12-13 17:31:17 -07:00
Nicholas Ray 3187fa41ad Close .vector-menu-dropdown menus in modern Vector beforeunload
Per T295085, because of the checkbox hack, these menu would stay open
when navigating back to a page.

Bug: T295085
Change-Id: Ief9523030384b4bcaa00379988e2042b4d177dcc
2021-12-13 17:24:44 -07:00
jdlrobson 983437312b Don't add language button to sticky header on pages without languages in content
In Commons languages appear in sidebar.
The language button shouldn't show in the sticky header on these wikis

Bug: T297362
Change-Id: I17d283a7c0ad20bdcaf39b234a7fe766880ab28a
2021-12-13 20:04:50 +00:00
Translation updater bot 326a9db5e3 Localisation updates from https://translatewiki.net.
Change-Id: Ic347171aa298f0f3befccf52a8e14fdaa5faf7a7
2021-12-13 08:24:32 +01:00
Kosta Harlan 23bfd3ff36 Add composer test:size as shortcut bundle size test
Change-Id: Id3c6519eba22babd694cc5fdf3ca85bd44ba7df4
2021-12-10 19:59:19 +00:00