Commit graph

4997 commits

Author SHA1 Message Date
jenkins-bot 533b83a863 Merge "test: Add PHPUnit tests for LanguageService" 2024-02-12 17:06:07 +00:00
Jon Robson 2b4b256d4e Callback should only be run after completion of API save request
Bug: T357212
Change-Id: Icee40b8f9b642e516583998f98cf0072a9e37dee
2024-02-12 08:52:46 -08:00
Doğu Abaris 1b692aef4d test: Add PHPUnit tests for LanguageService
Adds tests for LanguageService in Vector skin.
Covered:
- `testConstruct`: Validates property initialization.
- `canWordsBeSplitSafely`: Tests that the language is splittable or not.

Change-Id: Icc1c269c56e0e53c624074516aee95ba242a55d7
2024-02-12 16:25:43 +00:00
jenkins-bot e3e458cb87 Merge "Add PHPUnit tests for VectorComponentMenu" 2024-02-12 16:07:33 +00:00
Translation updater bot 235f873530 Localisation updates from https://translatewiki.net.
Change-Id: I7aa739b484ecb830361a79897d725e15f5c388fa
2024-02-12 14:52:34 +01:00
Doğu Abaris 71f9552bb2 Add PHPUnit tests for VectorComponentMenu
Adds tests for VectorComponentMenu in Vector skin.
The test suite includes the following validations:
- Constructor initialization with expected parameters and behaviors.
- Validate counting logic for menu items.
- Validates `getTemplateData` method's output for correctness.

Change-Id: Ia52aa70e9213f6627d063d520fdbb2e353f0bfcb
2024-02-10 09:16:39 +00:00
Doğu Abaris fab1b342e0 Add PHPUnit tests for VectorComponentMainMenu
Adds tests for VectorComponentMainMenu in Vector skin.
The test suite includes the following validations:
- Constructor initialization with expected parameters and behaviors.
- Correct identification of 'is-pinned' state
- Inclusion of data for first portlet and rest portlets
- Handling of pin/unpin actions and language alert considerations
- Proper integration of menu elements based on user and feature flags

Change-Id: Ie408ff668893d1de2cf9dd1211a9c82c0b882f99
2024-02-10 01:38:59 +00:00
Doğu Abaris f1c6c828a9 Add PHPUnit tests for VectorComponentMainMenuAction
Adds tests for VectorComponentMainMenuAction in Vector skin.
The test suite includes the following validations:
- Constructor initialization with expected parameters and behaviors.
- Validates `getTemplateData` method's output for correctness.

Change-Id: I5deda64dc1bd3db85df69d0bb5a5a27f6fb8c1ff
2024-02-10 01:38:47 +00:00
jenkins-bot 64218333de Merge "Add PHPUnit tests for VectorComponentLanguageDropdown" 2024-02-10 00:58:44 +00:00
Doğu Abaris 6212b8feac Add PHPUnit tests for VectorComponentLanguageDropdown
Adds tests for VectorComponentLanguageDropdown in Vector skin.
The test suite includes the following validations:
- Proper handling based on page type (subject/talk).
- Correct labeling and icon selection.
- Accurate class and aria label configuration.

Change-Id: I145cb250c513f3f81e780195485907897788f5c4
2024-02-10 00:20:12 +00:00
jenkins-bot 76f8f7419b Merge "Add PHPUnit tests for VectorComponentDropdown" 2024-02-09 19:59:15 +00:00
jenkins-bot ec90e77f89 Merge "Add PHPUnit tests for VectorComponentClientPrefs" 2024-02-09 19:51:07 +00:00
jenkins-bot 72467ee757 Merge "Add PHPUnit tests for VectorComponentButton" 2024-02-09 19:23:15 +00:00
Translation updater bot dc6201ce6e Localisation updates from https://translatewiki.net.
Change-Id: I43ccc398fc0bc481e850d2a51d85c56d30cfb682
2024-02-09 08:45:57 +01:00
jenkins-bot 5fc7f5d360 Merge "Add PHPUnit tests for VectorComponentPinnableHeader" 2024-02-09 01:22:25 +00:00
jenkins-bot a96dcb1099 Merge "Truncate long usernames with an ellipsis" 2024-02-08 19:23:53 +00:00
jenkins-bot 5a24f61c3b Merge "Fix extra space from pinned sticky container" 2024-02-08 17:45:21 +00:00
bwang de4b9faeba Fix extra space from pinned sticky container
VISUAL CHANGE:
* The gap between the title and the text "From mediawiki"
decreases - this is an improvement.

Bug: T357022
Change-Id: I436171448ca69413a004024157b24d502aa63bea
2024-02-08 17:11:47 +00:00
bwang 5012f7fff0 Zebra selector clean up
Change-Id: I6a942913ae2fec066b97c1824a09bb07a8eeef45
2024-02-08 10:49:49 -06:00
Translation updater bot 24a4594047 Localisation updates from https://translatewiki.net.
Change-Id: I4f0294a4fbedad91d20b3ea95168ebfe8d033964
2024-02-08 09:18:25 +01:00
Jdlrobson 98817085b7 Changes to list spacing
Update <p> spacing to improve consistency of ul/ol spacing,
also update heading spacing to be more consistent,
relying on mw defaults more

This reverts commit 8d3bda7867.

Bug: T352875
Change-Id: I46bf5e3713b4648e9c3facf5e927e924ba51b23f
2024-02-07 20:21:17 +00:00
Doğu Abaris cd032f4c4c Add PHPUnit tests for VectorComponentDropdown
Adds tests for VectorComponentDropdown in Vector skin.
The test suite includes the following validations:
- Correct template data generation.
- Proper label, tooltip, and icon handling.
- Accurate CSS class construction for various states.

Change-Id: Iafd28cfe62eb4b8c6039f819b9d8f005b0b32d48
2024-02-07 10:40:26 +00:00
Doğu Abaris 4b1a4726a0 Add PHPUnit tests for VectorComponentClientPrefs
Adds tests for VectorComponentClientPrefs in Vector skin.
The test suite includes the following validations:
- Both pinned and unpinned states
- Correct structuring of 'data-pinnable-header'

Change-Id: I745559b2f738b4bed0f152fc8de3af1653b96ecd
2024-02-07 10:18:11 +00:00
Translation updater bot 6114ad8114 Localisation updates from https://translatewiki.net.
Change-Id: I1f89531d09cc6480f721384934d726be43743044
2024-02-07 08:29:34 +01:00
Doğu Abaris 880ae42fde Add PHPUnit tests for VectorComponentButton
Adds tests for VectorComponentButton in Vector skin.
The test suite includes the following validations:
- Various button configurations and expected CSS classes.
- Accurate template data for label, icon, href, and custom attributes.
- CSS classes according to weight, action, and iconOnly.

Change-Id: I228c197e5adee59a79ab6e2aad74ff0f18ef6b38
2024-02-07 00:21:14 +00:00
Doğu Abaris 4775215a5c Add PHPUnit tests for VectorComponentPinnableHeader
Adds tests for VectorComponentPinnableHeader in Vector skin.
The test suite includes the following validations:
- Correct template data generation based on constructor parameters.
- Accurate label generation from MessageLocalizer.
- Conditional logic for 'moveElement' affecting container ID attributes.

Change-Id: I2412c86e08dfca088ca57330b4dd078c212513f9
2024-02-07 00:11:15 +00:00
Doğu Abaris be11774875 Add PHPUnit tests for VectorComponentPinnableContainer
Adds tests for VectorComponentPinnableContainer in Vector skin, ensuring:
- Proper initialization with ID and pin status.
- Correct template data based on init params.
- Consistent template data for pinned/unpinned states.

Change-Id: Iec33c11b0afbe2bea5b6708b83b9ea618f7e809b
2024-02-06 23:41:35 +01:00
Doğu Abaris 8353c535c6 Add PHPUnit tests for VectorComponentPinnableElement
Adds tests for VectorComponentPinnableElement in Vector skin, ensuring:
- Proper instantiation with an ID parameter.
- Correct return of template data containing the ID.
- Reliability in handling element ID for use in templates and UI.

Change-Id: I3758f042ad43b90ee94a3b5aa14537fa1b0657d1
2024-02-06 23:41:35 +01:00
Doğu Abaris 2414a69730 Add PHPUnit tests for VectorComponentLink
Adds tests for VectorComponentLink in Vector skin, ensuring:
- Initialization with parameters.
- Generation of html-attributes string with title and aria-label.
- Consistency in link attributes for accessibility and UX.

Change-Id: I80b8a84d1d10bc7274ba5267910206d7f6e68534
2024-02-06 23:41:35 +01:00
Doğu Abaris b4064a5aa5 Add PHPUnit test for LoggedInRequirement
Change-Id: I9724513399bc3d2c1b62365fdad13d51ce68623b
2024-02-06 04:09:04 +01:00
jenkins-bot 8dff67dc05 Merge "Refactor and clean up FeatureManagement classes" 2024-02-06 01:08:37 +00:00
Doğu Abaris 348e6f6cc8 Refactor and clean up FeatureManagement classes
This commit introduces several changes to improve the structure and
readability of the FeatureManagement code in the Vector skin. Key
changes include:

- In ABRequirementTest.php, improved test method names for clarity.
- In ABRequirement.php, simplified property declarations and cleaned up
  code structure.
- In DynamicConfigRequirement.php, cleaned up property declarations.
- In LimitedWidthContentRequirement.php, cleaned up property
  declarations and added type hints.
- In LoggedInRequirement.php, cleaned up property declarations.
- In OverridableConfigRequirement.php, cleaned up property declarations.
- In OverrideableRequirementHelper.php, cleaned up property declarations.
- In SimpleRequirement.php, cleaned up property declarations.
- In UserPreferenceRequirement.php, cleaned up property declarations.

Each change aims to enhance the codebase's maintainability and
understandability. No functional changes were introduced.

Change-Id: I23283c5a6799b1f03a6a9b5832c34c7dbbcca527
2024-02-06 00:37:14 +00:00
bwang e964cbb785 Add Vector night mode feature flag
Bug: T355065
Change-Id: Ica63eb61ee042e8684168f6787b27a5e58e38bee
2024-02-05 11:33:37 -08:00
Translation updater bot 1c2dc9cbd3 Localisation updates from https://translatewiki.net.
Change-Id: Ie5e2f0e6478c08545f0611771a3b898dda9e905d
2024-02-05 08:52:30 +01:00
James D. Forrester 4deefe4d17 build: Upgrade mediawiki/mediawiki-phan-config to 0.13.0
Change-Id: Iee9d20b4ada7e2dde4f9ef5bef744ed429f92397
2024-02-02 11:03:38 -05:00
Translation updater bot 53f50f3c44 Localisation updates from https://translatewiki.net.
Change-Id: Iacbed6381d0b321fa34ed57cf621e3174ee77417
2024-02-02 08:56:28 +01:00
Ed Sanders 1637b2bbdf Truncate long usernames with an ellipsis
Bug: T356349
Change-Id: I386a8f2165cb29e06e1752050bbd595eae134492
2024-02-01 18:58:46 +00:00
Umherirrender 4c5d039f13 Add return type hint to function in ServiceWiring.php
This is a common pattern for service wiring functions

Change-Id: Ia7bb6e22ca56aa263288fbf3afed5fb3c5d2df1a
2024-02-01 19:51:03 +01:00
Translation updater bot a7052bd7d8 Localisation updates from https://translatewiki.net.
Change-Id: I9e3f0c060b5be32bb17f93dcad52c7f3f5066cbd
2024-02-01 09:08:14 +01:00
jenkins-bot 035e5826df Merge "Register night mode as a client preference" 2024-01-31 19:36:45 +00:00
jenkins-bot 3efce8545a Merge "Client preferences accept a callback" 2024-01-31 19:05:50 +00:00
Jon Robson 63b3a23ead Register night mode as a client preference
The night mode setting should only show up if the feature flag
is enabled.

The messages are currently added to Vector, but we may want to upstream
these to core in future.

Change-Id: Idcd53399fa06821bbf5f463d1a242ecf59442c70
2024-01-31 10:14:30 -08:00
Translation updater bot a1db9c2a86 Localisation updates from https://translatewiki.net.
Change-Id: I22132b46d25262a2deeb17401ddf752747f5bf2e
2024-01-31 08:31:03 +01:00
Jon Robson 29f73c960b Client preferences accept a callback
In the mobile site we want to show a notification when settings
are changed. In some cases we want to reload the page.

Bug: T350170
Change-Id: I71bd97de8e041d641aded02b8fdf84359f6d830b
2024-01-30 12:31:43 -08:00
jenkins-bot 3961cbcfb4 Merge "Deactivate sticky header menus and search when sticky header is hidden attempt 2" 2024-01-30 19:36:34 +00:00
Bernard Wang 8172710236 Deactivate sticky header menus and search when sticky header is hidden attempt 2
This reverts commit 47e58d53d4.

Reason for revert: second attempt at the patch

Bug: T325083
Change-Id: I2190005fcad41ad61bbd02ea3603e222fc58ceb8
2024-01-30 18:14:21 +00:00
Translation updater bot 95bd8fbb82 Localisation updates from https://translatewiki.net.
Change-Id: Ic6cf9d6f3c003e0726f2cf058a5db6ee4539ef94
2024-01-30 09:41:30 +01:00
jenkins-bot 851bc5aecd Merge "Revert "Deactivate sticky header menus and search when sticky header is hidden"" 2024-01-30 02:48:24 +00:00
Jdlrobson 47e58d53d4 Revert "Deactivate sticky header menus and search when sticky header is hidden"
This reverts commit 984a8a03ae.

Reason for revert: For anonymous users this was triggering the
error "Cannot read properties of null (reading 'contains')"

Change-Id: I0bd78d195768c95b188208fa6fbab60fb483ed87
2024-01-30 02:24:15 +00:00
bwang 142591afdc Hide limited width client prefs on screen sizes below 1400
Bug: T355331
Change-Id: Ic32cede70645637bdc887cfef23b1e7385a834a3
2024-01-30 02:14:50 +00:00