3 commits

Author	SHA1	Message	Date
Jon Robson	3dbadabdfe	Document the importance of vector-menu class ... It's used by click tracking so marking with inline comment that we need to be careful if we plan to remove it in our current refactoring. Change-Id: I6aee01363d2d150844e61fb27ab584c8ee78c4ae	2023-01-03 14:45:40 -08:00
Jon Robson	e7b4edf7a6	[Refactor] Rethink Dropdown component ... The Dropdown component should be considered the dropdown folder going forward. This should be distinguished as a different component that composes the Dropdown component Since the template itself is rather simple it seems preferable to have duplicate templates that describe the actual component (PageTools, VariantsDropdown and LanguageButton) MenuDropdown is renamed Dropdown and styles that don't correspond to the Dropdown component are moved to the relevant components. MenuContents mustache template (future component) is added to DRY up several of the new templates. Bug: T320927 Change-Id: I220d0a477b3f05b278bd2cec7dd601c7b3b17c6f	2022-11-29 17:33:03 -08:00
Bernard Wang	15d95fc24a	[Technical] Split up Menu.template, restrict decoratePortletData to legacy Vector ... Changes: * Code is moved from SkinVector to SkinVectorLegacy verbatim since it is now only needed by SkinVectorLegacy so we remove it: ** This step broke MainMenu rendering so this was captured in VectorComponentMainMenu ** The isLegacy code no longer makes sense and is removed in a follow up * storybook no longer run on CI Authors: Bernard Wang and Jon Robson Bug: T321102 Bug: T319349 Change-Id: Ib424ca1c767161fdae8c0aeedfe662b7fa039ff6	2022-11-02 21:22:50 +00:00