Commit graph

1694 commits

Author SHA1 Message Date
ksarabia c091726265 Address searchbar bug in App.vue
* Removes unused code
* Was breaking App.vue

Follow up to I2943917db477cd33fab481eaf24e50f6f01ca412

Bug: T379861
Change-Id: Iae9f0d0ea77a100937081794a46cb101a7ca0e31
2024-12-04 18:48:29 +00:00
ksarabia 8b197f417d Remove unused performance metrics
* Removes lines from instrumentation.js

Bug: T379861
Change-Id: I2943917db477cd33fab481eaf24e50f6f01ca412
2024-12-03 13:33:01 -06:00
Jon Robson fdc064f714 Don't load Vue on page load
Loading skins.vector.search.codex.scripts pulls down Vue.js as
its a script-only module. It is not needed to display the appearance
menu so its presence here seems accidental.

Bug: T381030
Change-Id: I42be70b900340c4a3f10e5d31d1827ad9edd5e7a
2024-11-27 11:08:18 -08:00
Seawolf35gerrit 967e9d08c2 Vector: Remove compatConfig from Vue settings
Why:
- After migrating to the regular build of Vue 3, the compatConfig
  settings in component definitions will be ignored.

What:
- Remove compatConfig declarations from all Vue components in this extension.

Bug: T289105
Bug: T363351
Change-Id: I0f4aefd767145dbba8801c6f4111c64918756e8a
2024-11-25 20:02:24 +00:00
Taavi Väänänen 39e3dd7f99
Fix dark mode issue in navbar separator
Fixes the separator bar used in the sticky navbar being a light gray
color on dark mode to be a dark gray instead. The light gray is changed
from #c8c8c8 to #c8ccd1 to match an existing Codex color.

Change-Id: I1638fb268dc7a1bbbe80d46b1f2678aa69ba7679
2024-11-15 17:47:24 +02:00
Msz2001 62fc497b33 Don't copy screen-reader text of icon-only buttons
Bug: T340671
Change-Id: I6430f5d43c280b1e7211e330496b17136867e581
2024-11-12 13:14:40 +00:00
Ed Sanders f63aaf26fe Remove IntersectionObserver fallback
It is always provided by web2017-polyfills in core.

Also remove checks for requestAnimationFrame, which core now
assumes to exist.

Change-Id: Ia9dd0330b45c945cf4aca1ea0d4edadc7308e1fc
2024-11-07 15:53:33 -08:00
jenkins-bot 178e4e12af Merge "Do not show empty user links dropdown in private wikis" 2024-11-05 19:34:54 +00:00
Ammarpad 02dfbd4acb Do not show empty user links dropdown in private wikis
In situations where anon account creation is disabled or when
combined login link would be used, the usermenu array contains
single element (for 'login' or 'login/create') instead of two
elements ('login' and 'create account' items separately)

If $wgWikimediaMessagesAnonDonateLink is enabled through the
WikimediaMessages extension, the third element 'sitesupport'
exists, making the number of anon items either 1 or 2 or 3.

This patch fixes $isDefaultAnonUserLinks variable to account
for all the cases

Additionally, if even login is disabled, the element count can be
zero and in such case we need to hide the dropdown in all cases
(not only on large viewports) because it would always be empty.

This patch passes the userlinks count to ::getDropdown() and adds
CSS class when appropriate to hide the drowpdown completely.

Bug: T332743
Change-Id: I1ce5e1ea30917a6e80ef00f3c1703cbd0ecb6968
2024-11-04 11:35:23 +01:00
Jon Robson fc8513e61a Do not load CodexTypeaheadSearch styles on page load
Move CdxTypeaheadSearch out of render blocking module - it is not
needed - only CdxSearchInput is rendered by default.

Bug: T378636
Change-Id: Id4feb26f73413826cf04ec200d0d501c6b057bfc
2024-10-31 20:34:15 +00:00
Jon Robson 01e50fbda8 Expand documentation on resize event for client preferences
Bug: T375559
Change-Id: I0326de423c18eeeb6bce3cef2dc72fe248695b18
2024-10-24 21:11:12 +00:00
jenkins-bot a9a2b617f5 Merge "Align Vector link styles with Minerva" 2024-10-23 20:33:43 +00:00
ksarabia eb74bc6080 Align Vector link styles with Minerva
To make sure this is code-ified I have added the rule selector-max-specificity
to check specificity and error if we ever attempt to change this and to also
prevent us from writing overly complicated selectors (for now the default is
based on the status quo)
Additional change is required to skinStyle file to accomodate the new rule.

Bug: T373989
Change-Id: I3921d1fb3a098faae8f5a8bdc895783f1b298daa
2024-10-23 03:22:17 +00:00
bwang 476ac6962f Make Donate collapsible into user links dropdown, and make header more responsive
Bug: T375903
Bug: T375901
Depends-on: I52c1dde47fb46bba7cd62d0fa28cba2c77b0c9e6
Change-Id: I48b439f6e6f573172f3d334c1816cf84be675b24
2024-10-16 11:21:56 -05:00
Ebrahim Byagowi c8c1833e16 More effective use of Less in Watchstar.less
And just to make it more similar with
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/skins/MinervaNeue/+/3d1cbeb8/resources/skins.minerva.base.styles/watchStar.less#11

Change-Id: Iefd4ce2982e76c3c34eb4af39b0b9d544ea4d94d
2024-10-12 15:39:23 +03:30
Ebrahim Byagowi 27273a13ac Reverse the watch star animation for RTL
Bug: T376898
Change-Id: I7863cab67702121c95cdb4ecac6dbf7431ebe30f
2024-10-10 17:23:02 +00:00
jenkins-bot 2fe332ffb5 Merge "Disable initial animation of watch star" 2024-10-07 11:23:40 +00:00
Ebrahim Byagowi efa32f293c Disable initial animation of watch star
Bug: T376559
Change-Id: I6a23dbfc6cae125db5ef0e83739593795b7f467c
2024-10-07 00:06:24 +03:30
bwang 5d83c55f5e Update tables code to only target unwrapped tables
Bug: T367248
Change-Id: If4267e083cd6721bdb80d32a84c1fd9306096b50
2024-10-03 13:16:59 -05:00
Jon Harald Søby 6d069498e9 Add cursor:inherit to .mw-selflink
Add `cursor: inherit;` to the class `mw-selflink` to get back
the expected behaviour of these 'links'.

Bug: T375876
Change-Id: I52d54dc1265fd1a64bc461892e69475a3b3d50b2
2024-09-29 21:06:06 +02:00
jenkins-bot 9bba83b53f Merge "Add logging to table wrapping experiment" 2024-09-28 03:00:40 +00:00
bwang 1ccb5be4c3 Add logging to table wrapping experiment
Bug: T374493
Change-Id: I276a58635504cfb30c3bcdec93f6bb29f5df730b
2024-09-28 00:51:46 +00:00
jenkins-bot 72118a48b6 Merge "Fix linter warnings" 2024-09-27 16:16:03 +00:00
jenkins-bot 0c79d70470 Merge "Remove @font-size-base from vector-2022" 2024-09-27 02:58:48 +00:00
bwang dd570d7912 Fix linter warnings
Change-Id: I012a98cb3fcbfaa2ba40d85c0225bcf44deb5c01
2024-09-26 14:24:25 -05:00
obamwonyi d71150f46d component: notheme isn’t respected for text color in automatic night mode
More details. Fix for notheme text color issue in automatic night mode

Bug: T374794
Change-Id: I673c11789ab57fe70ed3557d294da65f6d9cc58d
2024-09-26 18:24:35 +01:00
bwang 25f4bc2a37 Remove @font-size-base from vector-2022
Bug: T367899
Change-Id: I6ec44a10a7bfeb6b03912ca6d5a23eaed046db08
2024-09-26 11:44:57 -05:00
Jon Robson 111b3155e0 Drop support for non-Codex message box styles in Vector 2022 and Vector
Going forward these styles will be provided where needed by
the mediawiki.legacy.messageBox module.

Bug: T360668
Change-Id: I58d9e41f0c98adbd816240b161b5145a667436cd
2024-09-18 21:08:01 +00:00
Ebrahim Byagowi 475f80cf76 Use browser native URL instead of mw.Uri
Bug: T374314
Change-Id: I66be10c017e853ea130b0919789b22c4c3f12622
2024-09-13 07:08:12 +03:30
Jon Robson 3fbf5b49f0 Drop unused code relating to old limited width toggle.
Follow up to Ie2617e2fa83b6a888a7a2799cc39f048731dc60d

Bug: T367591
Change-Id: I270f1902f40946f31de29777735dee2e10ebfebe
2024-09-11 00:12:59 +00:00
Jon Robson ea8660bb60 Cleanup: Remove dark mode banner code
This is not being utilized any more, tested or maintained so should
be removed.

Change-Id: I9410171e1025e428b48e5dd12c7dc1161cc800f6
2024-09-06 21:11:04 +00:00
Ed Sanders 64e586d2a4 Follow-up Ie0a938249: Add comment explaining why resize event is needed
Bug: T374092
Change-Id: I27e66bbab4c2f915c80db8ac823972b2f31a07e9
2024-09-06 14:50:03 +01:00
jenkins-bot 5f944947e4 Merge "Reset border-radius on links" 2024-09-05 18:15:52 +00:00
Ed Sanders f653d50f12 Emit a window resize event when client preferences are changed
Bug: T374092
Change-Id: Ie0a9382498c682ac8c1f7942cc3590e9789a1e80
2024-09-05 11:26:43 +01:00
jenkins-bot e2d1b76da5 Merge "Fix override to let indicators float into heading area on legacy Vector" 2024-09-05 01:41:17 +00:00
Jon Robson a6e4370bbd Fixes: Echo icon not visible after click
Due to T343838, we need to adjust the Echo icon after clicking
so it renders consistently with Codex. This is a longstanding bug
and a slight adjustment to how we approach the icon now that Codex
and Vector 2022 use mask-image for their icons.

Bug: T373936
Change-Id: Icdb9cc49c157cb5cbf13fe1f7d5e91b7e986e92e
2024-09-04 18:16:13 +00:00
Ed Sanders 317107b3f6 Reset border-radius on links
This was introduced in I16411a7ea47, which only documented the
changes to the colors used. An unintended side effect was inheriting
the standard border-radius, but that should be applied in a
more targetted manner to avoid conflicting with existing
UI components (e.g. OOUI toolbars).

Bug: T373989
Change-Id: I0615ce1594d66cb5207cd119597ae4d0765e94af
2024-09-04 12:06:33 +01:00
Bartosz Dziewoński aac902c545 Fix override to let indicators float into heading area on legacy Vector
Bug: T373617
Change-Id: I05124bbd20833cd4051ba5b51f7962ce223a5ee2
2024-09-04 03:10:51 +02:00
ksarabia ae6f0d5486 Remove old limited width toggle
* Removes js
* Updates bottomDock style rules
* skin mustache updated
* Remove appearance feature flag - show appearance menu
to all users.

Bug: T367591
Change-Id: Ie2617e2fa83b6a888a7a2799cc39f048731dc60d
2024-09-03 11:25:23 -07:00
Jon Robson 0a4f5c8dc9 Language button dropdown arrow should be progressive color
Currently black.
Flagged by Pixel.
Follow up to 010e7e92d

Bug: T363920
Change-Id: Iaa9ea69c8a1f1b50bb8eedda1acc2c657bef0132
2024-08-29 20:27:57 +00:00
jenkins-bot 92a73b6701 Merge "styles: Remove outdated skin variable" 2024-08-29 19:57:18 +00:00
Volker E. f0b5f234c4 styles: Remove outdated skin variable
`@opacity-base--disabled` is not used anywhere
including in the Vector skin anymore.

Change-Id: Ia0a483b8d3e2d5597aeb512d04f6dc2e95317430
2024-08-29 19:41:36 +02:00
Jon Robson 9695647608 VISUAL CHANGE: Use mask-image for all Vector icons
Visual changes are subtle, but impact 43 scenarios. The color
and positioning is slightly modified to match Codex.

Bug: T363920
Change-Id: Ie5c88e0aa243f73f2dc9f310d18fd59b831edc64
2024-08-29 17:17:35 +00:00
Jon Robson 1b4d07e1d2 Add tooltip to reporting link
Bug: T369849
Change-Id: I225c83e9ee1c95957479a684527d1297b7a471c1
2024-08-27 21:37:54 +00:00
jenkins-bot 66ca79e907 Merge "Remove "report" link for logged-out users" 2024-08-27 20:58:58 +00:00
jenkins-bot c0332419e4 Merge "Revert "Allow gadget/browser extension extensibility of empty search state"" 2024-08-27 17:59:27 +00:00
Jon Robson 16b300ca45 Remove "report" link for logged-out users
Bug: T372754
Change-Id: I8225791f24271cbb8319f07f3a300c62f51e826a
2024-08-27 17:50:47 +00:00
Jdlrobson 0e030b1310 Revert "Allow gadget/browser extension extensibility of empty search state"
This reverts commit 98bee1c71f.

Reason for revert: This wasn't ready for merging. Caused T373463.

Change-Id: Id02bc3528216d1a43e6b505b44362059ab0ffc69
2024-08-27 17:15:51 +00:00
jenkins-bot 9390bb9046 Merge "Fix workaround for position: sticky disabling subpixel rendering" 2024-08-26 21:07:25 +00:00
jenkins-bot 43c6c7f95c Merge "Allow gadget/browser extension extensibility of empty search state" 2024-08-26 16:51:06 +00:00