wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-23 23:33:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused margin/padding override for '#mw-head h3'

Browse source 
Matches the following 6 elements:

1. h3#p-personal-label
   Hidden per `#p-personal h3`.

2. h3#p-namespaces-label
3. h3#p-views-label
   Hidden per `div.vectorTabs h3`.

4. #p-search h3
   Already has its own margin and padding that override
   this override.

5. h3#p-variants-label
6. h3#p-cactions-label
   Margin overriden by `div#mw-head div.vectorMenu h3`.
   Moved padding there as well.

This last one is the one the styles were originally intended for,
because the tabs that the menus align with also don't have padding.

The other instances of an 'h3' within mw-head, however, were not
vector menus and even if they didn't have their own padding
already or weren't display-none, then it's unlikely they would
want to align with the unrelated vectorMenu styles, e.g. the
p-personal area is quite different and just happens to be in
the same parent element as an h3.

Change-Id: Id127ead7a50fcd64821442afd0e781f97756502f
This commit is contained in:
Timo Tijhof 2018-05-31 03:14:30 +01:00 committed by Bartosz Dziewoński
parent 426230807c
commit feca6b276b
2 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
components/navigation.less
View file

@ -35,11 +35,6 @@
top: 0; top: 0;
right: 0; right: 0;
width: 100%; width: 100%;
h3 {
margin: 0;
padding: 0;
}
} }
/* Navigation Containers */ /* Navigation Containers */

10
components/tabs.less
View file

@ -107,10 +107,12 @@
background-position: bottom right; background-position: bottom right;
font-size: 1em; font-size: 1em;
height: 2.5em; height: 2.5em;
// `padding-right` >= `1px` effectively moves the "background border" outside of the element to act like a real // `padding-right` >= `1px` effectively moves the "background border" outside of the element to
// border. It is necessary for `.vectorMenu .menu` dropdown to align well. // act like a real border. It is necessary for `.vectorMenu .menu` dropdown to align well.
padding-right: 0.5em; // equals `8px` at computed `font-size` of `14px` as visually harmonically with `padding-left` in `.vectorMenu h3 span` // 0.5em equals `8px` at computed `font-size` of `14px` as visually harmonically with
margin-right: -1px; // `padding-left` in `.vectorMenu h3 span`
padding: 0 0.5em 0 0;
margin: 0 -1px 0 0;
} }
.vectorMenu h3 { .vectorMenu h3 {