wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-24 07:43:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't pass $this by reference

Browse source 
Bug: T153505
Change-Id: Ife076b323b1f4091fd851acb4b470000d2206cae
This commit is contained in:
Kunal Mehta 2017-08-31 21:09:15 -07:00 committed by Reedy
parent 38c524d370
commit edff0350a1
2 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
VectorTemplate.php
View file

@ -288,7 +288,9 @@ class VectorTemplate extends BaseTemplate {
echo $this->makeListItem( $key, $val ); echo $this->makeListItem( $key, $val );
} }
if ( $hook !== null ) { if ( $hook !== null ) {
Hooks::run( $hook, [ &$this, true ] ); // Avoid PHP 7.1 warning
$skin = $this;
Hooks::run( $hook, [ &$skin, true ] );
} }
?> ?>
</ul> </ul>

5
phpcs.xml
View file

@ -1,11 +1,10 @@
<?xml version="1.0"?> <?xml version="1.0"?>
<ruleset> <ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki"> <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="MediaWiki.Commenting.FunctionComment.MissingParamComment"/> <exclude name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingParamTag"/> <exclude name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingReturn" /> <exclude name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" /> <exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
<exclude name="MediaWiki.Usage.ReferenceThis.Found"/>
</rule> </rule>
<file>.</file> <file>.</file>
<arg name="extensions" value="php,php5,inc"/> <arg name="extensions" value="php,php5,inc"/>