From e5ef6f5f64c160b3a6a57ea9433ea9976454f1ce Mon Sep 17 00:00:00 2001
From: tsepothoabala <tthoabala@wikimedia.org>
Date: Wed, 7 Jun 2023 13:46:26 +0200
Subject: [PATCH] Prevent Skins Vector from setting preferences for temporary
 accounts

Bug: T337874
Change-Id: I83ca625276569349abcd6622d295137c5c4ffe2c
---
 package-lock.json                     | 28 +++++++++++++--------------
 package.json                          |  4 ++--
 resources/skins.vector.js/features.js |  2 +-
 3 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 31e977e9b..ddf480f1b 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -15,8 +15,8 @@
 				"@wikimedia/codex": "0.11.0",
 				"@wikimedia/codex-icons": "0.11.0",
 				"@wikimedia/codex-search": "0.11.0",
-				"@wikimedia/mw-node-qunit": "7.0.0",
-				"@wikimedia/types-wikimedia": "0.4.0",
+				"@wikimedia/mw-node-qunit": "7.1.0",
+				"@wikimedia/types-wikimedia": "0.4.1",
 				"eslint-config-wikimedia": "0.25.0",
 				"eslint-plugin-no-jquery": "2.7.0",
 				"grunt-banana-checker": "0.10.0",
@@ -2504,9 +2504,9 @@
 			}
 		},
 		"node_modules/@wikimedia/mw-node-qunit": {
-			"version": "7.0.0",
-			"resolved": "https://registry.npmjs.org/@wikimedia/mw-node-qunit/-/mw-node-qunit-7.0.0.tgz",
-			"integrity": "sha512-EJncCjJVxfiZVdlFMs0RWX3Xz7ol/wXH09Yd4Kz7T3fDJ1dEzTlTqI7YODeZx6OM6ov+7cm1EiBonMo8tA+ujQ==",
+			"version": "7.1.0",
+			"resolved": "https://registry.npmjs.org/@wikimedia/mw-node-qunit/-/mw-node-qunit-7.1.0.tgz",
+			"integrity": "sha512-1tkM5ipfEcPpChyW+Q7yIHN9F12lbjQeqRQdipnBzaQab0tlrl7+o2DjWVJ07KtABMSJpbOVpUL4p6UTDKjLvw==",
 			"dev": true,
 			"dependencies": {
 				"glob": "7.2.0",
@@ -2532,9 +2532,9 @@
 			}
 		},
 		"node_modules/@wikimedia/types-wikimedia": {
-			"version": "0.4.0",
-			"resolved": "https://registry.npmjs.org/@wikimedia/types-wikimedia/-/types-wikimedia-0.4.0.tgz",
-			"integrity": "sha512-yFHc/cWCqF6m4Tg9xZEW8f+gUYPBGkGgSza2IaXf8B58K/Rv0nWpMjcUjx7bJX3qTbbnbccCfi+OBNie1KAZxA==",
+			"version": "0.4.1",
+			"resolved": "https://registry.npmjs.org/@wikimedia/types-wikimedia/-/types-wikimedia-0.4.1.tgz",
+			"integrity": "sha512-RJUZXQNo+z7zBjcRSsVRR5GH2/R8/aSJc9Vo/ntnTzr8v1TjUlM3Dh4sP6XQODYKm/0HQn+hln3bWyeU6YTyRw==",
 			"dev": true
 		},
 		"node_modules/abab": {
@@ -15065,9 +15065,9 @@
 			"requires": {}
 		},
 		"@wikimedia/mw-node-qunit": {
-			"version": "7.0.0",
-			"resolved": "https://registry.npmjs.org/@wikimedia/mw-node-qunit/-/mw-node-qunit-7.0.0.tgz",
-			"integrity": "sha512-EJncCjJVxfiZVdlFMs0RWX3Xz7ol/wXH09Yd4Kz7T3fDJ1dEzTlTqI7YODeZx6OM6ov+7cm1EiBonMo8tA+ujQ==",
+			"version": "7.1.0",
+			"resolved": "https://registry.npmjs.org/@wikimedia/mw-node-qunit/-/mw-node-qunit-7.1.0.tgz",
+			"integrity": "sha512-1tkM5ipfEcPpChyW+Q7yIHN9F12lbjQeqRQdipnBzaQab0tlrl7+o2DjWVJ07KtABMSJpbOVpUL4p6UTDKjLvw==",
 			"dev": true,
 			"requires": {
 				"glob": "7.2.0",
@@ -15089,9 +15089,9 @@
 			}
 		},
 		"@wikimedia/types-wikimedia": {
-			"version": "0.4.0",
-			"resolved": "https://registry.npmjs.org/@wikimedia/types-wikimedia/-/types-wikimedia-0.4.0.tgz",
-			"integrity": "sha512-yFHc/cWCqF6m4Tg9xZEW8f+gUYPBGkGgSza2IaXf8B58K/Rv0nWpMjcUjx7bJX3qTbbnbccCfi+OBNie1KAZxA==",
+			"version": "0.4.1",
+			"resolved": "https://registry.npmjs.org/@wikimedia/types-wikimedia/-/types-wikimedia-0.4.1.tgz",
+			"integrity": "sha512-RJUZXQNo+z7zBjcRSsVRR5GH2/R8/aSJc9Vo/ntnTzr8v1TjUlM3Dh4sP6XQODYKm/0HQn+hln3bWyeU6YTyRw==",
 			"dev": true
 		},
 		"abab": {
diff --git a/package.json b/package.json
index 0b255614a..7143ed56c 100644
--- a/package.json
+++ b/package.json
@@ -28,8 +28,8 @@
 		"@wikimedia/codex": "0.11.0",
 		"@wikimedia/codex-icons": "0.11.0",
 		"@wikimedia/codex-search": "0.11.0",
-		"@wikimedia/mw-node-qunit": "7.0.0",
-		"@wikimedia/types-wikimedia": "0.4.0",
+		"@wikimedia/mw-node-qunit": "7.1.0",
+		"@wikimedia/types-wikimedia": "0.4.1",
 		"eslint-config-wikimedia": "0.25.0",
 		"eslint-plugin-no-jquery": "2.7.0",
 		"grunt-banana-checker": "0.10.0",
diff --git a/resources/skins.vector.js/features.js b/resources/skins.vector.js/features.js
index e9bb00759..177c8e399 100644
--- a/resources/skins.vector.js/features.js
+++ b/resources/skins.vector.js/features.js
@@ -10,7 +10,7 @@ const debounce = require( /** @type {string} */ ( 'mediawiki.util' ) ).debounce;
  * @param {boolean} enabled
  */
 function save( feature, enabled ) {
-	if ( mw.user.isAnon() ) {
+	if ( !mw.user.isNamed() ) {
 		switch ( feature ) {
 			case 'limited-width':
 				if ( enabled ) {