wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-28 01:20:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't change function signature of buildSidebar

Browse source 
Rename buildSidebar to getTemplateDataSidebar to reflect what it is
doing in Vector rather than overloading it with template data generation.

Changing the return value has consequences on refactors
inside core a Skin::buildSidebar returns an array not an
associative array.

Change-Id: I0a4913c21af6ac3f5259cee8583aa121756251c1
This commit is contained in:
jdlrobson 2020-09-04 12:17:57 -07:00 committed by Jdlrobson
parent f5323d9bf1
commit d61cae0086
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
includes/SkinVector.php
View file

@ -136,7 +136,7 @@ class SkinVector extends SkinMustache {
'data-logos' => ResourceLoaderSkinModule::getAvailableLogos( $this->getConfig() ),
'main-page-href' => $mainPageHref,
'data-sidebar' => $this->buildSidebar(),
'data-sidebar' => $this->getTemplateDataSidebar(),
'sidebar-visible' => $this->isSidebarVisible(),
] + $this->getMenuProps();
@ -253,9 +253,9 @@ class SkinVector extends SkinMustache {
*
* @return array
*/
public function buildSidebar() {
private function getTemplateDataSidebar() {
$skin = $this;
$portals = parent::buildSidebar();
$portals = $this->buildSidebar();
$props = [];
$languages = null;