From d0775a2af9048c46e5bedac1312ff4d40f46c825 Mon Sep 17 00:00:00 2001 From: bwang Date: Mon, 3 Oct 2022 16:22:48 -0500 Subject: [PATCH] Technical: Cached HTML cleanup Change-Id: I6638a816fba3002289236f50d3d0e976f478affe --- resources/skins.vector.es6/tableOfContents.js | 3 --- resources/skins.vector.styles/components/MenuTabs.less | 8 -------- resources/skins.vector.styles/components/UserLinks.less | 2 -- 3 files changed, 13 deletions(-) diff --git a/resources/skins.vector.es6/tableOfContents.js b/resources/skins.vector.es6/tableOfContents.js index a4f920e77..9fa4b72ed 100644 --- a/resources/skins.vector.es6/tableOfContents.js +++ b/resources/skins.vector.es6/tableOfContents.js @@ -329,9 +329,6 @@ module.exports = function tableOfContents( props ) { */ function bindCollapseToggleListeners() { // Initialize toc collapsed status - // FIXME: Remove after I17f2699fec113d92b3f0f223c357654f52eb7eb3 has been in prod for a week - document.body.classList.add( TOC_NOT_COLLAPSED_CLASS ); - const showHideTocElement = document.querySelectorAll( '#sidebar-toc-label button' ); showHideTocElement.forEach( function ( btn ) { btn.addEventListener( 'click', () => { diff --git a/resources/skins.vector.styles/components/MenuTabs.less b/resources/skins.vector.styles/components/MenuTabs.less index 0cad6b6dd..61e019c10 100644 --- a/resources/skins.vector.styles/components/MenuTabs.less +++ b/resources/skins.vector.styles/components/MenuTabs.less @@ -15,9 +15,6 @@ } /* focus and hover have outlines. Text underline interferes with bottom border */ - /* FIXME: Remove 2 not selectors when cache has cleared for Ie2ffa5c3ecf270c1bb1f315937023ae7ace5ed30 */ - .mw-list-item a:not( .mw-ui-icon ):focus, - .mw-list-item a:not( .mw-ui-icon ):hover, .mw-list-item.vector-tab-noicon a:focus, .mw-list-item.vector-tab-noicon a:hover { text-decoration: none; @@ -40,8 +37,6 @@ * Tab list item appearance. Applies to both
  • 's inside .vector-menu-tabs * and dropdown menus inside the article toolbar */ -// FIXME: Remove the body selector once Ie2ffa5c3ecf270c1bb1f315937023ae7ace5ed30 is in production -/* for cached HTML */ body:not( .vector-feature-visual-enhancement-next-enabled ) .vector-menu-tabs .mw-list-item, .vector-menu-tabs .mw-list-item.vector-tab-noicon, .mw-article-toolbar-container .vector-menu-dropdown { margin: 0 @padding-horizontal-tabs; @@ -75,10 +70,7 @@ font-size: inherit; } - /* FIXME: Remove cached HTML selector (> a:not( .mw-ui-icon )) - when Ie2ffa5c3ecf270c1bb1f315937023ae7ace5ed30 is in production */ &.vector-tab-noicon > a, - & > a:not( .mw-ui-icon ), .vector-menu-heading { // Top & bottom padding to increase clickable area. padding: 18px 0 7px 0; diff --git a/resources/skins.vector.styles/components/UserLinks.less b/resources/skins.vector.styles/components/UserLinks.less index 94c837913..c843d0e47 100644 --- a/resources/skins.vector.styles/components/UserLinks.less +++ b/resources/skins.vector.styles/components/UserLinks.less @@ -66,8 +66,6 @@ /** * Horizontal links menu - logged in and logged out. */ -// TODO: Remove vector-user-menu-more after I371bb11903d8cdd8f0da89266fcf549050c0da8c has been in prod for a week -.vector-user-menu-more, .vector-user-menu-overflow { .vector-menu-content-list { display: flex;