wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-24 07:43:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Linting: run npm -s run lint:js -- --fix

Browse source 
reduce the number of warnings on precommit hook

Change-Id: Iad9fa273f9a661614fa3e40e1af6e9aa7697ea42
This commit is contained in:
Moh'd Khier Abualruz 2023-03-22 17:33:35 +01:00 committed by Jdlrobson
parent a75586a749
commit bd7be711df
4 changed files with 9 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
resources/skins.vector.es6/scrollObserver.js
View file

@ -30,7 +30,6 @@ function firePageTitleScrollHook( direction ) {
* @return {IntersectionObserver}
*/
function initScrollObserver( show, hide ) {
/* eslint-disable-next-line compat/compat */
return new IntersectionObserver( function ( entries ) {
if ( !entries[ 0 ].isIntersecting && entries[ 0 ].boundingClientRect.top < 0 ) {
// Viewport has crossed the bottom edge of the target element.

25
resources/skins.vector.es6/stickyHeader.js
View file

@ -7,12 +7,11 @@ const
STICKY_HEADER_APPENDED_ID = '-sticky-header',
STICKY_HEADER_APPENDED_PARAM = [ 'wvprov', 'sticky-header' ],
STICKY_HEADER_VISIBLE_CLASS = 'vector-sticky-header-visible',
STICKY_HEADER_USER_MENU_CONTAINER_CLASS = 'vector-sticky-header-icon-end',
STICKY_HEADER_USER_MENU_CONTAINER_SELECTOR = '.vector-sticky-header-icon-end .vector-user-links',
FIRST_HEADING_ID = 'firstHeading',
USER_LINKS_DROPDOWN_ID = 'vector-user-links-dropdown',
ULS_STICKY_CLASS = 'uls-dialog-sticky',
ULS_HIDE_CLASS = 'uls-dialog-sticky-hide',
VECTOR_USER_LINKS_SELECTOR = '.vector-user-links',
SEARCH_TOGGLE_SELECTOR = '.vector-sticky-header-search-toggle',
STICKY_HEADER_EDIT_EXPERIMENT_NAME = 'vector.sticky_header_edit',
STICKY_HEADER_EXPERIMENT_NAME = 'vector.sticky_header';
@ -82,7 +81,7 @@ function suffixStickyAttribute( node, attribute ) {
* @param {Element} node
*/
function suffixStickyHref( node ) {
/* eslint-disable compat/compat */
// @ts-ignore
const url = new URL( node.href );
if ( url && !url.searchParams.has( STICKY_HEADER_APPENDED_PARAM[ 0 ] ) ) {
@ -101,7 +100,7 @@ function suffixStickyHref( node ) {
* @param {Element} node
*/
function unsuffixStickyHref( node ) {
/* eslint-disable compat/compat */
// @ts-ignore
const url = new URL( node.href );
url.searchParams.delete( STICKY_HEADER_APPENDED_PARAM[ 0 ] );
@ -427,7 +426,6 @@ function prepareUserLinksDropdown( userLinksDropdown ) {
*
* @param {Element} header
* @param {Element} userLinksDropdown
* @param {Element} userLinksDropdownStickyContainer
* @param {IntersectionObserver} stickyObserver
* @param {Element} stickyIntersection
* @param {boolean} disableEditIcons
@ -435,18 +433,18 @@ function prepareUserLinksDropdown( userLinksDropdown ) {
function makeStickyHeaderFunctional(
header,
userLinksDropdown,
userLinksDropdownStickyContainer,
stickyObserver,
stickyIntersection,
disableEditIcons
) {
const
userLinksDropdownStickyContainerInner = userLinksDropdownStickyContainer
.querySelector( VECTOR_USER_LINKS_SELECTOR );
const userLinksDropdownStickyContainer = document.querySelector(
STICKY_HEADER_USER_MENU_CONTAINER_SELECTOR
);
// Clone the updated user menu to the sticky header.
if ( userLinksDropdownStickyContainerInner ) {
userLinksDropdownStickyContainerInner.appendChild( prepareUserLinksDropdown( userLinksDropdown ) );
if ( userLinksDropdownStickyContainer ) {
const clonedUserLinksDropdown = prepareUserLinksDropdown( userLinksDropdown );
userLinksDropdownStickyContainer.appendChild( clonedUserLinksDropdown );
}
let namespaceName = mw.config.get( 'wgCanonicalNamespace' );
@ -551,14 +549,9 @@ function isAllowedAction( action ) {
* @param {StickyHeaderProps} props
*/
function initStickyHeader( props ) {
const userLinksDropdownStickyContainer = document.getElementsByClassName(
STICKY_HEADER_USER_MENU_CONTAINER_CLASS
)[ 0 ];
makeStickyHeaderFunctional(
props.header,
props.userLinksDropdown,
userLinksDropdownStickyContainer,
props.observer,
props.stickyIntersection,
props.disableEditIcons

1
resources/skins.vector.search/fetch.js
View file

@ -25,7 +25,6 @@ function fetchJson( resource, init ) {
// As of 2020, browser support for AbortController is limited:
// https://caniuse.com/abortcontroller
// so replacing it with no-op if it doesn't exist.
/* eslint-disable compat/compat */
const controller = window.AbortController ?
new AbortController() :
nullAbortController;

2
resources/skins.vector.search/instrumentation.js
View file

@ -12,7 +12,6 @@ const INPUT_LOCATION_MOVED = 'header-moved',
shouldTestSearchPerformance = !!( window.performance &&
// @ts-ignore
window.requestAnimationFrame &&
/* eslint-disable compat/compat */
// @ts-ignore
performance.mark &&
// @ts-ignore
@ -40,7 +39,6 @@ function onFetchStart() {
performance.clearMarks( queryMark );
}
/* eslint-disable-next-line compat/compat */
performance.mark( queryMark );
}