mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git
synced 2024-09-23 18:29:49 +00:00
Address some code FIXMEs
- Remove references to the removed wgVectorUseWvuiSearch configuration - Remove mw-body qualifier on Indicators component. - Drops some cache related FIXMEs Change-Id: I6823b9c5bf19a067b56badf29f874a7127867a09
This commit is contained in:
parent
9c6d3f7b7b
commit
b86dbc756c
|
@ -126,8 +126,7 @@ class Hooks {
|
||||||
}
|
}
|
||||||
|
|
||||||
// Tell the `mediawiki.page.ready` module not to wire up search.
|
// Tell the `mediawiki.page.ready` module not to wire up search.
|
||||||
// This allows us to use $wgVectorUseWvuiSearch to decide to load
|
// This allows us to use the new Vue implementation.
|
||||||
// the historic jquery autocomplete search or the new Vue implementation.
|
|
||||||
// ResourceLoaderContext has no knowledge of legacy / modern Vector
|
// ResourceLoaderContext has no knowledge of legacy / modern Vector
|
||||||
// and from its point of view they are the same thing.
|
// and from its point of view they are the same thing.
|
||||||
// Please see the modules `skins.vector.js` and `skins.vector.legacy.js`
|
// Please see the modules `skins.vector.js` and `skins.vector.legacy.js`
|
||||||
|
|
|
@ -1,8 +1,4 @@
|
||||||
/** See Vector\Hooks::getVectorResourceLoaderConfig */
|
/** See Vector\Hooks::getVectorResourceLoaderConfig */
|
||||||
interface VectorResourceLoaderVirtualConfig {
|
interface VectorResourceLoaderVirtualConfig {
|
||||||
wgVectorSearchHost: string;
|
wgVectorSearchHost: string;
|
||||||
/**
|
|
||||||
* The name of the ResourceLoader module that contains search.
|
|
||||||
*/
|
|
||||||
wgVectorUseWvuiSearch: boolean
|
|
||||||
}
|
}
|
||||||
|
|
|
@ -1,14 +1,11 @@
|
||||||
@import '../variables.less';
|
@import '../variables.less';
|
||||||
|
|
||||||
// FIXME: Is specific `.mw-body` even needed? Does `.mw-indicators` exist outside?
|
.mw-indicators {
|
||||||
.mw-body {
|
font-size: @font-size-base;
|
||||||
.mw-indicators {
|
line-height: @line-height-base;
|
||||||
font-size: @font-size-base;
|
position: relative;
|
||||||
line-height: @line-height-base;
|
}
|
||||||
position: relative;
|
|
||||||
}
|
.mw-indicator {
|
||||||
|
display: inline-block;
|
||||||
.mw-indicator {
|
|
||||||
display: inline-block;
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
|
@ -2,8 +2,7 @@
|
||||||
@import '../../common/variables.less';
|
@import '../../common/variables.less';
|
||||||
@import 'mediawiki.mixins.less';
|
@import 'mediawiki.mixins.less';
|
||||||
|
|
||||||
// TODO: `#p-lang-btn` Can be changed to `.mw-portlet-lang` when languages-in-header is the default.
|
.mw-portlet-lang {
|
||||||
#p-lang-btn {
|
|
||||||
// FIXME [review whether margin-top is needed] center vertically in heading.
|
// FIXME [review whether margin-top is needed] center vertically in heading.
|
||||||
margin-top: 2px;
|
margin-top: 2px;
|
||||||
.box-sizing( border-box );
|
.box-sizing( border-box );
|
||||||
|
@ -24,8 +23,6 @@
|
||||||
// Remove opacity on language button (it applies to more menu because of label color).
|
// Remove opacity on language button (it applies to more menu because of label color).
|
||||||
opacity: 1;
|
opacity: 1;
|
||||||
|
|
||||||
// FIXME: `span:not` rule can be removed when cache has cleared.
|
|
||||||
span:not( .mw-ui-icon ),
|
|
||||||
.vector-menu-heading-label {
|
.vector-menu-heading-label {
|
||||||
// Special treatment for language button, based on Vector font-size
|
// Special treatment for language button, based on Vector font-size
|
||||||
font-size: @font-size-base;
|
font-size: @font-size-base;
|
||||||
|
|
|
@ -42,9 +42,6 @@
|
||||||
}
|
}
|
||||||
|
|
||||||
// Only apply the following WVUI-related rules to clients who have js enabled.
|
// Only apply the following WVUI-related rules to clients who have js enabled.
|
||||||
// TODO: .skin-vector-search-vue class can be removed when $wgVectorUseWvuiSearch is no longer supported
|
|
||||||
// OR .vector-search-box-vue is in cached HTML.
|
|
||||||
.client-js .skin-vector-search-vue,
|
|
||||||
.client-js .vector-search-box-vue {
|
.client-js .vector-search-box-vue {
|
||||||
// Derived from @size-search-figure in WVUI
|
// Derived from @size-search-figure in WVUI
|
||||||
// https://gerrit.wikimedia.org/r/plugins/gitiles/wvui/+/e32b54f3b8d1118b6a25cdc46b5638d6d048533e/src/themes/wikimedia-ui.less#21
|
// https://gerrit.wikimedia.org/r/plugins/gitiles/wvui/+/e32b54f3b8d1118b6a25cdc46b5638d6d048533e/src/themes/wikimedia-ui.less#21
|
||||||
|
|
|
@ -111,8 +111,7 @@ body {
|
||||||
.mixin-clearfix();
|
.mixin-clearfix();
|
||||||
}
|
}
|
||||||
|
|
||||||
// TODO: Can be changed to `.mw-body .mw-portlet-lang` when language-in-header feature is default.
|
.mw-body .mw-portlet-lang {
|
||||||
.mw-body #p-lang-btn {
|
|
||||||
float: right;
|
float: right;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue