wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-24 15:53:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Ensure language button works for no js users,"

Browse source
This commit is contained in:
jenkins-bot 2023-06-22 21:42:00 +00:00 committed by Gerrit Code Review
parent 4e9718b089 edf2c78765
commit ad5cd567bd
6 changed files with 21 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
resources/common/components/MenuDropdownCheckbox.less
View file

@ -55,6 +55,7 @@
position: absolute;
top: 0;
left: 0;
right: auto;
z-index: @z-index-stacking-1;
opacity: 0;
width: 100%;

6
resources/common/mixins.less
View file

@ -99,3 +99,9 @@
padding-right: @padding-horizontal-page-container-desktop-wide;
}
}
.mixin-vector-dropdown-content-flip() {
// Flip dropdown horizontal alignment
left: auto;
right: 0;
}

18
resources/skins.vector.styles/components/LanguageDropdown.less
View file

@ -13,10 +13,10 @@
// If there are no languages and JavaScript is not enabled there is no fallback so we hide
// the button altogether.
.mw-portlet-lang-heading-0 {
.client-nojs & {
display: none;
}
.client-nojs & .mw-portlet-lang-heading-0 {
// FIXME: remove !important after VectorZebra is the default
/* stylelint-disable-next-line declaration-no-important */
display: none !important;
}
.vector-menu-heading {
@ -60,17 +60,11 @@
// The `vector-menu-content` class is present twice in current implementation of language switcher
// (see FIXME in Dropdown/Open.mustache) so it is important we target the direct child.
> .vector-menu-content {
top: auto;
left: -@border-width-base;
right: -@border-width-base;
// align borders of open menu align with button
box-sizing: border-box;
max-height: 65vh;
overflow: auto;
// Adds to the show/hide technique in Dropdown.less with
// display to prevent rendering and long scrolling on Main page
display: none;
.mixin-vector-dropdown-content-flip();
li a {
font-size: inherit;
@ -88,8 +82,6 @@
// styles for less prominent Language button (without label) to be used for non-content pages (see T316559)
.mw-portlet-lang-heading-empty + .vector-menu-content {
left: auto;
right: 0;
min-width: 300px;
.mw-portlet-empty-language-selector-body {

4
resources/skins.vector.styles/components/PageToolbar.less
View file

@ -1,4 +1,5 @@
@import '../../common/variables.less';
@import '../../common/mixins.less';
@border-base-ems: unit( @border-width-base / @font-size-browser / @font-size-base, em );
@ -51,7 +52,6 @@
// Any dropdowns inside the right navigation in modern Vector (e.g. "more" menu).
// should be right-aligned to prevent horizontal scrolling.
.vector-menu-content {
left: auto;
right: -@border-width-base;
.mixin-vector-dropdown-content-flip();
}
}

3
resources/skins.vector.styles/components/UserLinks.less
View file

@ -26,8 +26,7 @@
*/
.vector-user-menu {
.vector-menu-content {
left: auto;
right: 0;
.mixin-vector-dropdown-content-flip();
}
// Used to hide collapsible items inside the dropdown menu

6
resources/skins.vector.zebra.styles/mixins.less
View file

@ -115,3 +115,9 @@
pointer-events: none; // Make the link below the fade clickable
}
}
.mixin-vector-dropdown-content-flip() {
// Flip dropdown horizontal alignment
left: auto;
right: 0;
}