From acf42aa48f1cf2888f9f2cb9647572bcbde1031c Mon Sep 17 00:00:00 2001 From: Nicholas Ray Date: Tue, 14 Jul 2020 12:19:09 -0600 Subject: [PATCH] Max-width layout: Make page container fill viewport if content height is small This will help mitigate the sidebar overflowing the page container (related to T257518). Note that this does not prevent the overflow from happening as the sidebar can still be longer than the viewport, but it should reduce the number of times it can happen. Bug: T257518 Change-Id: Id7138b4d4459242772bee8e11dc7edeaf76b3ca0 --- resources/skins.vector.styles/layout-max-width.less | 3 +++ 1 file changed, 3 insertions(+) diff --git a/resources/skins.vector.styles/layout-max-width.less b/resources/skins.vector.styles/layout-max-width.less index d9fc8954a..0258cd653 100644 --- a/resources/skins.vector.styles/layout-max-width.less +++ b/resources/skins.vector.styles/layout-max-width.less @@ -107,6 +107,9 @@ .mw-page-container { min-width: @min-width-page-container; max-width: @max-width-page-container; + // Fill the viewport even if the content height is small. This also helps + // mitigate a long sidebar overflowing the page container (T257518). + min-height: 100%; margin-left: auto; margin-right: auto; padding: 0 @padding-horizontal-page-container;