wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-12-01 02:37:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Add scroll padding to the root element when the sticky header is enabled"

Browse source
This commit is contained in:
jenkins-bot 2021-09-29 22:18:05 +00:00 committed by Gerrit Code Review
parent 67c309e27f 1209b388e9
commit ac3382e91c
2 changed files with 43 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
includes/SkinVector.php
View file

@ -66,6 +66,7 @@ class SkinVector extends SkinMustache {
'class' => 'sticky-header-icon' 'class' => 'sticky-header-icon'
]; ];
private const SEARCH_EXPANDING_CLASS = 'vector-search-box-show-thumbnail'; private const SEARCH_EXPANDING_CLASS = 'vector-search-box-show-thumbnail';
private const STICKY_HEADER_ENABLED_CLASS = 'vector-sticky-header-enabled';
/** /**
* T243281: Code used to track clicks to opt-out link. * T243281: Code used to track clicks to opt-out link.
@ -323,6 +324,26 @@ class SkinVector extends SkinMustache {
return parent::generateHTML(); return parent::generateHTML();
} }
/**
* @inheritDoc
*/
public function getHtmlElementAttributes() {
$original = parent::getHtmlElementAttributes();
if ( VectorServices::getFeatureManager()->isFeatureEnabled( Constants::FEATURE_STICKY_HEADER ) ) {
// T290518: Add scroll padding to root element when the sticky header is
// enabled. This class needs to be server rendered instead of added from
// JS in order to correctly handle situations where the sticky header
// isn't visible yet but we still need scroll padding applied (e.g. when
// the user navigates to a page with a hash fragment in the URI). For this
// reason, we can't rely on the `vector-sticky-header-visible` class as it
// is added too late.
$original['class'] = implode( ' ', [ $original['class'] ?? '', self::STICKY_HEADER_ENABLED_CLASS ] );
}
return $original;
}
/** /**
* Generate data needed to generate the sticky header. * Generate data needed to generate the sticky header.
* Lack of i18n is intentional and will be done as part of follow up work. * Lack of i18n is intentional and will be done as part of follow up work.

22
resources/skins.vector.styles/components/StickyHeader.less
View file

@ -1,8 +1,14 @@
@import '../../common/variables.less'; @import '../../common/variables.less';
@import 'mediawiki.mixins.less'; @import 'mediawiki.mixins.less';
// Set an explicit height. This is needed for scroll padding and for other
// sticky elements on the page. Setting the height in relative units enables
// the header's height to adapt to the browser's font size setting.
@height-sticky-header: unit( 60px / @font-size-browser, em );
.vector-sticky-header { .vector-sticky-header {
width: 100%; width: 100%;
height: @height-sticky-header;
position: fixed; position: fixed;
top: 0; top: 0;
left: 0; left: 0;
@ -122,3 +128,19 @@
.client-nojs .vector-sticky-header { .client-nojs .vector-sticky-header {
display: none; display: none;
} }
// T290518: When the sticky header is enabled (feature flag is on, js is
// enabled, and viewport is at higher resolutions), add scroll padding to the
// root element. This is needed so that the sticky header does not overlap the
// top of an element when the URI has a hash fragment (e.g. when the user clicks
// a jump link) and when the user tabs through elements in reverse order.
//
// Please note that this class must be independent of the
// .vector-sticky-header-visible class to correctly handle situations where the
// sticky header isn't visible yet but we still need scroll padding applied
// (e.g. when the user navigates to a page with a hash fragment in the URI).
@media ( min-width: @width-breakpoint-tablet ) {
.client-js.vector-sticky-header-enabled {
scroll-padding-top: @height-sticky-header;
}
}