wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-30 18:35:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Restore backwards compatibility

Browse source 
When status indicators were added, backwards compatibility was unnecessarily
broken. This makes things like looking at old non-rebased branches, or running
git bisect, unnecessarily annoying. This change adds an is_callable to restore
backwards compatibility and removes the version check that was added in response
to this break.

Change-Id: Ia05aa73a1b027e667c52f54b6d6fdf6f42bbbadf
This commit is contained in:
Jackmcbarn 2014-12-29 14:13:39 -05:00
parent 03ef4d392d
commit a925e9eae1
2 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Vector.php
View file

@ -22,12 +22,6 @@
* @ingroup Skins * @ingroup Skins
*/ */
if ( version_compare( $GLOBALS['wgVersion'], '1.25c', '<' ) ) {
echo 'This version of the Vector skin requires at least MediaWiki 1.25, you have ' . $GLOBALS['wgVersion'] .
'. You can download a more appropriate version here: https://www.mediawiki.org/wiki/Special:SkinDistributor/Vector';
exit();
}
$GLOBALS['wgExtensionCredits']['skin'][] = array( $GLOBALS['wgExtensionCredits']['skin'][] = array(
'path' => __FILE__, 'path' => __FILE__,
'name' => 'Vector', 'name' => 'Vector',

6
VectorTemplate.php
View file

@ -102,7 +102,11 @@ class VectorTemplate extends BaseTemplate {
<?php <?php
} }
?> ?>
<?php echo $this->getIndicators(); ?> <?php
if ( is_callable( array( $this, 'getIndicators' ) ) ) {
echo $this->getIndicators();
}
?>
<h1 id="firstHeading" class="firstHeading" lang="<?php <h1 id="firstHeading" class="firstHeading" lang="<?php
$this->data['pageLanguage'] = $this->data['pageLanguage'] =
$this->getSkin()->getTitle()->getPageViewLanguage()->getHtmlCode(); $this->getSkin()->getTitle()->getPageViewLanguage()->getHtmlCode();