wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-23 23:33:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove extra <span> from Vector tabs

Browse source 
No longer needed as of I8237976e0587.

Bug: T236410
Change-Id: I5a59c136de4572e5f11b52cc11bc93251c972369
This commit is contained in:
Timo Tijhof 2019-10-24 18:46:18 +01:00 committed by Krinkle
parent 481c90798e
commit a5fe72696b
1 changed files with 1 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
includes/VectorTemplate.php
View file

@ -280,9 +280,7 @@ class VectorTemplate extends BaseTemplate {
<ul<?php $this->html( 'userlangattributes' ) ?>> <ul<?php $this->html( 'userlangattributes' ) ?>>
<?php <?php
foreach ( $this->data['namespace_urls'] as $key => $item ) { foreach ( $this->data['namespace_urls'] as $key => $item ) {
echo $this->makeListItem( $key, $item, [ echo $this->makeListItem( $key, $item );
'vector-wrap' => true,
] );
} }
?> ?>
</ul> </ul>
@ -332,7 +330,6 @@ class VectorTemplate extends BaseTemplate {
<?php <?php
foreach ( $this->data['view_urls'] as $key => $item ) { foreach ( $this->data['view_urls'] as $key => $item ) {
echo $this->makeListItem( $key, $item, [ echo $this->makeListItem( $key, $item, [
'vector-wrap' => true,
'vector-collapsible' => true, 'vector-collapsible' => true,
] ); ] );
} }
@ -444,18 +441,6 @@ class VectorTemplate extends BaseTemplate {
} }
} }
/**
* @inheritDoc
*/
public function makeLink( $key, $item, $options = [] ) {
$html = parent::makeLink( $key, $item, $options );
// Add an extra wrapper because our CSS is weird
if ( isset( $options['vector-wrap'] ) && $options['vector-wrap'] ) {
$html = Html::rawElement( 'span', [], $html );
}
return $html;
}
/** /**
* @inheritDoc * @inheritDoc
*/ */