wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-24 15:53:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Factor out functions in PinnableElement.js

Browse source 
Splits the click handler for pinnable elements into
separate functions to reduce indentation and
maybe improve testability.

The click handler for pinnable elements is now
placed in a function called `togglePinnableElement()`
and attached to the click event via `.bind()`.

Class toggling is split into a separate
function called `togglePinnableClasses()` as well.

This should have no functional impact.

Change-Id: Ib27a469f6eb7e28360203d09db3315c6bde5c890
This commit is contained in:
Jan Drewniak 2022-12-16 14:15:56 -05:00 committed by Jdlrobson
parent bfeb729f84
commit 98c92edbba
1 changed files with 52 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

54
resources/skins.vector.es6/pinnableElement.js
View file

@ -3,22 +3,13 @@ const PINNED_HEADER_CLASS = 'vector-pinnable-header-pinned';
const UNPINNED_HEADER_CLASS = 'vector-pinnable-header-unpinned';
/**
* @param {HTMLElement} header
* Toggle classes on the body and pinnable element
*
* @param {HTMLElement} header pinnable element
*/
function bindPinnableToggleButtons( header ) {
const name = header.dataset.name;
if ( !name ) {
return;
}
function togglePinnableClasses( header ) {
const { featureName, name } = header.dataset;
const toggleButtons = header.querySelectorAll( '.vector-pinnable-header-toggle-button' );
const pinnableElementId = header.dataset.pinnableElementId;
const pinnedContainerId = header.dataset.pinnedContainerId;
const unpinnedContainerId = header.dataset.unpinnedContainerId;
const featureName = header.dataset.featureName;
toggleButtons.forEach( function ( button ) {
button.addEventListener( 'click', () => {
if ( featureName ) {
// Leverage features.js to toggle the body classes and persist the state
// for logged-in users.
@ -32,6 +23,23 @@ function bindPinnableToggleButtons( header ) {
// Toggle pinned class
header.classList.toggle( PINNED_HEADER_CLASS );
header.classList.toggle( UNPINNED_HEADER_CLASS );
}
/**
* Event handler that toggles the pinnable elements pinned state.
* Also moves the pinned element when those params are provided
* (via data attributes).
*
* @param {HTMLElement} header PinnableHeader element.
*/
function togglePinnableElement( header ) {
const {
pinnableElementId,
pinnedContainerId,
unpinnedContainerId
} = header.dataset;
togglePinnableClasses( header );
// Optional functionality of moving the pinnable element in the DOM
// to different containers based on it's pinned status
@ -39,7 +47,23 @@ function bindPinnableToggleButtons( header ) {
const newContainerId = isPinned( header ) ? pinnedContainerId : unpinnedContainerId;
movePinnableElement( pinnableElementId, newContainerId );
}
} );
}
/**
* Binds all the toggle buttons in a pinnableElement
* to the click handler that enables pinnability.
*
* @param {HTMLElement} header
*/
function bindPinnableToggleButtons( header ) {
if ( !header.dataset.name ) {
return;
}
const toggleButtons = header.querySelectorAll( '.vector-pinnable-header-toggle-button' );
toggleButtons.forEach( function ( button ) {
button.addEventListener( 'click', togglePinnableElement.bind( null, header ) );
} );
}