wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-30 18:35:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: Update linters

Browse source 
Change-Id: I8b99db813f12dc2031b5a1c195e6480f5512792a
This commit is contained in:
Ed Sanders 2019-01-11 13:03:15 +00:00
parent b4355e039f
commit 8634a77d0e
3 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
collapsibleTabs.js
View file

@ -143,12 +143,13 @@
// Remove the element from where it's at and put it in the dropdown menu // Remove the element from where it's at and put it in the dropdown menu
target = outerData.collapsedContainer; target = outerData.collapsedContainer;
// eslint-disable-next-line jquery/no-animate
$moving.css( 'position', 'relative' ) $moving.css( 'position', 'relative' )
.css( ( isRTL ? 'left' : 'right' ), 0 ) .css( ( isRTL ? 'left' : 'right' ), 0 )
.animate( { width: '1px' }, 'normal', function () { .animate( { width: '1px' }, 'normal', function () {
$( this ).hide(); $( this ).hide();
// add the placeholder // add the placeholder
$( '<span class="placeholder" style="display: none;"></span>' ).insertAfter( this ); $( '<span>' ).addClass( 'placeholder' ).css( 'display', 'none' ).insertAfter( this );
$( this ).detach().prependTo( target ).data( 'collapsibleTabsSettings', outerData ); $( this ).detach().prependTo( target ).data( 'collapsibleTabsSettings', outerData );
$( this ).attr( 'style', 'display: list-item;' ); $( this ).attr( 'style', 'display: list-item;' );
expContainerSettings.shifting = false; expContainerSettings.shifting = false;
@ -174,6 +175,7 @@
expandedWidth = data.expandedWidth; expandedWidth = data.expandedWidth;
$moving.css( 'position', 'relative' ).css( ( isRTL ? 'right' : 'left' ), 0 ).css( 'width', '1px' ); $moving.css( 'position', 'relative' ).css( ( isRTL ? 'right' : 'left' ), 0 ).css( 'width', '1px' );
$target.replaceWith( $target.replaceWith(
// eslint-disable-next-line jquery/no-animate
$moving $moving
.detach() .detach()
.css( 'width', '1px' ) .css( 'width', '1px' )

4
package.json
View file

@ -5,9 +5,9 @@
"doc": "jsduck" "doc": "jsduck"
}, },
"devDependencies": { "devDependencies": {
"eslint-config-wikimedia": "0.9.0", "eslint-config-wikimedia": "0.10.0",
"grunt": "1.0.3", "grunt": "1.0.3",
"grunt-banana-checker": "0.6.0", "grunt-banana-checker": "0.7.0",
"grunt-eslint": "21.0.0", "grunt-eslint": "21.0.0",
"grunt-jsonlint": "1.1.0", "grunt-jsonlint": "1.1.0",
"grunt-stylelint": "0.10.1", "grunt-stylelint": "0.10.1",

3
vector.js
View file

@ -1,6 +1,7 @@
/** /**
* Vector-specific scripts * Vector-specific scripts
*/ */
/* eslint-disable jquery/no-global-selector */
$( function () { $( function () {
/** /**
@ -32,6 +33,7 @@ $( function () {
// If the dropdown was hidden, show it // If the dropdown was hidden, show it
if ( $cactions.hasClass( 'emptyPortlet' ) ) { if ( $cactions.hasClass( 'emptyPortlet' ) ) {
$cactions.removeClass( 'emptyPortlet' ); $cactions.removeClass( 'emptyPortlet' );
// eslint-disable-next-line jquery/no-animate
$cactions.find( 'h3' ) $cactions.find( 'h3' )
.css( 'width', '1px' ) .css( 'width', '1px' )
.animate( { width: initialCactionsWidth() }, 'normal' ); .animate( { width: initialCactionsWidth() }, 'normal' );
@ -40,6 +42,7 @@ $( function () {
.on( 'beforeTabExpand', function () { .on( 'beforeTabExpand', function () {
// If we're removing the last child node right now, hide the dropdown // If we're removing the last child node right now, hide the dropdown
if ( $cactions.find( 'li' ).length === 1 ) { if ( $cactions.find( 'li' ).length === 1 ) {
// eslint-disable-next-line jquery/no-animate
$cactions.find( 'h3' ).animate( { width: '1px' }, 'normal', function () { $cactions.find( 'h3' ).animate( { width: '1px' }, 'normal', function () {
$( this ).attr( 'style', '' ) $( this ).attr( 'style', '' )
.parent().addClass( 'emptyPortlet' ); .parent().addClass( 'emptyPortlet' );