diff --git a/collapsibleTabs.js b/collapsibleTabs.js index eb9b5cc9c..9b13f4fce 100644 --- a/collapsibleTabs.js +++ b/collapsibleTabs.js @@ -143,12 +143,13 @@ // Remove the element from where it's at and put it in the dropdown menu target = outerData.collapsedContainer; + // eslint-disable-next-line jquery/no-animate $moving.css( 'position', 'relative' ) .css( ( isRTL ? 'left' : 'right' ), 0 ) .animate( { width: '1px' }, 'normal', function () { $( this ).hide(); // add the placeholder - $( '' ).insertAfter( this ); + $( '' ).addClass( 'placeholder' ).css( 'display', 'none' ).insertAfter( this ); $( this ).detach().prependTo( target ).data( 'collapsibleTabsSettings', outerData ); $( this ).attr( 'style', 'display: list-item;' ); expContainerSettings.shifting = false; @@ -174,6 +175,7 @@ expandedWidth = data.expandedWidth; $moving.css( 'position', 'relative' ).css( ( isRTL ? 'right' : 'left' ), 0 ).css( 'width', '1px' ); $target.replaceWith( + // eslint-disable-next-line jquery/no-animate $moving .detach() .css( 'width', '1px' ) diff --git a/package.json b/package.json index 4e66f41b2..8bcfe541a 100644 --- a/package.json +++ b/package.json @@ -5,9 +5,9 @@ "doc": "jsduck" }, "devDependencies": { - "eslint-config-wikimedia": "0.9.0", + "eslint-config-wikimedia": "0.10.0", "grunt": "1.0.3", - "grunt-banana-checker": "0.6.0", + "grunt-banana-checker": "0.7.0", "grunt-eslint": "21.0.0", "grunt-jsonlint": "1.1.0", "grunt-stylelint": "0.10.1", diff --git a/vector.js b/vector.js index 4e8c5a06e..e7e8cd0e1 100644 --- a/vector.js +++ b/vector.js @@ -1,6 +1,7 @@ /** * Vector-specific scripts */ +/* eslint-disable jquery/no-global-selector */ $( function () { /** @@ -32,6 +33,7 @@ $( function () { // If the dropdown was hidden, show it if ( $cactions.hasClass( 'emptyPortlet' ) ) { $cactions.removeClass( 'emptyPortlet' ); + // eslint-disable-next-line jquery/no-animate $cactions.find( 'h3' ) .css( 'width', '1px' ) .animate( { width: initialCactionsWidth() }, 'normal' ); @@ -40,6 +42,7 @@ $( function () { .on( 'beforeTabExpand', function () { // If we're removing the last child node right now, hide the dropdown if ( $cactions.find( 'li' ).length === 1 ) { + // eslint-disable-next-line jquery/no-animate $cactions.find( 'h3' ).animate( { width: '1px' }, 'normal', function () { $( this ).attr( 'style', '' ) .parent().addClass( 'emptyPortlet' );