wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-09-23 10:21:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Prevent dark-mode styles from affecting print media"

Browse source 
This reverts commit b3ca12e628.

Reason for revert: Icons are appearing black on black in dark mode
in origin/wmf/1.43.0-wmf.18.

Bug: T372370
Change-Id: Ifdf3970c77b66e5a7835ca44eb45deec2b44eb43
This commit is contained in:
Jdlrobson 2024-08-13 07:24:28 +00:00
parent 534a4b2040
commit 7cb145e9ef
4 changed files with 19 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
resources/skins.vector.styles/components/Icon.less
View file

@ -52,10 +52,8 @@
.vector-icon.mw-ui-icon-wikimedia-userGroup, .vector-icon.mw-ui-icon-wikimedia-userGroup,
.vector-icon.mw-ui-icon-wikimedia-listBullet, .vector-icon.mw-ui-icon-wikimedia-listBullet,
.vector-icon.mw-ui-icon-wikimedia-close { .vector-icon.mw-ui-icon-wikimedia-close {
@media screen { html.skin-theme-clientpref-night & {
html.skin-theme-clientpref-night & { filter: invert( 1 );
filter: invert( 1 );
}
} }
/** /**
@ -63,7 +61,7 @@
* *
* Applies the night mode color palette only in response to system settings. * Applies the night mode color palette only in response to system settings.
*/ */
@media screen and ( prefers-color-scheme: dark ) { @media ( prefers-color-scheme: dark ) {
html.skin-theme-clientpref-os & { html.skin-theme-clientpref-os & {
filter: invert( 1 ); filter: invert( 1 );
} }

8
resources/skins.vector.styles/media.less
View file

@ -22,13 +22,11 @@
} }
} }
@media screen { html.skin-theme-clientpref-night {
html.skin-theme-clientpref-night { .dark-mode-image-styles();
.dark-mode-image-styles();
}
} }
@media screen and ( prefers-color-scheme: dark ) { @media ( prefers-color-scheme: dark ) {
html.skin-theme-clientpref-os { html.skin-theme-clientpref-os {
.dark-mode-image-styles(); .dark-mode-image-styles();
} }

18
resources/skins.vector.styles/mixins.less
View file

@ -26,15 +26,13 @@
// https://phabricator.wikimedia.org/T319070#8284272 // https://phabricator.wikimedia.org/T319070#8284272
margin-left: 7px; margin-left: 7px;
@media screen { html.skin-theme-clientpref-night & {
html.skin-theme-clientpref-night & { // For night-mode, invert icons so they go from black to white.
// For night-mode, invert icons so they go from black to white. // Since invert( 1 ) changes the hue (e.g. from blue to orange)
// Since invert( 1 ) changes the hue (e.g. from blue to orange) // hue-rotate( 180deg ) changes the hue back to that of the original color.
// hue-rotate( 180deg ) changes the hue back to that of the original color. // This slightly corrects progressive/destructive colored icons
// This slightly corrects progressive/destructive colored icons // (although their lightness & saturation are still different, e.g. language button).
// (although their lightness & saturation are still different, e.g. language button). filter: invert( 1 ) hue-rotate( 180deg );
filter: invert( 1 ) hue-rotate( 180deg );
}
} }
/** /**
@ -42,7 +40,7 @@
* *
* Applies the night mode color palette only in response to system settings. * Applies the night mode color palette only in response to system settings.
*/ */
@media screen and ( prefers-color-scheme: dark ) { @media ( prefers-color-scheme: dark ) {
html.skin-theme-clientpref-os & { html.skin-theme-clientpref-os & {
filter: invert( 1 ) hue-rotate( 180deg ); filter: invert( 1 ) hue-rotate( 180deg );
} }

12
skinStyles/ext.visualEditor.less
View file

@ -6,16 +6,14 @@ html.ve-activated {
} }
// T367822 // T367822
@media screen { &.skin-theme-clientpref-night {
&.skin-theme-clientpref-night { .ve-ce-branchNode-blockSlug,
.ve-ce-branchNode-blockSlug, body p.ve-ce-branchNode-newSlug {
body p.ve-ce-branchNode-newSlug { background-color: rgba( 241, 247, 251, 0.1 );
background-color: rgba( 241, 247, 251, 0.1 );
}
} }
} }
@media screen and ( prefers-color-scheme: dark ) { @media ( prefers-color-scheme: dark ) {
&.skin-theme-clientpref-os { &.skin-theme-clientpref-os {
.ve-ce-branchNode-blockSlug, .ve-ce-branchNode-blockSlug,
body p.ve-ce-branchNode-newSlug { body p.ve-ce-branchNode-newSlug {