wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-09-23 10:21:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace border-color-portal-heading with Codex border-color-subtle

Browse source 
Replacing Vector specific variable with standard token that is meant
for exactly the applied use cases.
Note, I've left `border-color-subtle-transparent` because of that
extra engineering leg. I assume it was meant for animating the property,
which is not there. It seems better to me to replace this variable too
with `border-color-transparent`.

Change-Id: If264e04e576f044b98ec0d61b085f65af0110b6d
This commit is contained in:
Volker E 2023-10-19 00:40:51 -07:00 committed by bwang
parent 3ebd429f16
commit 783d67e077
5 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
resources/skins.vector.styles.legacy/components/LegacySidebar.less
View file

@ -3,7 +3,7 @@
@font-size-nav-main-heading: unit( 12 / @font-size-browser, em ); // Equals `0.75em`.
@font-size-nav-main-body: unit( 12 / @font-size-browser, em );
@margin-start-nav-main-body: 0.5em;
@border-color-portal-heading-transparent: rgba( red( @border-color-portal-heading ), green( @border-color-portal-heading ), blue( @border-color-portal-heading ), 0 );
@border-color-subtle-transparent: rgba( red( @border-color-subtle ), green( @border-color-subtle ), blue( @border-color-subtle ), 0 );
// Margin space from the start of the Portal (left edge in LTR
// languages).
@margin-start-portal: 0.7em;
@ -44,7 +44,7 @@
font-size: @font-size-nav-main-heading;
font-weight: normal;
cursor: default;
background-image: linear-gradient( to right, @border-color-portal-heading-transparent 0, @border-color-portal-heading 33%, @border-color-portal-heading 66%, @border-color-portal-heading-transparent 100% ); // Standard (Firefox 16+, IE 10+, Safari 6.1+, Chrome 26+)
background-image: linear-gradient( to right, @border-color-subtle-transparent 0, @border-color-subtle 33%, @border-color-subtle 66%, @border-color-subtle-transparent 100% ); // Standard (Firefox 16+, IE 10+, Safari 6.1+, Chrome 26+)
background-position: center bottom;
background-repeat: no-repeat;
background-size: 100% @border-width-base;

2
resources/skins.vector.styles.legacy/variables.less
View file

@ -54,7 +54,7 @@
@border-color-content: #a7d7f9;
// Due to darker background gradient, border needs to be darkened for aligned visual perception.
@border-color-content--tabs-inactive: darken( @border-color-content, 10% );
@border-color-portal-heading: #c8ccd1;
@border-color-subtle: #c8ccd1;
// Use `rgba()` notation for better Safari support, see T254489.
@border-start-blockquote: 4px @border-style-base #eaecf0;
@padding-top-content: 0.5em;

2
resources/skins.vector.styles/components/LanguageDropdown.less
View file

@ -70,7 +70,7 @@
.mw-portlet-empty-language-selector-body {
padding: 20px;
border-bottom: @border-style-base @border-width-base @border-color-portal-heading;
border-bottom: @border-style-base @border-width-base @border-color-subtle;
color: @color-subtle;
}
}

2
resources/skins.vector.styles/components/PageToolbar.less
View file

@ -4,7 +4,7 @@
display: flex;
font-size: unit( @font-size-small, rem );
// Use box-shadow instead of border to allow border collapsing between titlebar and toolbar
box-shadow: 0 1px @border-color-portal-heading;
box-shadow: 0 1px @border-color-subtle;
// Add bottom margin to account for box-shadow
margin-bottom: 1px;

1
resources/skins.vector.styles/variables.less
View file

@ -50,7 +50,6 @@
@size-icon: unit( 20 / @font-size-browser, em );
// Due to darker background gradient, border needs to be darkened for aligned visual perception.
@border-color-portal-heading: @border-color-subtle;
@border-start-blockquote: 4px @border-style-base @border-color-muted;
@padding-blockquote: 8px 32px;