wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-30 18:35:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add feature flag to "promote add topic" feature

Browse source 
Will be used to control rollout to WMF wikis but can
default to true here.

Bug: T267444
Change-Id: I716563efffc2401fbf5f8b53876a8b58706b1cda
This commit is contained in:
Ed Sanders 2023-02-24 13:48:29 +00:00
parent d90d1d17b1
commit 77734b1597
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
includes/SkinVector22.php
View file

@ -331,7 +331,8 @@ class SkinVector22 extends SkinMustache {
self::extractPageToolsFromSidebar( $sidebar, $pageToolsMenu ); self::extractPageToolsFromSidebar( $sidebar, $pageToolsMenu );
} }
$hasAddTopicButton = $this->removeAddTopicButton( $parentData ); $hasAddTopicButton = $config->get( 'VectorPromoteAddTopic' ) &&
$this->removeAddTopicButton( $parentData );
$langButtonClass = $langData['class'] ?? ''; $langButtonClass = $langData['class'] ?? '';
$ulsLabels = $this->getULSLabels(); $ulsLabels = $this->getULSLabels();

4
skin.json
View file

@ -598,6 +598,10 @@
}, },
"description": "An associative array of A/B test configs keyed by parameters noted in mediawiki.experiments.js. There must be an `unsampled` bucket that represents a population excluded from the experiment. Additionally, the treatment bucket(s) must include a case-insensitive `treatment` substring in their name (e.g. `treatment`, `stickyHeaderTreatment`, `sticky-header-treatment`)" "description": "An associative array of A/B test configs keyed by parameters noted in mediawiki.experiments.js. There must be an `unsampled` bucket that represents a population excluded from the experiment. Additionally, the treatment bucket(s) must include a case-insensitive `treatment` substring in their name (e.g. `treatment`, `stickyHeaderTreatment`, `sticky-header-treatment`)"
}, },
"VectorPromoteAddTopic": {
"value": true,
"description": "@var boolean Temporary feature flag that promotes the 'Add topic' link in the views menu, to a button in the page title bar."
},
"VectorDisableSidebarPersistence": { "VectorDisableSidebarPersistence": {
"value": false, "value": false,
"description": "@var boolean Temporary feature flag that disables saving the sidebar expanded/collapsed state as a user-preference (triggered via clicking the main menu icon). This is intended as a temporary kill-switch in the event that the DB is overloaded with writes to the user_options table." "description": "@var boolean Temporary feature flag that disables saving the sidebar expanded/collapsed state as a user-preference (triggered via clicking the main menu icon). This is intended as a temporary kill-switch in the event that the DB is overloaded with writes to the user_options table."